[JENKINS-22834] Administrator-approved classpath additions - Jenkins Jira

Details

Type: New Feature
Status: Resolved (View Workflow)
Priority: Major
Resolution: Fixed
Component/s: script-security-plugin
Labels:
None

Similar Issues:

Show

Description

Since it is not recommended to allow users to add arbitrary classpath elements to scripts, there should be a facility to let administrators define trusted classpath additions (JARs outside of plugins) that users may elect to use from their scripts.

Attachments

Issue Links

is related to

JENKINS-22835 User-defined source libraries

Resolved

Activity

Ascending order - Click to sort in descending order

View 14 older comments

SCM/JIRA link daemon added a comment - 2014-08-19 17:51

Code changed in jenkins
User: ikedam
Path:
src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java
src/main/resources/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/index.jelly
src/test/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApprovalTest.java
http://jenkins-ci.org/commit/script-security-plugin/c2841deb05927bdd31aafabd0350c29031a6ecbc
Log:
~~JENKINS-22834~~ Added tests for classpaths handling in the scriptApproval page.

SCM/JIRA link daemon added a comment - 2014-08-19 17:51 Code changed in jenkins User: ikedam Path: src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java src/main/resources/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/index.jelly src/test/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApprovalTest.java http://jenkins-ci.org/commit/script-security-plugin/c2841deb05927bdd31aafabd0350c29031a6ecbc Log: JENKINS-22834 Added tests for classpaths handling in the scriptApproval page.

SCM/JIRA link daemon added a comment - 2014-08-19 17:51

Code changed in jenkins
User: ikedam
Path:
src/main/java/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScript.java
src/test/java/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScriptTest.java
http://jenkins-ci.org/commit/script-security-plugin/51c74b6682d8e55acf29440f5404e1f21332e0a8
Log:
~~JENKINS-22834~~ Pareparation to merge. Revereted unrelated changes.

SCM/JIRA link daemon added a comment - 2014-08-19 17:51 Code changed in jenkins User: ikedam Path: src/main/java/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScript.java src/test/java/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScriptTest.java http://jenkins-ci.org/commit/script-security-plugin/51c74b6682d8e55acf29440f5404e1f21332e0a8 Log: JENKINS-22834 Pareparation to merge. Revereted unrelated changes.

Jesse Glick added a comment - 2014-08-19 17:51

Working on a variant in: https://github.com/jenkinsci/script-security-plugin/pull/2

Jesse Glick added a comment - 2014-08-19 17:51 Working on a variant in: https://github.com/jenkinsci/script-security-plugin/pull/2

Jesse Glick added a comment - 2014-08-19 17:54

Not merged to master.

Jesse Glick added a comment - 2014-08-19 17:54 Not merged to master .

SCM/JIRA link daemon added a comment - 2014-08-19 22:15

Code changed in jenkins
User: Jesse Glick
Path:
src/main/java/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScript.java
src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ApprovalListener.java
src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ClasspathEntry.java
src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java
src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApprovalLink.java
src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/UnapprovedClasspathException.java
src/main/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScript/config.jelly
src/main/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScript/help-classpath.html
src/main/resources/org/jenkinsci/plugins/scriptsecurity/scripts/ClasspathEntry/config.jelly
src/main/resources/org/jenkinsci/plugins/scriptsecurity/scripts/ClasspathEntry/help-path.html
src/main/resources/org/jenkinsci/plugins/scriptsecurity/scripts/Messages.properties
src/main/resources/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/index.jelly
src/test/java/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScriptTest.java
src/test/java/org/jenkinsci/plugins/scriptsecurity/scripts/ClasspathEntryTest.java
src/test/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApprovalTest.java
src/test/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScriptTest/README.md
src/test/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScriptTest/script-security-plugin-testjar.jar
src/test/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScriptTest/updated/script-security-plugin-testjar.jar
http://jenkins-ci.org/commit/script-security-plugin/5bc00e8bc41ed0980315fe25e97d81c0e038fa27
Log:
Merge pull request #2 from jenkinsci/classpath

[FIXED JENKINS-22834] Support custom classpaths.

Compare: https://github.com/jenkinsci/script-security-plugin/compare/ccd8c9282618...5bc00e8bc41e

SCM/JIRA link daemon added a comment - 2014-08-19 22:15 Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScript.java src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ApprovalListener.java src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ClasspathEntry.java src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApprovalLink.java src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/UnapprovedClasspathException.java src/main/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScript/config.jelly src/main/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScript/help-classpath.html src/main/resources/org/jenkinsci/plugins/scriptsecurity/scripts/ClasspathEntry/config.jelly src/main/resources/org/jenkinsci/plugins/scriptsecurity/scripts/ClasspathEntry/help-path.html src/main/resources/org/jenkinsci/plugins/scriptsecurity/scripts/Messages.properties src/main/resources/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval/index.jelly src/test/java/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScriptTest.java src/test/java/org/jenkinsci/plugins/scriptsecurity/scripts/ClasspathEntryTest.java src/test/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApprovalTest.java src/test/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScriptTest/README.md src/test/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScriptTest/script-security-plugin-testjar.jar src/test/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/groovy/SecureGroovyScriptTest/updated/script-security-plugin-testjar.jar http://jenkins-ci.org/commit/script-security-plugin/5bc00e8bc41ed0980315fe25e97d81c0e038fa27 Log: Merge pull request #2 from jenkinsci/classpath [FIXED JENKINS-22834] Support custom classpaths. Compare: https://github.com/jenkinsci/script-security-plugin/compare/ccd8c9282618...5bc00e8bc41e

Jenkins

Administrator-approved classpath additions

Details

Description

Attachments

Issue Links

Activity

People

Dates