A report from Coverity:
*** CID 1222626: Dereference null return value (NULL_RETURNS) /src/main/java/hudson/model/ListView.java: 334 in hudson.model.ListView.doRemoveJobFromView(java.lang.String)() 328 @RequirePOST 329 public HttpResponse doRemoveJobFromView(@QueryParameter String name) throws IOException, ServletException { 330 checkPermission(View.CONFIGURE); 331 if(name==null) 332 throw new Failure("Query parameter 'name' is required"); 333 >>> CID 1222626: Dereference null return value (NULL_RETURNS) >>> Assigning: "item" = null return value from "resolveName". 334 TopLevelItem item = resolveName(name); 335 if (remove(item)) 336 owner.save(); 337 338 return HttpResponses.ok(); 339 }
[JENKINS-23411] Parallel deletion of jobs from the ListView may lead to NPE errors
Workflow | Original: JNJira [ 156035 ] | New: JNJira + In-Review [ 179188 ] |
Labels | New: newbie-friendly |
Assignee | Original: Oleg Nenashev [ oleg_nenashev ] |
Assignee | New: Li Ke [ liketic ] |
Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
Code changed in jenkins
User: kel
Path:
core/src/main/java/hudson/model/ListView.java
test/src/test/java/hudson/model/ListViewTest.java
http://jenkins-ci.org/commit/jenkins/fddffb4fbceb50e0c8801044319e84dc6f9b7e90
Log:
[Fix JENKINS-23411] Throws Failure if the item does not exist (#3007)