Details
-
Bug
-
Status: Resolved (View Workflow)
-
Major
-
Resolution: Fixed
Description
A report from Coverity:
*** CID 1222626: Dereference null return value (NULL_RETURNS) /src/main/java/hudson/model/ListView.java: 334 in hudson.model.ListView.doRemoveJobFromView(java.lang.String)() 328 @RequirePOST 329 public HttpResponse doRemoveJobFromView(@QueryParameter String name) throws IOException, ServletException { 330 checkPermission(View.CONFIGURE); 331 if(name==null) 332 throw new Failure("Query parameter 'name' is required"); 333 >>> CID 1222626: Dereference null return value (NULL_RETURNS) >>> Assigning: "item" = null return value from "resolveName". 334 TopLevelItem item = resolveName(name); 335 if (remove(item)) 336 owner.save(); 337 338 return HttpResponses.ok(); 339 }
Attachments
Activity
Field | Original Value | New Value |
---|---|---|
URL | https://scan5.coverity.com:8443/reports.htm#v33873/p10292/fileInstanceId=58237456&defectInstanceId=17964666&mergedDefectId=1222626 |
Workflow | JNJira [ 156035 ] | JNJira + In-Review [ 179188 ] |
Labels | newbie-friendly |
Assignee | Oleg Nenashev [ oleg_nenashev ] |
Assignee | Li Ke [ liketic ] |
Status | Open [ 1 ] | In Progress [ 3 ] |
Resolution | Fixed [ 1 ] | |
Status | In Progress [ 3 ] | Resolved [ 5 ] |
Code changed in jenkins
User: kel
Path:
core/src/main/java/hudson/model/ListView.java
test/src/test/java/hudson/model/ListViewTest.java
http://jenkins-ci.org/commit/jenkins/fddffb4fbceb50e0c8801044319e84dc6f9b7e90
Log:
[Fix JENKINS-23411] Throws Failure if the item does not exist (#3007)