Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23417

AccessRestriction on SecurityListener methods

    XMLWordPrintable

    Details

    • Similar Issues:
    • URL:

      Description

      SecurityListener.fire* methods have @Restricted(NoExternalUse.class) annotation making external security implementations like github-oauth-plugin unable to fire those events.

      I've made a pr here

      https://github.com/jenkinsci/jenkins/pull/1277

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          surya548 surya gaddipati created issue -
          jglick Jesse Glick made changes -
          Field Original Value New Value
          Labels jenkins api lts-candidate security
          jglick Jesse Glick made changes -
          Component/s core [ 15593 ]
          Component/s security [ 15508 ]
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/jenkins/security/SecurityListener.java
          http://jenkins-ci.org/commit/jenkins/6dd071eaa8dd20ac6734d1b54e05d0a4adb7599f
          Log:
          [FIXED JENKINS-23417] Noting merge of #1277.

          Compare: https://github.com/jenkinsci/jenkins/compare/2b89f9d09e34...6dd071eaa8dd

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/jenkins/security/SecurityListener.java http://jenkins-ci.org/commit/jenkins/6dd071eaa8dd20ac6734d1b54e05d0a4adb7599f Log: [FIXED JENKINS-23417] Noting merge of #1277. Compare: https://github.com/jenkinsci/jenkins/compare/2b89f9d09e34...6dd071eaa8dd
          scm_issue_link SCM/JIRA link daemon made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          Hide
          Permalink
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #3464
          [FIXED JENKINS-23417] Noting merge of #1277. (Revision 6dd071eaa8dd20ac6734d1b54e05d0a4adb7599f)

          Result = SUCCESS
          Jesse Glick : 6dd071eaa8dd20ac6734d1b54e05d0a4adb7599f
          Files :

          • core/src/main/java/jenkins/security/SecurityListener.java
          • changelog.html
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3464 [FIXED JENKINS-23417] Noting merge of #1277. (Revision 6dd071eaa8dd20ac6734d1b54e05d0a4adb7599f) Result = SUCCESS Jesse Glick : 6dd071eaa8dd20ac6734d1b54e05d0a4adb7599f Files : core/src/main/java/jenkins/security/SecurityListener.java changelog.html
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/jenkins/security/SecurityListener.java
          http://jenkins-ci.org/commit/jenkins/7e1d848bfa4068dc58dfd58c6b387c54e1b871ae
          Log:
          [FIXED JENKINS-23417] Noting merge of #1277.

          (cherry picked from commit 6dd071eaa8dd20ac6734d1b54e05d0a4adb7599f)

          Conflicts:
          changelog.html

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/security/SecurityListener.java http://jenkins-ci.org/commit/jenkins/7e1d848bfa4068dc58dfd58c6b387c54e1b871ae Log: [FIXED JENKINS-23417] Noting merge of #1277. (cherry picked from commit 6dd071eaa8dd20ac6734d1b54e05d0a4adb7599f) Conflicts: changelog.html
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          core/src/main/java/jenkins/security/SecurityListener.java
          http://jenkins-ci.org/commit/jenkins/d2a9f10e56e1b9ea35f664a3aa6dbc82e18e54e5
          Log:
          JENKINS-23417 Noting new api members is stable branch

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/jenkins/security/SecurityListener.java http://jenkins-ci.org/commit/jenkins/d2a9f10e56e1b9ea35f664a3aa6dbc82e18e54e5 Log: JENKINS-23417 Noting new api members is stable branch
          olivergondza Oliver Gondža made changes -
          Labels api lts-candidate security 1.565.1-fixed api security
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 156041 ] JNJira + In-Review [ 195323 ]

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            surya548 surya gaddipati
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: