[JENKINS-23462] Sectioned views are not evaluated for job priority - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Component/s: prioritysorter-plugin
Labels:
None
Environment:
* Jenkins and plugins latest
* thousands of generated jobs by job-dsl plugin
* Nested view with lots of sectioned views

Similar Issues:

Show

Description

If a job is inside a sectioned view (section view plugin) the view-base priority evaluation seems to be broken. Excerpt from log:

Evaluating JobGroup [21] ...
[...]
    Evaluating View [Continuous] ...
[...}
    Evaluating View [~NEVER-OPEN-THIS] ...
      Using filter ...
        Job is matching the filter ...
      No applicable strategy - Using JobGroup default 

Jun 17, 2014 9:26:28 AM FINE PrioritySorter.Queue.Items

Buildable: Id: 6076, JobName: DirectoryService_Tests, jobGroupId: 21, reason: <none>, priority: 5, weight: 5.0, status: BUILDABLE

The same Job "DirectoryService_Tests" is in the sectioned [Continuous] view but it is only evaluated in the view NEVER-OPEN-THIS which is a flat ALL jobs view.

Attachments

Activity

Ascending order - Click to sort in descending order

Dirk Kuypers created issue - 2014-06-17 07:43

Magnus Sandberg made changes - 2014-06-17 08:10

Field	Original Value	New Value
Assignee	bklarson [ bklarson ]	Magnus Sandberg [ emsa23 ]

Kurt made changes - 2014-06-17 08:12

Assignee	Magnus Sandberg [ emsa23 ]	bklarson [ bklarson ]
Description	If a job is inside a sectioned view the view-base priority evaluation seems to be broken. Excerpt from log: Evaluating JobGroup [21] ... [...] Evaluating View [Continuous] ... [...} Evaluating View [~NEVER-OPEN-THIS] ... Using filter ... Job is matching the filter ... No applicable strategy - Using JobGroup default Jun 17, 2014 9:26:28 AM FINE PrioritySorter.Queue.Items Buildable: Id: 6076, JobName: DirectoryService_Tests, jobGroupId: 21, reason: <none>, priority: 5, weight: 5.0, status: BUILDABLE The Job is in the sectioned [Continuous] view but it is only evaluated in the list view [~NEVER-OPEN-THIS] which is a list view generated by regular expression containing all test jobs.	If a job is inside a sectioned view (section view plugin) the view-base priority evaluation seems to be broken. Excerpt from log: {noformat} Evaluating JobGroup [21] ... [...] Evaluating View [Continuous] ... [...} Evaluating View [~NEVER-OPEN-THIS] ... Using filter ... Job is matching the filter ... No applicable strategy - Using JobGroup default Jun 17, 2014 9:26:28 AM FINE PrioritySorter.Queue.Items Buildable: Id: 6076, JobName: DirectoryService_Tests, jobGroupId: 21, reason: <none>, priority: 5, weight: 5.0, status: BUILDABLE {noformat} The same Job "DirectoryService_Tests" is in the sectioned [Continuous] view but it is only evaluated in the view [~NEVER-OPEN-THIS] which is a flat ALL jobs view.

Magnus Sandberg added a comment - 2014-06-17 08:13

Is this done by using Nested View Plugin or some other plugin?

Magnus Sandberg added a comment - 2014-06-17 08:13 Is this done by using Nested View Plugin or some other plugin?

Magnus Sandberg made changes - 2014-06-17 08:14

Assignee

bklarson [ bklarson ]

Magnus Sandberg [ emsa23 ]

Kurt added a comment - 2014-06-17 08:16 - edited

I've just updated the description. Sorry, due to a mid-air-collision I fear I had messed up the Assignee.

It's a view using the "Section View Plugin: https://wiki.jenkins-ci.org/display/JENKINS/Sectioned+View+Plugin

To be even more precise: All sections of that view are of type "List View Section".

Kurt added a comment - 2014-06-17 08:16 - edited I've just updated the description. Sorry, due to a mid-air-collision I fear I had messed up the Assignee. It's a view using the "Section View Plugin: https://wiki.jenkins-ci.org/display/JENKINS/Sectioned+View+Plugin To be even more precise: All sections of that view are of type "List View Section".

Magnus Sandberg added a comment - 2014-06-17 08:26

No worries.

Your not using any other plugin like the Nested View plugin or Cloudbees Folders in the Sectioned View?

Magnus Sandberg added a comment - 2014-06-17 08:26 No worries. Your not using any other plugin like the Nested View plugin or Cloudbees Folders in the Sectioned View?

Kurt added a comment - 2014-06-17 08:34

Nested view plugin is installed but not actually used as we've not (yet) set up any nested views. Reason was that we wanted to use it but as far as I remember there were some troubles using that nested view structure with the Role-based Authorization Strategy plugin and project roles (not sure if that is already solved - but at least we didn't find time to test it again).
So if useful we could try to completely uninstall the "Nested View" plugin.

The CloudBees Folders plugin is not even installed.

Kurt added a comment - 2014-06-17 08:34 Nested view plugin is installed but not actually used as we've not (yet) set up any nested views. Reason was that we wanted to use it but as far as I remember there were some troubles using that nested view structure with the Role-based Authorization Strategy plugin and project roles (not sure if that is already solved - but at least we didn't find time to test it again). So if useful we could try to completely uninstall the "Nested View" plugin. The CloudBees Folders plugin is not even installed.

Magnus Sandberg added a comment - 2014-06-17 08:37

Thanks. Let's see what I can do ...

Magnus Sandberg added a comment - 2014-06-17 08:37 Thanks. Let's see what I can do ...

Magnus Sandberg added a comment - 2014-06-17 10:49

How is the job "DirectoryService_Tests" included in the Section? By name or by pattern (regex)?

Magnus Sandberg added a comment - 2014-06-17 10:49 How is the job "DirectoryService_Tests" included in the Section? By name or by pattern (regex)?

Dirk Kuypers added a comment - 2014-06-17 10:53

By Pattern.

Dirk Kuypers added a comment - 2014-06-17 10:53 By Pattern.

Magnus Sandberg added a comment - 2014-06-17 11:16

OK - then I have a fix in the pipe ...

Magnus Sandberg added a comment - 2014-06-17 11:16 OK - then I have a fix in the pipe ...

SCM/JIRA link daemon added a comment - 2014-06-17 11:57

Code changed in jenkins
User: emsa23
Path:
src/main/java/jenkins/advancedqueue/PriorityConfiguration.java
http://jenkins-ci.org/commit/priority-sorter-plugin/30567281338443e5f73d7790bbb6aefc4d0594b1
Log:
~~JENKINS-23462~~ Sectioned views are not evaluated for job priority

Handling differences in implementations of contains() in
various View/ViewGroups

SCM/JIRA link daemon added a comment - 2014-06-17 11:57 Code changed in jenkins User: emsa23 Path: src/main/java/jenkins/advancedqueue/PriorityConfiguration.java http://jenkins-ci.org/commit/priority-sorter-plugin/30567281338443e5f73d7790bbb6aefc4d0594b1 Log: JENKINS-23462 Sectioned views are not evaluated for job priority Handling differences in implementations of contains() in various View/ViewGroups

SCM/JIRA link daemon added a comment - 2014-06-17 18:50

Code changed in jenkins
User: emsa23
Path:
pom.xml
src/main/java/jenkins/advancedqueue/PriorityConfiguration.java
src/test/java/jenkins/advancedqueue/test/SectionedViewTest.java
src/test/resources/jenkins/advancedqueue/test/SectionedViewTest/config.xml
src/test/resources/jenkins/advancedqueue/test/SectionedViewTest/jenkins.advancedqueue.PriorityConfiguration.xml
src/test/resources/jenkins/advancedqueue/test/SectionedViewTest/jenkins.advancedqueue.PrioritySorterConfiguration.xml
http://jenkins-ci.org/commit/priority-sorter-plugin/4ec547ee116f5e6f7a78d08e9af606c5813f74ec
Log:
~~JENKINS-23462~~ Sectioned views are not evaluated for job priority

Need to use getItems() not getItem() to get the items in the View
Added test-case for Sectioned View Plugin

SCM/JIRA link daemon added a comment - 2014-06-17 18:50 Code changed in jenkins User: emsa23 Path: pom.xml src/main/java/jenkins/advancedqueue/PriorityConfiguration.java src/test/java/jenkins/advancedqueue/test/SectionedViewTest.java src/test/resources/jenkins/advancedqueue/test/SectionedViewTest/config.xml src/test/resources/jenkins/advancedqueue/test/SectionedViewTest/jenkins.advancedqueue.PriorityConfiguration.xml src/test/resources/jenkins/advancedqueue/test/SectionedViewTest/jenkins.advancedqueue.PrioritySorterConfiguration.xml http://jenkins-ci.org/commit/priority-sorter-plugin/4ec547ee116f5e6f7a78d08e9af606c5813f74ec Log: JENKINS-23462 Sectioned views are not evaluated for job priority Need to use getItems() not getItem() to get the items in the View Added test-case for Sectioned View Plugin

SCM/JIRA link daemon added a comment - 2014-06-17 18:57

Code changed in jenkins
User: emsa23
Path:
src/test/resources/jenkins/advancedqueue/test/SectionedViewTest/config.xml
http://jenkins-ci.org/commit/priority-sorter-plugin/47b129c07106bacc38b3c1a509461ce976b66b29
Log:
~~JENKINS-23462~~ Sectioned views are not evaluated for job priority

Updated test-case to include job by regex since this was the
the cause of the problem.

SCM/JIRA link daemon added a comment - 2014-06-17 18:57 Code changed in jenkins User: emsa23 Path: src/test/resources/jenkins/advancedqueue/test/SectionedViewTest/config.xml http://jenkins-ci.org/commit/priority-sorter-plugin/47b129c07106bacc38b3c1a509461ce976b66b29 Log: JENKINS-23462 Sectioned views are not evaluated for job priority Updated test-case to include job by regex since this was the the cause of the problem.

Magnus Sandberg added a comment - 2014-06-17 19:14

Fixed in 2.8

Magnus Sandberg added a comment - 2014-06-17 19:14 Fixed in 2.8

Magnus Sandberg made changes - 2014-06-17 19:14

Fix Version/s		current [ 10162 ]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Dirk Kuypers added a comment - 2014-06-18 14:26

Thanks for you fast fix Magnus. I have a good and a bad message about it though

The good one: It seems to work, the jobs are found in the views and priorities are assigned as configured.
The bad one: It seems to be a real performance hog at least with our quite large installation.:-/ Jenkins UI was unusable after some time, after downgrading everything is back to normal.

Some facts: We have about 10000 Jobs, more than 20 views refering most of the jobs via regex pattern. So I could imagine that there are long lists of jobs being iterated while computing priorities.

Would it be a better approach for us to configure job priority directly on the job? That would be not a big deal because most of them are generated from template?

Should I open a new JIRA ticket? Or reopen this one?

Dirk Kuypers added a comment - 2014-06-18 14:26 Thanks for you fast fix Magnus. I have a good and a bad message about it though The good one: It seems to work, the jobs are found in the views and priorities are assigned as configured. The bad one: It seems to be a real performance hog at least with our quite large installation.:-/ Jenkins UI was unusable after some time, after downgrading everything is back to normal. Some facts: We have about 10000 Jobs, more than 20 views refering most of the jobs via regex pattern. So I could imagine that there are long lists of jobs being iterated while computing priorities. Would it be a better approach for us to configure job priority directly on the job? That would be not a big deal because most of them are generated from template? Should I open a new JIRA ticket? Or reopen this one?

R. Tyler Croy made changes - 2016-07-25 23:56

Workflow

JNJira [ 156090 ]

JNJira + In-Review [ 195341 ]

Mark Waite made changes - 2021-11-27 16:21

Status

Resolved [ 5 ]

Closed [ 6 ]

People

Assignee:: Magnus Sandberg

Reporter:: Dirk Kuypers

Votes:: 1 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 2014-06-17 07:43

Updated:: 2021-11-27 16:21

Resolved:: 2014-06-17 19:14