Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23630

Update to new environment variable APIs

    XMLWordPrintable

Details

    Description

      PasswordParameterValue needs to be updated. buildEnvVars with Map is deprecated; should use the EnvVars overload. Should not upcase the variable name (or should also set the original name). Should override isSensitive. MaskPasswordsBuildWrapper should also override makeSensitiveBuildVariables.

      Attachments

        Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-23447 Sensitive build variables recorded in EnvInjectSavable and displayed in EnvInjectAction

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-25821 Global Mask Password are visible as a plain text in Environment Variables tab

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link PR 4

          Activity

            Ascending order - Click to sort in descending order
            jglick Jesse Glick created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Link This issue depends on JENKINS-23447 [ JENKINS-23447 ]
            jglick Jesse Glick added a comment -

            Until JENKINS-23447 is fixed, marking variables as sensitive is pointless when EnvInject is also installed.

            jglick Jesse Glick added a comment - Until JENKINS-23447 is fixed, marking variables as sensitive is pointless when EnvInject is also installed.
            oleg_nenashev Oleg Nenashev added a comment -

            Taking the issue

            oleg_nenashev Oleg Nenashev added a comment - Taking the issue
            oleg_nenashev Oleg Nenashev made changes -
            Assignee Daniel Petisme [ danielpetisme ] Oleg Nenashev [ oleg_nenashev ]
            oleg_nenashev Oleg Nenashev made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsBuildWrapper.java
            src/main/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterValue.java
            http://jenkins-ci.org/commit/mask-passwords-plugin/e12c6cb9f157419bc529c15daad9f49668aea6ab
            Log:
            JENKINS-23630 - Honor the sensitive variables engine in Mask Psswords

            This change implements API for sensitive variables, which is required to hide passwords in plugins like EnvInject.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsBuildWrapper.java src/main/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterValue.java http://jenkins-ci.org/commit/mask-passwords-plugin/e12c6cb9f157419bc529c15daad9f49668aea6ab Log: JENKINS-23630 - Honor the sensitive variables engine in Mask Psswords This change implements API for sensitive variables, which is required to hide passwords in plugins like EnvInject.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsBuildWrapper.java
            src/main/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterValue.java
            http://jenkins-ci.org/commit/mask-passwords-plugin/a591ed97cfd9465bec7d9daa13f26c5644825307
            Log:
            JENKINS-23630 - Honor the sensitive variables engine in Mask Psswords

            This change implements API for sensitive variables, which is required to hide passwords in plugins like EnvInject.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsBuildWrapper.java src/main/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterValue.java http://jenkins-ci.org/commit/mask-passwords-plugin/a591ed97cfd9465bec7d9daa13f26c5644825307 Log: JENKINS-23630 - Honor the sensitive variables engine in Mask Psswords This change implements API for sensitive variables, which is required to hide passwords in plugins like EnvInject.
            jglick Jesse Glick made changes -
            Remote Link This issue links to "PR 4 (Web Link)" [ 13007 ]
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue is related to JENKINS-25821 [ JENKINS-25821 ]
            oleg_nenashev Oleg Nenashev added a comment -

            JENKINS-25821 will be closed in my PR instead

            oleg_nenashev Oleg Nenashev added a comment - JENKINS-25821 will be closed in my PR instead
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsBuildWrapper.java
            src/main/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterValue.java
            http://jenkins-ci.org/commit/mask-passwords-plugin/48bedb99ae0db1cc2f18df438bc9cb86ea7ea695
            Log:
            Merge pull request #4 from jenkinsci/JENKINS-23630-sensitive-vars

            [FIXED JENKINS-25821] - Honor the sensitive variables engine in Mask Passwords

            Compare: https://github.com/jenkinsci/mask-passwords-plugin/compare/08ca0e0efcf5...48bedb99ae0d

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsBuildWrapper.java src/main/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterValue.java http://jenkins-ci.org/commit/mask-passwords-plugin/48bedb99ae0db1cc2f18df438bc9cb86ea7ea695 Log: Merge pull request #4 from jenkinsci/ JENKINS-23630 -sensitive-vars [FIXED JENKINS-25821] - Honor the sensitive variables engine in Mask Passwords Compare: https://github.com/jenkinsci/mask-passwords-plugin/compare/08ca0e0efcf5...48bedb99ae0d
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 156413 ] JNJira + In-Review [ 185518 ]
            oleg_nenashev Oleg Nenashev added a comment -

            It has been fixed in 2.7.4 long-long ago

            oleg_nenashev Oleg Nenashev added a comment - It has been fixed in 2.7.4 long-long ago
            oleg_nenashev Oleg Nenashev made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]

            People

              oleg_nenashev Oleg Nenashev
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: