Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23630

Update to new environment variable APIs

XMLWordPrintable

      PasswordParameterValue needs to be updated. buildEnvVars with Map is deprecated; should use the EnvVars overload. Should not upcase the variable name (or should also set the original name). Should override isSensitive. MaskPasswordsBuildWrapper should also override makeSensitiveBuildVariables.

          [JENKINS-23630] Update to new environment variable APIs

          Jesse Glick added a comment -

          Until JENKINS-23447 is fixed, marking variables as sensitive is pointless when EnvInject is also installed.

          Jesse Glick added a comment - Until JENKINS-23447 is fixed, marking variables as sensitive is pointless when EnvInject is also installed.

          Oleg Nenashev added a comment -

          Taking the issue

          Oleg Nenashev added a comment - Taking the issue

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsBuildWrapper.java
          src/main/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterValue.java
          http://jenkins-ci.org/commit/mask-passwords-plugin/e12c6cb9f157419bc529c15daad9f49668aea6ab
          Log:
          JENKINS-23630 - Honor the sensitive variables engine in Mask Psswords

          This change implements API for sensitive variables, which is required to hide passwords in plugins like EnvInject.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsBuildWrapper.java src/main/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterValue.java http://jenkins-ci.org/commit/mask-passwords-plugin/e12c6cb9f157419bc529c15daad9f49668aea6ab Log: JENKINS-23630 - Honor the sensitive variables engine in Mask Psswords This change implements API for sensitive variables, which is required to hide passwords in plugins like EnvInject.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsBuildWrapper.java
          src/main/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterValue.java
          http://jenkins-ci.org/commit/mask-passwords-plugin/a591ed97cfd9465bec7d9daa13f26c5644825307
          Log:
          JENKINS-23630 - Honor the sensitive variables engine in Mask Psswords

          This change implements API for sensitive variables, which is required to hide passwords in plugins like EnvInject.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsBuildWrapper.java src/main/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterValue.java http://jenkins-ci.org/commit/mask-passwords-plugin/a591ed97cfd9465bec7d9daa13f26c5644825307 Log: JENKINS-23630 - Honor the sensitive variables engine in Mask Psswords This change implements API for sensitive variables, which is required to hide passwords in plugins like EnvInject.

          Oleg Nenashev added a comment -

          JENKINS-25821 will be closed in my PR instead

          Oleg Nenashev added a comment - JENKINS-25821 will be closed in my PR instead

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsBuildWrapper.java
          src/main/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterValue.java
          http://jenkins-ci.org/commit/mask-passwords-plugin/48bedb99ae0db1cc2f18df438bc9cb86ea7ea695
          Log:
          Merge pull request #4 from jenkinsci/JENKINS-23630-sensitive-vars

          [FIXED JENKINS-25821] - Honor the sensitive variables engine in Mask Passwords

          Compare: https://github.com/jenkinsci/mask-passwords-plugin/compare/08ca0e0efcf5...48bedb99ae0d

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/michelin/cio/hudson/plugins/maskpasswords/MaskPasswordsBuildWrapper.java src/main/java/com/michelin/cio/hudson/plugins/passwordparam/PasswordParameterValue.java http://jenkins-ci.org/commit/mask-passwords-plugin/48bedb99ae0db1cc2f18df438bc9cb86ea7ea695 Log: Merge pull request #4 from jenkinsci/ JENKINS-23630 -sensitive-vars [FIXED JENKINS-25821] - Honor the sensitive variables engine in Mask Passwords Compare: https://github.com/jenkinsci/mask-passwords-plugin/compare/08ca0e0efcf5...48bedb99ae0d

          Oleg Nenashev added a comment -

          It has been fixed in 2.7.4 long-long ago

          Oleg Nenashev added a comment - It has been fixed in 2.7.4 long-long ago

            oleg_nenashev Oleg Nenashev
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: