Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23791

Wrong timestamp retrieved from git ChangeSet

    XMLWordPrintable

Details

    Description

      Using the following groovy code:

      def thr = Thread.currentThread();
def currentBuild = thr?.executable;
def changes = currentBuild.getChangeSet();
changes.getItems().each {
	ChangeLogSet.Entry lastChange = (ChangeLogSet.Entry)it;
    lastChange.getTimestamp();
}

      Produces a wrong timestamp (0).
      Reverting to git plugin 2.0.1 fixes the issue.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-21906 NumberFormatException occurs when accessing the JSON api

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            mooshben Moosh Ben created issue -
            mooshben Moosh Ben made changes -
            Field Original Value New Value
            Summary Wrong timestamp retrieved from ChangeSet Wrong timestamp retrieved from git ChangeSet
            mooshben Moosh Ben made changes -
            Link This issue is related to JENKINS-21906 [ JENKINS-21906 ]
            addictvim Dmitry Skorbovenko added a comment -

            Hi, I have checked code. the issue is in GitChangeSet:isoDateFormat method. git tool returns the time in seconds but java Date class requires milliseconds - so just multiply time by 1000
            fix:

                /** Convert to iso date format if required */
    private String isoDateFormat(String s) {
        if (s.length() == 25 /* already in ISO 8601 */) return s;

        // legacy mode
        int i = s.indexOf(' ');
        long time = Long.parseLong(s.substring(0,i));
        return FastDateFormat.getInstance(ISO_8601).format(new Date(time * 1000)) + s.substring(i);
    }
            addictvim Dmitry Skorbovenko added a comment - Hi, I have checked code. the issue is in GitChangeSet:isoDateFormat method. git tool returns the time in seconds but java Date class requires milliseconds - so just multiply time by 1000 fix: /** Convert to iso date format if required */ private String isoDateFormat( String s) { if (s.length() == 25 /* already in ISO 8601 */ ) return s; // legacy mode int i = s.indexOf( ' ' ); long time = Long .parseLong(s.substring(0,i)); return FastDateFormat.getInstance(ISO_8601).format( new Date(time * 1000)) + s.substring(i); }
            addictvim Dmitry Skorbovenko added a comment -

            I have just sent pull request https://github.com/jenkinsci/git-plugin/pull/242

            addictvim Dmitry Skorbovenko added a comment - I have just sent pull request https://github.com/jenkinsci/git-plugin/pull/242
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Dmitry Skorbovenko
            Path:
            src/main/java/hudson/plugins/git/GitChangeSet.java
            http://jenkins-ci.org/commit/git-plugin/1f9f31d91129a7cb168dadda266154ea3f4f31ef
            Log:
            [FIXED JENKINS-23791] convert seconds to milliseconds for timestamp

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dmitry Skorbovenko Path: src/main/java/hudson/plugins/git/GitChangeSet.java http://jenkins-ci.org/commit/git-plugin/1f9f31d91129a7cb168dadda266154ea3f4f31ef Log: [FIXED JENKINS-23791] convert seconds to milliseconds for timestamp
            scm_issue_link SCM/JIRA link daemon made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Dmitry Skorbovenko
            Path:
            src/main/java/hudson/plugins/git/GitChangeSet.java
            http://jenkins-ci.org/commit/git-plugin/1c37dd40df54c02a547843a3be0a06e280dc3552
            Log:
            [FIXED JENKINS-23791] convert seconds to milliseconds for timestamp

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dmitry Skorbovenko Path: src/main/java/hudson/plugins/git/GitChangeSet.java http://jenkins-ci.org/commit/git-plugin/1c37dd40df54c02a547843a3be0a06e280dc3552 Log: [FIXED JENKINS-23791] convert seconds to milliseconds for timestamp
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Mark Waite
            Path:
            src/main/java/hudson/plugins/git/GitChangeSet.java
            http://jenkins-ci.org/commit/git-plugin/617d600a9571931d77ee2352ffe1f37bb77ba603
            Log:
            Merge pull request #242 from AddictVim/jenkins_23791

            [FIXED JENKINS-23791] convert seconds to milliseconds for timestamp

            Compare: https://github.com/jenkinsci/git-plugin/compare/5721ddbd1f76...617d600a9571

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mark Waite Path: src/main/java/hudson/plugins/git/GitChangeSet.java http://jenkins-ci.org/commit/git-plugin/617d600a9571931d77ee2352ffe1f37bb77ba603 Log: Merge pull request #242 from AddictVim/jenkins_23791 [FIXED JENKINS-23791] convert seconds to milliseconds for timestamp Compare: https://github.com/jenkinsci/git-plugin/compare/5721ddbd1f76...617d600a9571
            markewaite Mark Waite added a comment -

            Fixed in git plugin 2.2.4

            markewaite Mark Waite added a comment - Fixed in git plugin 2.2.4
            markewaite Mark Waite made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 156581 ] JNJira + In-Review [ 207853 ]

            People

              ndeloof Nicolas De Loof
              mooshben Moosh Ben
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: