Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24080

set-build-result and set-build-parameter do insufficient checks

      Formally filing some issues which were previously noted parenthetically in JENKINS-22472:

      SetBuildResultCommand checks Item.BUILD; I would have expected Run.UPDATE. And SetBuildParameterCommand does no check at all.

      getCurrentlyBuilding does not even check Run.isBuilding, so this could even be used to mangle a completed build's state, such as parameters via SetBuildParameterCommand. (SetBuildResultCommand would not work on a finished build because of checks inside Run.setResult.)

          [JENKINS-24080] set-build-result and set-build-parameter do insufficient checks

          Jesse Glick created issue -
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-22472 [ JENKINS-22472 ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Jesse Glick made changes -
          Assignee New: Jesse Glick [ jglick ]
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
          Oliver Gondža made changes -
          Labels Original: cli lts-candidate security New: 1.565.3-fixed cli security
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 156953 ] New: JNJira + In-Review [ 195557 ]

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: