Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24340

AbstractProject: makeDisabled() performs operations even if supportsMakeDisabled() is false

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core

      This bug is a follow-up to the discussion is https://github.com/jenkinsci/matrix-project-plugin/pull/5

      In my case it causes JENKINS-19179 for Matrix projects when jobs use Subversion SCM (JENKINS-24341)

          [JENKINS-24340] AbstractProject: makeDisabled() performs operations even if supportsMakeDisabled() is false

          Oleg Nenashev created issue -
          Oleg Nenashev made changes -
          Description Original: This bug is a follow-up to the discussion is https://github.com/jenkinsci/matrix-project-plugin/pull/5

          In my case it causes JENKINS-19179 for Matrix projects when jobs use Subversion SCM ()
          New: This bug is a follow-up to the discussion is https://github.com/jenkinsci/matrix-project-plugin/pull/5

          In my case it causes JENKINS-19179 for Matrix projects when jobs use Subversion SCM (JENKINS-24341)
          Oleg Nenashev made changes -
          Link New: This issue is related to JENKINS-24341 [ JENKINS-24341 ]
          Oleg Nenashev made changes -
          Link New: This issue is related to JENKINS-19179 [ JENKINS-19179 ]
          Oleg Nenashev made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Oleg Nenashev added a comment -

          Oleg Nenashev added a comment - https://github.com/jenkinsci/jenkins/pull/1374

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/model/AbstractProject.java
          http://jenkins-ci.org/commit/jenkins/a78f1d3246cfdbee96820d5629dbb8676a3ca19a
          Log:
          [FIXED JENKINS-24340] - Do not disable jobs if supportsMakeDisabled() returns false

          This changes prevents the improper usage of method without the preliminary supportsMakeDisabled() check.
          As an example, Subversion plugin behaves in such way (JENKINS-24341)

          Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/AbstractProject.java http://jenkins-ci.org/commit/jenkins/a78f1d3246cfdbee96820d5629dbb8676a3ca19a Log: [FIXED JENKINS-24340] - Do not disable jobs if supportsMakeDisabled() returns false This changes prevents the improper usage of method without the preliminary supportsMakeDisabled() check. As an example, Subversion plugin behaves in such way ( JENKINS-24341 ) Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/model/AbstractProject.java
          http://jenkins-ci.org/commit/jenkins/a7cc2a1b3ad81c9c6279bd57732832800629cad1
          Log:
          Merge pull request #1374 from synopsys-arc-oss/JENKINS-24340

          [FIXED JENKINS-24340] - Do not disable jobs if supportsMakeDisabled() returns false

          Compare: https://github.com/jenkinsci/jenkins/compare/afdbe73669d3...a7cc2a1b3ad8

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/AbstractProject.java http://jenkins-ci.org/commit/jenkins/a7cc2a1b3ad81c9c6279bd57732832800629cad1 Log: Merge pull request #1374 from synopsys-arc-oss/ JENKINS-24340 [FIXED JENKINS-24340] - Do not disable jobs if supportsMakeDisabled() returns false Compare: https://github.com/jenkinsci/jenkins/compare/afdbe73669d3...a7cc2a1b3ad8
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3741
          [FIXED JENKINS-24340] - Do not disable jobs if supportsMakeDisabled() returns false (Revision a78f1d3246cfdbee96820d5629dbb8676a3ca19a)

          Result = SUCCESS
          o.v.nenashev : a78f1d3246cfdbee96820d5629dbb8676a3ca19a
          Files :

          • core/src/main/java/hudson/model/AbstractProject.java

          dogfood added a comment - Integrated in jenkins_main_trunk #3741 [FIXED JENKINS-24340] - Do not disable jobs if supportsMakeDisabled() returns false (Revision a78f1d3246cfdbee96820d5629dbb8676a3ca19a) Result = SUCCESS o.v.nenashev : a78f1d3246cfdbee96820d5629dbb8676a3ca19a Files : core/src/main/java/hudson/model/AbstractProject.java

            oleg_nenashev Oleg Nenashev
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: