Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24341

Subversion disables projects, which do not support the disabling

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • subversion-plugin
    • None

      Subversion Plugin disables projects when repositories are missing, etc.
      The plugin does not call AbstractProject::supportsMakeDisabled(). Due to JENKINS-24340, it leads to the disabling of Matrix Configurations (JENKINS-19179) and other such projects.

          [JENKINS-24341] Subversion disables projects, which do not support the disabling

          Oleg Nenashev created issue -
          Oleg Nenashev made changes -
          Priority Original: Major [ 3 ] New: Critical [ 2 ]
          Oleg Nenashev made changes -
          Link New: This issue is related to JENKINS-24340 [ JENKINS-24340 ]
          Oleg Nenashev made changes -
          Link New: This issue is related to JENKINS-19179 [ JENKINS-19179 ]
          Oleg Nenashev made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Oleg Nenashev added a comment -

          https://github.com/jenkinsci/subversion-plugin/pull/92

          Oleg Nenashev added a comment - https://github.com/jenkinsci/subversion-plugin/pull/92

          Oleg Nenashev added a comment -

          The issue can be easily reproduced on Subversion Plugin.
          It makes sense to make it lts-candidate

          Oleg Nenashev added a comment - The issue can be easily reproduced on Subversion Plugin. It makes sense to make it lts-candidate

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/model/AbstractProject.java
          http://jenkins-ci.org/commit/jenkins/a78f1d3246cfdbee96820d5629dbb8676a3ca19a
          Log:
          [FIXED JENKINS-24340] - Do not disable jobs if supportsMakeDisabled() returns false

          This changes prevents the improper usage of method without the preliminary supportsMakeDisabled() check.
          As an example, Subversion plugin behaves in such way (JENKINS-24341)

          Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/AbstractProject.java http://jenkins-ci.org/commit/jenkins/a78f1d3246cfdbee96820d5629dbb8676a3ca19a Log: [FIXED JENKINS-24340] - Do not disable jobs if supportsMakeDisabled() returns false This changes prevents the improper usage of method without the preliminary supportsMakeDisabled() check. As an example, Subversion plugin behaves in such way ( JENKINS-24341 ) Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/hudson/scm/SubversionSCM.java
          src/main/resources/hudson/scm/subversion/Messages.properties
          http://jenkins-ci.org/commit/subversion-plugin/9ea9dd80de5e01e713f9bfef6c0080f667a72d6d
          Log:
          [FIXED JENKINS-24341] - Check if the project can be disabled before the disabling

          The change call the AbstractProject::supportsMakeDisabled() before calling AbstractProject::makeDisabled()

          Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/scm/SubversionSCM.java src/main/resources/hudson/scm/subversion/Messages.properties http://jenkins-ci.org/commit/subversion-plugin/9ea9dd80de5e01e713f9bfef6c0080f667a72d6d Log: [FIXED JENKINS-24341] - Check if the project can be disabled before the disabling The change call the AbstractProject::supportsMakeDisabled() before calling AbstractProject::makeDisabled() Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

            oleg_nenashev Oleg Nenashev
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: