Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24491

Regression: parameters not retrieved when rebuilding a gitlab-merge-request-builder triggered job

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • rebuild-plugin
    • None

      After upgrading from 1.21 to 1.22, rebuilding jobs triggered via https://github.com/timols/jenkins-gitlab-merge-request-builder-plugin works (cause is copied over correctly), but no parameters is listed in the /rebuild/parameterized screen.

      After some bisecting, I figured out the regression was introduced in https://github.com/jenkinsci/rebuild-plugin/commit/d412c3d4224af25d35ea07c0f6cb68149afb9ffe.

          [JENKINS-24491] Regression: parameters not retrieved when rebuilding a gitlab-merge-request-builder triggered job

          Daniel Beck added a comment -

          Related discussion in JENKINS-24468.

          Daniel Beck added a comment - Related discussion in JENKINS-24468 .

          Code changed in jenkins
          User: escoheb
          Path:
          src/main/java/com/sonyericsson/rebuild/RebuildAction.java
          src/main/resources/com/sonyericsson/rebuild/RebuildAction/parameterized.jelly
          src/test/java/com/sonyericsson/rebuild/RebuildValidatorTest.java
          http://jenkins-ci.org/commit/rebuild-plugin/62206eae430085e60c6d617c009bb0d7bbb17aad
          Log:
          Fix regression of rebuild of non-parameter build

          This corrects the regression involved when builds are triggered
          with parameters that have not been defined in the job.

          Without this fix, the Rebuild Action does not display the build parameters
          that were previously used by the build that is being rebuilt.

          This fixes [FIXED JENKINS-24491]

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: escoheb Path: src/main/java/com/sonyericsson/rebuild/RebuildAction.java src/main/resources/com/sonyericsson/rebuild/RebuildAction/parameterized.jelly src/test/java/com/sonyericsson/rebuild/RebuildValidatorTest.java http://jenkins-ci.org/commit/rebuild-plugin/62206eae430085e60c6d617c009bb0d7bbb17aad Log: Fix regression of rebuild of non-parameter build This corrects the regression involved when builds are triggered with parameters that have not been defined in the job. Without this fix, the Rebuild Action does not display the build parameters that were previously used by the build that is being rebuilt. This fixes [FIXED JENKINS-24491]

            scoheb Scott Hebert
            bjaglin Brice Jaglin
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: