Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24491

Regression: parameters not retrieved when rebuilding a gitlab-merge-request-builder triggered job

    XMLWordPrintable

Details

    Description

      After upgrading from 1.21 to 1.22, rebuilding jobs triggered via https://github.com/timols/jenkins-gitlab-merge-request-builder-plugin works (cause is copied over correctly), but no parameters is listed in the /rebuild/parameterized screen.

      After some bisecting, I figured out the regression was introduced in https://github.com/jenkinsci/rebuild-plugin/commit/d412c3d4224af25d35ea07c0f6cb68149afb9ffe.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-25815 Rebuild plugin doesn't load all Parameters

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-24468 Rebuild should offer parameters not currently defined on the job

          • Major - Major loss of function.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            danielbeck Daniel Beck added a comment -

            Related discussion in JENKINS-24468.

            danielbeck Daniel Beck added a comment - Related discussion in JENKINS-24468 .
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: escoheb
            Path:
            src/main/java/com/sonyericsson/rebuild/RebuildAction.java
            src/main/resources/com/sonyericsson/rebuild/RebuildAction/parameterized.jelly
            src/test/java/com/sonyericsson/rebuild/RebuildValidatorTest.java
            http://jenkins-ci.org/commit/rebuild-plugin/62206eae430085e60c6d617c009bb0d7bbb17aad
            Log:
            Fix regression of rebuild of non-parameter build

            This corrects the regression involved when builds are triggered
            with parameters that have not been defined in the job.

            Without this fix, the Rebuild Action does not display the build parameters
            that were previously used by the build that is being rebuilt.

            This fixes [FIXED JENKINS-24491]

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: escoheb Path: src/main/java/com/sonyericsson/rebuild/RebuildAction.java src/main/resources/com/sonyericsson/rebuild/RebuildAction/parameterized.jelly src/test/java/com/sonyericsson/rebuild/RebuildValidatorTest.java http://jenkins-ci.org/commit/rebuild-plugin/62206eae430085e60c6d617c009bb0d7bbb17aad Log: Fix regression of rebuild of non-parameter build This corrects the regression involved when builds are triggered with parameters that have not been defined in the job. Without this fix, the Rebuild Action does not display the build parameters that were previously used by the build that is being rebuilt. This fixes [FIXED JENKINS-24491]

            People

              scoheb Scott Hebert
              bjaglin Brice Jaglin
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: