Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Minor
-
Resolution: Fixed
-
Component/s: swarm-plugin
-
Labels:None
-
Similar Issues:
Description
Using : as separator for tool location is not the best choice on Windows, as for example maven:c:\blahblah won't be parsed correctly.
Attachments
Activity
Code changed in jenkins
User: nico.mommaerts
Path:
plugin/src/main/java/hudson/plugins/swarm/PluginImpl.java
http://jenkins-ci.org/commit/swarm-plugin/4081439807a289bfe74bc6d8e4c99d8374c407e4
Log:
JENKINS-25002 Limit the split function on 2 so that paths with : can be used
Agreed, that would be the quickest fix without breaking existing stuff (as far as someone besides myself is already using it).
I'll fix it later today
Nico Mommaerts
added a comment - Agreed, that would be the quickest fix without breaking existing stuff (as far as someone besides myself is already using it).
I'll fix it later today Only split first occurrence (http://docs.oracle.com/javase/1.5.0/docs/api/java/lang/String.html#split%28java.lang.String,%20int%29 )
Does not support tool names with colon though, the other issue already discusses alternative formats.
I tried to resolve this by using '=' as separator but then I bump into this issue with args4j: https://java.net/jira/browse/ARGS4J-24
Gonna think about this tonight, any suggestions for a better, parseable format are always welcome.
Nico Mommaerts
added a comment - - edited I tried to resolve this by using '=' as separator but then I bump into this issue with args4j: https://java.net/jira/browse/ARGS4J-24
Gonna think about this tonight, any suggestions for a better, parseable format are always welcome. 
Code changed in jenkins
User: Nico Mommaerts
Path:
plugin/src/main/java/hudson/plugins/swarm/PluginImpl.java
http://jenkins-ci.org/commit/swarm-plugin/c0e0fe33227af2c709563fb45d441df28fb13dbe
Log:
JENKINS-25002Added a java comment explaining the use of the limit on the split function