• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • xvnc-plugin
    • Jenkins ver. 1.588

      When I press the edit node link I get the following OOPS with Stack trace:
      javax.servlet.ServletException: org.apache.commons.jelly.JellyTagException: jar:file:/var/cache/jenkins/war/WEB-INF/lib/jenkins-core-1.588.jar!/lib/form/descriptorList.jelly:78:49: <j:forEach> class hudson.plugins.xvnc.DisplayAllocator$Property is missing its descriptor
      at org.kohsuke.stapler.jelly.JellyFacet$1.dispatch(JellyFacet.java:103)
      at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)
      at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
      at org.kohsuke.stapler.MetaClass$12.dispatch(MetaClass.java:391)
      at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)
      at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
      at org.kohsuke.stapler.MetaClass$4.doDispatch(MetaClass.java:211)
      at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:53)
      at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)

          [JENKINS-25424] Exception when editing nodes

          I also get that issue with Jenkins 1.592 (From Ubuntu packages) and Xvnc plugin 1.20

          I was getting that also with my previous version of Jenkins but with the same plugin version.
          I don't know the version since I did an upgrade of Jenkins to try to fix that.

          My system is runnning on Ubuntu 14.04.1 LTS, all up to date.

          If you need more informations or details please feel free to ask.

          Florent Le Saout added a comment - I also get that issue with Jenkins 1.592 (From Ubuntu packages) and Xvnc plugin 1.20 I was getting that also with my previous version of Jenkins but with the same plugin version. I don't know the version since I did an upgrade of Jenkins to try to fix that. My system is runnning on Ubuntu 14.04.1 LTS, all up to date. If you need more informations or details please feel free to ask.

          I just check and on my system the Xvnc plugin version was correct :

          $ grep -nrI "hudson.plugins.xvnc.DisplayAllocator" . 2> /dev/null
          ./config.xml:148: <hudson.plugins.xvnc.DisplayAllocator_-Property plugin="xvnc@1.20"/>

          I did the same workaround wih removing this line and it also fixed the issue.

          Florent Le Saout added a comment - I just check and on my system the Xvnc plugin version was correct : $ grep -nrI "hudson.plugins.xvnc.DisplayAllocator" . 2> /dev/null ./config.xml:148: <hudson.plugins.xvnc.DisplayAllocator_-Property plugin="xvnc@1.20"/> I did the same workaround wih removing this line and it also fixed the issue.

          I still intend to try to provide detailed instructions for reproducing the problem, but the fact that people are able to work around it by removing this property seems to suggest that my original theory may be correct: once the node is used one time to run a job that uses the Xvnc plugin, this property appears, and after the property is there, configuration of the node fails in this way. I'll see if that formula works on a clean install. Removing properties and reloading is not a practical workaround for my installation. We scale up and down from between a small handful to several hundred nodes and are constantly churning through nodes. Reloading configuration from disk is not practical for us. In any case, since we churn through nodes, I'm not heavily handicapped by this.

          Jay Berkenbilt added a comment - I still intend to try to provide detailed instructions for reproducing the problem, but the fact that people are able to work around it by removing this property seems to suggest that my original theory may be correct: once the node is used one time to run a job that uses the Xvnc plugin, this property appears, and after the property is there, configuration of the node fails in this way. I'll see if that formula works on a clean install. Removing properties and reloading is not a practical workaround for my installation. We scale up and down from between a small handful to several hundred nodes and are constantly churning through nodes. Reloading configuration from disk is not practical for us. In any case, since we churn through nodes, I'm not heavily handicapped by this.

          Anyway after you run again a job on this node, then you get the same problem even if the line <hudson.plugins.xvnc.DisplayAllocator_-Property plugin="xvnc@1.20"/> is not in the config file anymore...

          Florent Le Saout added a comment - Anyway after you run again a job on this node, then you get the same problem even if the line <hudson.plugins.xvnc.DisplayAllocator_-Property plugin="xvnc@1.20"/> is not in the config file anymore...

          Reproduced in unittest, proposing fix: https://github.com/jenkinsci/xvnc-plugin/pull/4.

          Oliver Gondža added a comment - Reproduced in unittest, proposing fix: https://github.com/jenkinsci/xvnc-plugin/pull/4 .

          Fixed in 1.21

          Oliver Gondža added a comment - Fixed in 1.21

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          src/main/java/hudson/plugins/xvnc/DisplayAllocator.java
          src/test/java/hudson/plugins/xvnc/XvncTest.java
          http://jenkins-ci.org/commit/xvnc-plugin/80407410ada90bd97ca20a42d2f3d25f5876092f
          Log:
          [FIXED JENKINS-25424] Register the descriptor

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/main/java/hudson/plugins/xvnc/DisplayAllocator.java src/test/java/hudson/plugins/xvnc/XvncTest.java http://jenkins-ci.org/commit/xvnc-plugin/80407410ada90bd97ca20a42d2f3d25f5876092f Log: [FIXED JENKINS-25424] Register the descriptor

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          src/main/java/hudson/plugins/xvnc/DisplayAllocator.java
          http://jenkins-ci.org/commit/xvnc-plugin/39ec1bd658228ac535b8ddfa9bc65c84b6d103e8
          Log:
          JENKINS-25424 Correctly hide the property descriptor

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/main/java/hudson/plugins/xvnc/DisplayAllocator.java http://jenkins-ci.org/commit/xvnc-plugin/39ec1bd658228ac535b8ddfa9bc65c84b6d103e8 Log: JENKINS-25424 Correctly hide the property descriptor

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          src/test/java/hudson/plugins/xvnc/XvncTest.java
          http://jenkins-ci.org/commit/xvnc-plugin/c68619dd57d7b048b25dd449a26c8cf4e6c95818
          Log:
          JENKINS-25424 End-to-end test

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/test/java/hudson/plugins/xvnc/XvncTest.java http://jenkins-ci.org/commit/xvnc-plugin/c68619dd57d7b048b25dd449a26c8cf4e6c95818 Log: JENKINS-25424 End-to-end test

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          src/main/java/hudson/plugins/xvnc/DisplayAllocator.java
          src/test/java/hudson/plugins/xvnc/XvncTest.java
          http://jenkins-ci.org/commit/xvnc-plugin/9cde893ced088cfe6e8ff40150163832ea7a2de4
          Log:
          Merge pull request #4 from olivergondza/register-descriptor

          [FIXED JENKINS-25424] Register the descriptor

          Compare: https://github.com/jenkinsci/xvnc-plugin/compare/2cb6669f1b53...9cde893ced08

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/main/java/hudson/plugins/xvnc/DisplayAllocator.java src/test/java/hudson/plugins/xvnc/XvncTest.java http://jenkins-ci.org/commit/xvnc-plugin/9cde893ced088cfe6e8ff40150163832ea7a2de4 Log: Merge pull request #4 from olivergondza/register-descriptor [FIXED JENKINS-25424] Register the descriptor Compare: https://github.com/jenkinsci/xvnc-plugin/compare/2cb6669f1b53...9cde893ced08

            levsa Levon Saldamli
            aholzmann Andreas Holzmann
            Votes:
            2 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved: