Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25785

Windows slaves controlled as Windows Service do not use credentials manager

    • Icon: Improvement Improvement
    • Resolution: Won't Fix
    • Icon: Minor Minor
    • windows-slaves-plugin
    • None
    • jenkins 1.576, windows-slaves-plugin 1.0

      When connecting Unix machines through SSH,the SSH Slaves plugin uses the SSH Credentials plugin to be able to store the SSH credentials in one place. Then when or if these credentials change, they only have to be updated in one place to update every affected SSH slave connected.

      However, when adding a Windows slave, using the "Let Jenkins Control this Windows Slave as Windows service" method, each slave connected has its own authentication credentials. This means after a password change that every Windows slave configuration must be updated. These credentials for Windows slaves should be stored in the Credentials Manager plugin, and used from there, then the storing of credentials for Windows or Unix slaves would be consistent, and the maintenance of Windows slaves would be reduced.

          [JENKINS-25785] Windows slaves controlled as Windows Service do not use credentials manager

          Vincent Latombe added a comment - - edited

          Vincent Latombe added a comment - - edited Submitted https://github.com/jenkinsci/windows-slaves-plugin/pull/3/

          Code changed in jenkins
          User: Vincent Latombe
          Path:
          core/src/main/java/hudson/ClassicPluginStrategy.java
          http://jenkins-ci.org/commit/jenkins/a65d007533cc882d85715677ec75f06e001e1e8a
          Log:
          Prerequisite for JENKINS-25785 in order to break dependency cycle when windows-slaves will depend on credentials

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vincent Latombe Path: core/src/main/java/hudson/ClassicPluginStrategy.java http://jenkins-ci.org/commit/jenkins/a65d007533cc882d85715677ec75f06e001e1e8a Log: Prerequisite for JENKINS-25785 in order to break dependency cycle when windows-slaves will depend on credentials

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          core/src/main/java/hudson/ClassicPluginStrategy.java
          http://jenkins-ci.org/commit/jenkins/78f631805dacc6682e67123bd5e9c16e251259ef
          Log:
          Merge pull request #1735 from Vlatombe/JENKINS-25785_prerequisite

          Prerequisite for JENKINS-25785

          Compare: https://github.com/jenkinsci/jenkins/compare/f3f8abd36bdd...78f631805dac

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/ClassicPluginStrategy.java http://jenkins-ci.org/commit/jenkins/78f631805dacc6682e67123bd5e9c16e251259ef Log: Merge pull request #1735 from Vlatombe/ JENKINS-25785 _prerequisite Prerequisite for JENKINS-25785 Compare: https://github.com/jenkinsci/jenkins/compare/f3f8abd36bdd...78f631805dac

          Diogo Guerra added a comment -

          vlatombe I'm having some problems on using the credentials plugin with jgit and windows slave. It seems that the credentials are never used (not a problem of changes and restarts). I don't know in depth the source but is your patch integrating the credentials plugin with the windows slaves plugin?

          I'm using Jenkins 2.2, git plugin 2.4.4, windows slaves 1.1. It works well with linux slaves but windows ones it doesn't.

          Diogo Guerra added a comment - vlatombe I'm having some problems on using the credentials plugin with jgit and windows slave. It seems that the credentials are never used (not a problem of changes and restarts). I don't know in depth the source but is your patch integrating the credentials plugin with the windows slaves plugin? I'm using Jenkins 2.2, git plugin 2.4.4, windows slaves 1.1. It works well with linux slaves but windows ones it doesn't.

          deag My patch allows to use credentials to start a windows slave instead of plain user/pwd from the UI. If you have a problem related to jgit/windows slaves, it probably has nothing to do with this.

          Vincent Latombe added a comment - deag My patch allows to use credentials to start a windows slave instead of plain user/pwd from the UI. If you have a problem related to jgit/windows slaves, it probably has nothing to do with this.

          Mark Waite added a comment -

          Won't be fixed. See JENKINS-67604 for the details of the deprecation of agents started by WMI calls using DCOM.

          Mark Waite added a comment - Won't be fixed. See JENKINS-67604 for the details of the deprecation of agents started by WMI calls using DCOM.

            vlatombe Vincent Latombe
            rickybobpat Rick Patterson
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: