Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26392

Option "Recurse in subfolders" does not work

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The option "Recurse in subfolders" (added with 1.18 in pull request https://github.com/jenkinsci/radiatorview-plugin/pull/11) does not work properly because it was just introduced as a workaround for a ClassCastException (JENKINS-18025, JENKINS-20415, JENKINS-20664).

      However, this feature should be enabled for users of the Folder Plugin. The behavior can be simply copied from the ListView(.jelly).

      (A pull request is on the way)

        Attachments

          Issue Links

            Activity

            seder Stefan Prietl created issue -
            ircbot Jenkins IRC Bot made changes -
            Field Original Value New Value
            Component/s radiatorviewplugin [ 16046 ]
            batmat Baptiste Mathus made changes -
            Assignee howama [ howama ] Baptiste Mathus [ batmat ]
            Hide
            anderskolsson Anders Olsson added a comment -

            I'm having mixed success with the "Recurse in subfolders" feature. It works in one Jenkins instance, but silently does nothing on another (also nothing printed to the System log). Any news on the proposed pull request?

            Show
            anderskolsson Anders Olsson added a comment - I'm having mixed success with the "Recurse in subfolders" feature. It works in one Jenkins instance, but silently does nothing on another (also nothing printed to the System log). Any news on the proposed pull request?
            Hide
            batmat Baptiste Mathus added a comment -

            Hi, didn't check https://github.com/jenkinsci/radiatorview-plugin/pull/16 actually, I had missed it.

            Gonna try and have a look at it sometime soon, though it's a wee bit harder for me to watch out than in general since we don't use folders yet (but might want start using it).

            Show
            batmat Baptiste Mathus added a comment - Hi, didn't check https://github.com/jenkinsci/radiatorview-plugin/pull/16 actually, I had missed it. Gonna try and have a look at it sometime soon, though it's a wee bit harder for me to watch out than in general since we don't use folders yet (but might want start using it).
            Hide
            dankirkd Daniel Kirkdorffer added a comment - - edited

            What is the status on this issue? We would really like it fixed. We're using v1.24 with Jenkins 1.628

            Show
            dankirkd Daniel Kirkdorffer added a comment - - edited What is the status on this issue? We would really like it fixed. We're using v1.24 with Jenkins 1.628
            dankirkd Daniel Kirkdorffer made changes -
            Priority Trivial [ 5 ] Major [ 3 ]
            recena Manuel Recena Soto made changes -
            Remote Link This issue links to "PR (Web Link)" [ 13807 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: seder
            Path:
            src/main/resources/hudson/model/RadiatorView/configure-entries.jelly
            http://jenkins-ci.org/commit/radiatorview-plugin/0f582e0c799355d3ea1aa9d1ddc4e33142c3b1bd
            Log:
            Fix non-working "Recurse in subfolders" option

            Issue: JENKINS-26392

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: seder Path: src/main/resources/hudson/model/RadiatorView/configure-entries.jelly http://jenkins-ci.org/commit/radiatorview-plugin/0f582e0c799355d3ea1aa9d1ddc4e33142c3b1bd Log: Fix non-working "Recurse in subfolders" option Issue: JENKINS-26392
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Baptiste Mathus
            Path:
            src/main/java/hudson/model/RadiatorView.java
            http://jenkins-ci.org/commit/radiatorview-plugin/9b958f2d1d8d1ebefa7a81e329591a10af6b95ac
            Log:
            JENKINS-26392 Fix ClassCastException w/ Folders

            Not yet ideal/intuitive, since now you can select a folder but it won't
            select its children.
            But at least it's not crashing totally when using it, I guess that's
            still an improvement...

            Compare: https://github.com/jenkinsci/radiatorview-plugin/compare/760284ea9dfb...9b958f2d1d8d

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Baptiste Mathus Path: src/main/java/hudson/model/RadiatorView.java http://jenkins-ci.org/commit/radiatorview-plugin/9b958f2d1d8d1ebefa7a81e329591a10af6b95ac Log: JENKINS-26392 Fix ClassCastException w/ Folders Not yet ideal/intuitive, since now you can select a folder but it won't select its children. But at least it's not crashing totally when using it, I guess that's still an improvement... Compare: https://github.com/jenkinsci/radiatorview-plugin/compare/760284ea9dfb...9b958f2d1d8d
            Hide
            batmat Baptiste Mathus added a comment - - edited

            Just released a 1.26-beta-1

            Could people interested by this fix here test this version and provide feedback?
            If this works for you, then I'll release a 1.26 shortly.

            Thanks

            Show
            batmat Baptiste Mathus added a comment - - edited Just released a 1.26-beta-1 Could people interested by this fix here test this version and provide feedback? If this works for you, then I'll release a 1.26 shortly. Thanks
            Hide
            batmat Baptiste Mathus added a comment -

            1.26-beta-1 waiting for feedback. Deemed fixed.

            Show
            batmat Baptiste Mathus added a comment - 1.26-beta-1 waiting for feedback. Deemed fixed.
            batmat Baptiste Mathus made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            Hide
            batmat Baptiste Mathus added a comment - - edited

            1.26-beta-2 released just now. Now requires Jenkins 1.554.1 LTS as min version.
            (Apart from the Jenkins min bump, only technical differences (using DataBoundSetter instead of DataBoundConstructor FWIW))

            Please test that one if possible instead of the beta-1.

            Thanks

            Show
            batmat Baptiste Mathus added a comment - - edited 1.26-beta-2 released just now. Now requires Jenkins 1.554.1 LTS as min version. (Apart from the Jenkins min bump, only technical differences (using DataBoundSetter instead of DataBoundConstructor FWIW)) Please test that one if possible instead of the beta-1. Thanks
            Hide
            dankirkd Daniel Kirkdorffer added a comment -

            How do I install 1.26-beta-2? It doesn't show up as the latest version in Jenkins.

            Show
            dankirkd Daniel Kirkdorffer added a comment - How do I install 1.26-beta-2? It doesn't show up as the latest version in Jenkins.
            Hide
            batmat Baptiste Mathus added a comment -

            To install beta versions, you got to temporarily switch to the Experimental Update Center.

            Thanks

            Show
            batmat Baptiste Mathus added a comment - To install beta versions, you got to temporarily switch to the Experimental Update Center . Thanks
            Hide
            dankirkd Daniel Kirkdorffer added a comment -

            Seems to work.

            Show
            dankirkd Daniel Kirkdorffer added a comment - Seems to work.
            Hide
            batmat Baptiste Mathus added a comment -

            Cool, I think I'll leave still until tomorrow and release a 1.26 if I hear no bad feedback until then.

            Thanks

            Show
            batmat Baptiste Mathus added a comment - Cool, I think I'll leave still until tomorrow and release a 1.26 if I hear no bad feedback until then. Thanks
            Hide
            aheritier Arnaud Héritier added a comment -

            Baptiste Mathus I confirm that it is also ok for my customer who had the issue.

            Show
            aheritier Arnaud Héritier added a comment - Baptiste Mathus I confirm that it is also ok for my customer who had the issue.
            Hide
            batmat Baptiste Mathus added a comment -

            OK, thanks Daniel Kirkdorffer and Arnaud Héritier for the feedback. So, I've finally decided to release immediately the 1.26 GA version with your answers.
            It should land in the update center in a few hours.

            Cheers

            Show
            batmat Baptiste Mathus added a comment - OK, thanks Daniel Kirkdorffer and Arnaud Héritier for the feedback. So, I've finally decided to release immediately the 1.26 GA version with your answers. It should land in the update center in a few hours. Cheers
            Hide
            aheritier Arnaud Héritier added a comment -

            Thanks a lot Baptiste Mathus

            Show
            aheritier Arnaud Héritier added a comment - Thanks a lot Baptiste Mathus
            Hide
            dankirkd Daniel Kirkdorffer added a comment -

            Appreciated.

            Show
            dankirkd Daniel Kirkdorffer added a comment - Appreciated.
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 160458 ] JNJira + In-Review [ 196442 ]

              People

              Assignee:
              batmat Baptiste Mathus
              Reporter:
              seder Stefan Prietl
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: