Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26399

Utility method in JenkinsRule to wait for build to complete

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      See BindingStepTest.cleanupAfterRestart for example.

          [JENKINS-26399] Utility method in JenkinsRule to wait for build to complete

          Jesse Glick created issue -

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java
          http://jenkins-ci.org/commit/workflow-plugin/3d3fa348ed9c34e4492b2733802bc47416824e30
          Log:
          JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
          Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
          Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
          Also need to wait for the build to finish (JENKINS-26399).

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java http://jenkins-ci.org/commit/workflow-plugin/3d3fa348ed9c34e4492b2733802bc47416824e30 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ).
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-25975 [ JENKINS-25975 ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/JenkinsRuleExt.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/SingleJobTestBase.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/SleepStepTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/StageTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/WorkspaceStepTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/RunWrapperTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java
          http://jenkins-ci.org/commit/workflow-plugin/fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9
          Log:
          JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/JenkinsRuleExt.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/SingleJobTestBase.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/SleepStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/StageTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/WorkspaceStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/RunWrapperTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java http://jenkins-ci.org/commit/workflow-plugin/fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9 Log: JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message
          Jesse Glick made changes -
          Remote Link New: This issue links to "PR 1609 (Web Link)" [ 12167 ]
          Jesse Glick made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          test/src/main/java/org/jvnet/hudson/test/BuildWatcher.java
          test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
          http://jenkins-ci.org/commit/jenkins/9ac2257d0a3fa86928267a82d69d55c5a4e423c1
          Log:
          [FIXED JENKINS-26399] JENKINS-25975 Merged #1609.

          Compare: https://github.com/jenkinsci/jenkins/compare/b02e71e3dfcb...9ac2257d0a3f

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: test/src/main/java/org/jvnet/hudson/test/BuildWatcher.java test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java http://jenkins-ci.org/commit/jenkins/9ac2257d0a3fa86928267a82d69d55c5a4e423c1 Log: [FIXED JENKINS-26399] JENKINS-25975 Merged #1609. Compare: https://github.com/jenkinsci/jenkins/compare/b02e71e3dfcb...9ac2257d0a3f

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/BuildWatcher.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/JenkinsRuleExt.java
          http://jenkins-ci.org/commit/workflow-plugin/c37ee2bafacb9c512cf9442a073130d888759cec
          Log:
          JENKINS-26399 Noting.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/BuildWatcher.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/JenkinsRuleExt.java http://jenkins-ci.org/commit/workflow-plugin/c37ee2bafacb9c512cf9442a073130d888759cec Log: JENKINS-26399 Noting.
          Jesse Glick made changes -
          Assignee New: Jesse Glick [ jglick ]

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: