Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26722

Clover PHP Plugin should not ignore namespaced code

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • cloverphp-plugin
    • Jenkins ver. 1.596
      PHPUnit 4.4.5
      Clover plugin 4.4.0
      Clover PHP plugin 0.3.3

      Clover PHP Plugin does not generate per-file reports for namespaced code.

      Any file starting with namespace keyword is excluded from "Coverage Breakdown by File" section of "Clover Summary Report" page, even though it's included in "Overall Coverage Summary" section of the same page.

          [JENKINS-26722] Clover PHP Plugin should not ignore namespaced code

          Cezary Kluczyński created issue -
          Joseph Jozwik made changes -
          Priority Original: Minor [ 4 ] New: Blocker [ 1 ]
          Joseph Jozwik made changes -
          Priority Original: Blocker [ 1 ] New: Minor [ 4 ]

          Patrick Brückner added a comment -

          Any hints on where to start? It is a medium issue to us and it seemed easy fix, but I cannot figure out where to start or how to write the right test.

          I did already wrote a test in the CoverageParserTest class, that checks if all files are correctly listed (while having a lot of namespaced Classes) by the CloverCoverageParser; but this seems fine.

          Thanks for any hints!

          Patrick Brückner added a comment - Any hints on where to start? It is a medium issue to us and it seemed easy fix, but I cannot figure out where to start or how to write the right test. I did already wrote a test in the CoverageParserTest class, that checks if all files are correctly listed (while having a lot of namespaced Classes) by the CloverCoverageParser; but this seems fine. Thanks for any hints!

          Cezary Kluczyński added a comment -

          I'm not sure if that's of any help, but when I was digging around for solution for this issue, I came acros this StackOverflow answer: http://stackoverflow.com/a/26923198/3807342

          Cezary Kluczyński added a comment - I'm not sure if that's of any help, but when I was digging around for solution for this issue, I came acros this StackOverflow answer: http://stackoverflow.com/a/26923198/3807342

          Patrick Brückner added a comment -

          I added the patterns including /package/ as suggested in your link, but it does still not work on my side.

          Code is available at https://github.com/madmuffin1/cloverphp-plugin/tree/include-namespaced-classes

          Patrick Brückner added a comment - I added the patterns including /package/ as suggested in your link, but it does still not work on my side. Code is available at https://github.com/madmuffin1/cloverphp-plugin/tree/include-namespaced-classes

          Patrick Brückner added a comment -

          I have started working on a fix. Expect a mergeable patch within the course of the week.

          Patrick Brückner added a comment - I have started working on a fix. Expect a mergeable patch within the course of the week.
          Patrick Brückner made changes -
          Assignee Original: sogabe [ sogabe ] New: Patrick Brückner [ madmuffin ]
          Patrick Brückner made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Patrick Brückner made changes -
          Assignee Original: Patrick Brückner [ madmuffin ] New: sogabe [ sogabe ]

            sogabe sogabe
            cezarykluczynski Cezary Kluczyński
            Votes:
            5 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated: