Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26781

regression resolving Descriptor using "$class" vs "kind"

      https://github.com/jenkinsci/jenkins/commit/4de46465153dae1a9e804c0d526c44d528f00fb4 restored support for "kind" as a way to resolve descriptor matching a configured entity.

      Side effect is : a descriptor which uses a custom string as ID (as recommended by hudson.model.Descriptor#getId) won't be resolved as hudson.model.Descriptor#find who will compare ID with $class, not kind=ID.

          [JENKINS-26781] regression resolving Descriptor using "$class" vs "kind"

          Nicolas De Loof created issue -

          This actually is an issue with Cloudbees-template plugin, which uses a distinct descriptor.id != descriptor.clazz. Issue will be fixed in cloudbees plugin.

          Nicolas De Loof added a comment - This actually is an issue with Cloudbees-template plugin, which uses a distinct descriptor.id != descriptor.clazz. Issue will be fixed in cloudbees plugin.
          Nicolas De Loof made changes -
          Component/s New: core [ 15593 ]
          Component/s Original: cobertura-plugin [ 15500 ]
          Assignee Original: Stephen Connolly [ stephenconnolly ] New: Nicolas De Loof [ ndeloof ]
          Nicolas De Loof made changes -
          Resolution New: Won't Fix [ 2 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          Code changed in jenkins
          User: Nicolas De Loof
          Path:
          core/src/main/java/hudson/model/Descriptor.java
          core/src/main/resources/lib/form/class-entry.jelly
          http://jenkins-ci.org/commit/jenkins/094d1cf723885e2c62e4acecb8fb0a32b45ff8ab
          Log:
          JENKINS-26781 set $class in submitted form to use descriptor.id, so descriptor can be retrieved by ID, which may not be clazz.name

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: core/src/main/java/hudson/model/Descriptor.java core/src/main/resources/lib/form/class-entry.jelly http://jenkins-ci.org/commit/jenkins/094d1cf723885e2c62e4acecb8fb0a32b45ff8ab Log: JENKINS-26781 set $class in submitted form to use descriptor.id, so descriptor can be retrieved by ID, which may not be clazz.name

          Code changed in jenkins
          User: Nicolas De Loof
          Path:
          core/src/main/java/hudson/model/Descriptor.java
          core/src/main/resources/lib/form/class-entry.jelly
          http://jenkins-ci.org/commit/jenkins/3edce884ec57c2b98d1aa18cd4a2c744bf1719c9
          Log:
          JENKINS-26781 set $class in submitted form to use descriptor.id, so descriptor can be retrieved by ID, which may not be clazz.name

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: core/src/main/java/hudson/model/Descriptor.java core/src/main/resources/lib/form/class-entry.jelly http://jenkins-ci.org/commit/jenkins/3edce884ec57c2b98d1aa18cd4a2c744bf1719c9 Log: JENKINS-26781 set $class in submitted form to use descriptor.id, so descriptor can be retrieved by ID, which may not be clazz.name

          Code changed in jenkins
          User: Nicolas De Loof
          Path:
          core/src/main/java/hudson/model/Descriptor.java
          core/src/main/resources/lib/form/class-entry.jelly
          http://jenkins-ci.org/commit/jenkins/57c9b4807b57e7d0e58894b53c806047e121ea1f
          Log:
          JENKINS-26781 set $class in submitted form to use descriptor.id, so descriptor can be retrieved by ID, which may not be clazz.name

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: core/src/main/java/hudson/model/Descriptor.java core/src/main/resources/lib/form/class-entry.jelly http://jenkins-ci.org/commit/jenkins/57c9b4807b57e7d0e58894b53c806047e121ea1f Log: JENKINS-26781 set $class in submitted form to use descriptor.id, so descriptor can be retrieved by ID, which may not be clazz.name

          Code changed in jenkins
          User: Nicolas De Loof
          Path:
          core/src/main/java/hudson/model/Descriptor.java
          core/src/main/resources/lib/form/class-entry.jelly
          http://jenkins-ci.org/commit/jenkins/8881703f7c7351695c5d5b2662faefae60de68e8
          Log:
          JENKINS-26781 lookup descriptor by ID, then by class if explicitly set
          to match some specific use cases.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: core/src/main/java/hudson/model/Descriptor.java core/src/main/resources/lib/form/class-entry.jelly http://jenkins-ci.org/commit/jenkins/8881703f7c7351695c5d5b2662faefae60de68e8 Log: JENKINS-26781 lookup descriptor by ID, then by class if explicitly set to match some specific use cases.
          Jesse Glick made changes -
          Labels New: api stapler
          Jesse Glick made changes -
          Labels Original: api stapler New: api regression stapler

            jglick Jesse Glick
            ndeloof Nicolas De Loof
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: