[JENKINS-26936] support thrown from publisher job statuses

Type: Bug
Resolution: Fixed
Priority: Blocker
Component/s: flexible-publish-plugin
Labels:
None

Similar Issues:
Powered by SuggestiMate

Show

Boolean return from publishers is deprecated, but there is a total mess in all plugins and core about it. New and right variant now is to fail build with throw AbortException. Such errors are not catched in flexible publish and first thrown publisher stops flexible execution for other publishers nevertheless on configured conditions.
According to my debugging plugin must

try { perform } catch { return false;}

somewhere in root calls in addition to boolean return codes

Executor #1 for master : executing job #73@9386, prio=5, in group 'main', status: 'RUNNING'
	  at hudson.plugins.git.GitPublisher.perform(GitPublisher.java:281)
	  at org.jenkins_ci.plugins.run_condition.BuildStepRunner$2.run(BuildStepRunner.java:110)
	  at org.jenkins_ci.plugins.run_condition.BuildStepRunner$Fail.conditionalRun(BuildStepRunner.java:154)
	  at org.jenkins_ci.plugins.run_condition.BuildStepRunner.perform(BuildStepRunner.java:105)
	  at org.jenkins_ci.plugins.flexible_publish.ConditionalPublisher.perform(ConditionalPublisher.java:183)
	  at org.jenkins_ci.plugins.flexible_publish.FlexiblePublisher.perform(FlexiblePublisher.java:116)
	  at hudson.tasks.BuildStepMonitor$3.perform(BuildStepMonitor.java:45)
	  at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:756)
	  at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:720)
	  at hudson.model.Build$BuildExecution.post2(Build.java:182)
	  at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:669)
	  at hudson.model.Run.execute(Run.java:1731)
	  at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	  at hudson.model.ResourceController.execute(ResourceController.java:88)
	  at hudson.model.Executor.run(Executor.java:232)

Also if flexible-publish needs itself fail build - it must throw AbortException
See https://github.com/KostyaSha/git-plugin/commit/3af2af6af273a10e9c5ab4e4d200222bc39c2f3e for example.

is related to

JENKINS-26964 post-build action statuses handling

Resolved

links to

flexible-publish-plugin/pull/9

flexible-publish-plugin/pull/10

flexible-publish-plugin/pull/11

Kanstantsin Shautsou created issue - 2015-02-12 17:21

Kanstantsin Shautsou made changes - 2015-02-12 17:23

Description

Original: Boolean return from publishers is deprecated, but there is a total mess in all plugins and core about it. New and right variant now is to fail build with throw AbortException. Such errors are not catched in flexible publish and first thrown publisher stops flexible execution for other publishers nevertheless on configured conditions.
According to my debugging plugin must
{code}
try { perform } catch { return false;}
{code}
somewhere in root calls in addition to boolean return codes
{code}
Executor #1 for master : executing job #73@9386, prio=5, in group 'main', status: 'RUNNING'
at hudson.plugins.git.GitPublisher.perform(GitPublisher.java:281)
at org.jenkins_ci.plugins.run_condition.BuildStepRunner$2.run(BuildStepRunner.java:110)
at org.jenkins_ci.plugins.run_condition.BuildStepRunner$Fail.conditionalRun(BuildStepRunner.java:154)
at org.jenkins_ci.plugins.run_condition.BuildStepRunner.perform(BuildStepRunner.java:105)
at org.jenkins_ci.plugins.flexible_publish.ConditionalPublisher.perform(ConditionalPublisher.java:183)
at org.jenkins_ci.plugins.flexible_publish.FlexiblePublisher.perform(FlexiblePublisher.java:116)
at hudson.tasks.BuildStepMonitor$3.perform(BuildStepMonitor.java:45)
at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:756)
at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:720)
at hudson.model.Build$BuildExecution.post2(Build.java:182)
at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:669)
at hudson.model.Run.execute(Run.java:1731)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:88)
at hudson.model.Executor.run(Executor.java:232)
{code}
Also if flexible-publish needs itself fail build - it must throw AbortException

New: Boolean return from publishers is deprecated, but there is a total mess in all plugins and core about it. New and right variant now is to fail build with throw AbortException. Such errors are not catched in flexible publish and first thrown publisher stops flexible execution for other publishers nevertheless on configured conditions.
According to my debugging plugin must
{code}
try { perform } catch { return false;}
{code}
somewhere in root calls in addition to boolean return codes
{code}
Executor #1 for master : executing job #73@9386, prio=5, in group 'main', status: 'RUNNING'
at hudson.plugins.git.GitPublisher.perform(GitPublisher.java:281)
at org.jenkins_ci.plugins.run_condition.BuildStepRunner$2.run(BuildStepRunner.java:110)
at org.jenkins_ci.plugins.run_condition.BuildStepRunner$Fail.conditionalRun(BuildStepRunner.java:154)
at org.jenkins_ci.plugins.run_condition.BuildStepRunner.perform(BuildStepRunner.java:105)
at org.jenkins_ci.plugins.flexible_publish.ConditionalPublisher.perform(ConditionalPublisher.java:183)
at org.jenkins_ci.plugins.flexible_publish.FlexiblePublisher.perform(FlexiblePublisher.java:116)
at hudson.tasks.BuildStepMonitor$3.perform(BuildStepMonitor.java:45)
at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:756)
at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:720)
at hudson.model.Build$BuildExecution.post2(Build.java:182)
at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:669)
at hudson.model.Run.execute(Run.java:1731)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:88)
at hudson.model.Executor.run(Executor.java:232)
{code}
Also if flexible-publish needs itself fail build - it must throw AbortException
See https://github.com/KostyaSha/git-plugin/commit/3af2af6af273a10e9c5ab4e4d200222bc39c2f3e for example.

Kanstantsin Shautsou made changes - 2015-02-12 17:24

Assignee

Original: bap [ bap ]

New: ikedam [ ikedam ]

ikedam made changes - 2015-02-15 03:38

Priority

Original: Blocker [ 1 ]

New: Major [ 3 ]

ikedam made changes - 2015-02-15 03:38

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Kanstantsin Shautsou made changes - 2015-02-15 14:03

Priority

Original: Major [ 3 ]

New: Blocker [ 1 ]

Kanstantsin Shautsou made changes - 2015-02-15 15:53

Remote Link

New: This issue links to "flexible-publish-plugin/pull/10 (Web Link)" [ 12110 ]

Kanstantsin Shautsou made changes - 2015-02-15 15:53

Remote Link

New: This issue links to "flexible-publish-plugin/pull/9 (Web Link)" [ 12111 ]

Kanstantsin Shautsou made changes - 2015-02-15 16:31

Link

New: This issue is related to ~~JENKINS-26964~~ [ ~~JENKINS-26964~~ ]

Kanstantsin Shautsou made changes - 2015-02-16 02:33

Remote Link

New: This issue links to "flexible-publish-plugin/pull/11 (Web Link)" [ 12112 ]

ikedam made changes - 2015-03-28 01:53

Resolution		New: Fixed [ 1 ]
Status	Original: In Progress [ 3 ]	New: Resolved [ 5 ]

Assignee:: ikedam

Reporter:: Kanstantsin Shautsou

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 2015-02-12 17:21

Updated:: 2015-03-28 01:54

Resolved:: 2015-03-28 01:53

Jenkins

Details

Description

Attachments

Issue Links

Activity

People

Dates