• Icon: New Feature New Feature
    • Resolution: Fixed
    • Icon: Major Major
    • build-user-vars-plugin
    • 1.598
      workflow-plugin 1.2
      user-build-vars-plugin 1.4

      The user build vars plugin is not available for a workflow job.

      This plugin should either be made available to workflow jobs or the variables could be directly generated in the workflow plugin, just as the job parameters are made available as variables inside workflow jobs.

          [JENKINS-26953] Workflow support for Build User Vars

          Jesse Glick added a comment -

          Implementing SimpleBuildWrapper in Jenkins 1.599+ would be the easiest integration path.

          Jesse Glick added a comment - Implementing SimpleBuildWrapper in Jenkins 1.599+ would be the easiest integration path.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: COMPATIBILITY.md http://jenkins-ci.org/commit/workflow-plugin/2ec399aa1d54432b22fbd5052b24d824da4670d3 Log: JENKINS-27120 JENKINS-27121 JENKINS-26953 JENKINS-27123 JENKINS-26432 Noting.

          I have two pull-requests to address this. The first one deals with minor readability issues. I have made indentation more uniform, removed useless whitespace, and changed tabs to spaces. I think this first PR improves readability.

          It is ready for review and approval:
          https://github.com/jenkinsci/build-user-vars-plugin/pull/7

          Once the fate of this PR is determined, I can post the second one. In the mean time, you can see the changes here:
          https://github.com/jenkinsci/build-user-vars-plugin/commit/4dbb658c3e771b98d294cf0fe98fb947b4b71182

          Martin d'Anjou added a comment - I have two pull-requests to address this. The first one deals with minor readability issues. I have made indentation more uniform, removed useless whitespace, and changed tabs to spaces. I think this first PR improves readability. It is ready for review and approval: https://github.com/jenkinsci/build-user-vars-plugin/pull/7 Once the fate of this PR is determined, I can post the second one. In the mean time, you can see the changes here: https://github.com/jenkinsci/build-user-vars-plugin/commit/4dbb658c3e771b98d294cf0fe98fb947b4b71182

          Jesse Glick added a comment -

          Weird, 4dbb658c3e771b98d294cf0fe98fb947b4b71182 does not seem to use any commit from PR #7 as its parent. If it did, you could just file PR #8 and note that it subsumes #7. Merging #8 would mark #7 as merged automatically. And you can construct permalinks which show only the effective diff from #7 to #8 (though GH does not allow reviewers to issue line-by-line comments on such diffs—only on the files diff tab of a PR).

          Jesse Glick added a comment - Weird, 4dbb658c3e771b98d294cf0fe98fb947b4b71182 does not seem to use any commit from PR #7 as its parent. If it did, you could just file PR #8 and note that it subsumes #7. Merging #8 would mark #7 as merged automatically. And you can construct permalinks which show only the effective diff from #7 to #8 (though GH does not allow reviewers to issue line-by-line comments on such diffs—only on the files diff tab of a PR).

          I think I got what you're asking for jglick:
          https://github.com/jenkinsci/build-user-vars-plugin/pull/8

          The workflow changes are all in the last commit of that pull request. If you run git diff -b master, it hides almost all the whitespace changes (2 or 3 still show) and it shows all the workflow compatibility changes (very few were needed actually).

          Martin d'Anjou added a comment - I think I got what you're asking for jglick : https://github.com/jenkinsci/build-user-vars-plugin/pull/8 The workflow changes are all in the last commit of that pull request. If you run git diff -b master , it hides almost all the whitespace changes (2 or 3 still show) and it shows all the workflow compatibility changes (very few were needed actually).

          The maintainer would like a pull-request that does not change any whitespace. Here it is:
          https://github.com/jenkinsci/build-user-vars-plugin/pull/9

          Martin d'Anjou added a comment - The maintainer would like a pull-request that does not change any whitespace. Here it is: https://github.com/jenkinsci/build-user-vars-plugin/pull/9

          At this stage, I do not know what process to follow to get a new release to be made other than ask for it. I asked on the mailing list and in the pull request itself: https://github.com/jenkinsci/build-user-vars-plugin/pull/9

          Martin d'Anjou added a comment - At this stage, I do not know what process to follow to get a new release to be made other than ask for it. I asked on the mailing list and in the pull request itself: https://github.com/jenkinsci/build-user-vars-plugin/pull/9

          Jesse Glick added a comment -

          Issues are normally marked Fixed as soon as the PR is merged.

          Jesse Glick added a comment - Issues are normally marked Fixed as soon as the PR is merged.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          COMPATIBILITY.md
          http://jenkins-ci.org/commit/workflow-plugin/e1a8190f4fd335cf2d6a7c6fb4b83972230a275d
          Log:
          JENKINS-26953 Noting release.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: COMPATIBILITY.md http://jenkins-ci.org/commit/workflow-plugin/e1a8190f4fd335cf2d6a7c6fb4b83972230a275d Log: JENKINS-26953 Noting release.

            deepchip Martin d'Anjou
            thebignet Jean Detoeuf
            Votes:
            3 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved: