Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-27026

Log/notify SSH CLI authentication

XMLWordPrintable

      SecurityListener should be notified when SshCliAuthenticator approves or denies a CLI command.

          [JENKINS-27026] Log/notify SSH CLI authentication

          Jesse Glick created issue -
          Jesse Glick made changes -
          Link New: This issue depends on JENKINS-20999 [ JENKINS-20999 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 161217 ] New: JNJira + In-Review [ 180610 ]
          Jesse Glick made changes -
          Link New: This issue relates to JENKINS-41745 [ JENKINS-41745 ]

          Jesse Glick added a comment -

          More broadly, notify use of any SSH authentication in AsynchronousCommand.start.

          Jesse Glick added a comment - More broadly, notify use of any SSH authentication in AsynchronousCommand.start .

          Oleg Nenashev added a comment -

          Things to investigate:

          • Different authentication modes (User/Password/ API token, private key)
            • login/logout - on the server side (not the command)
          • We don not investigate Remoting mode and its login/logout commands

           

           

          Oleg Nenashev added a comment - Things to investigate: Different authentication modes (User/Password/ API token, private key) login/logout - on the server side (not the command) We don not investigate Remoting mode and its login/logout commands    
          Wadeck Follonier made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Wadeck Follonier made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Wadeck Follonier
          Path:
          src/main/java/org/jenkinsci/main/modules/sshd/PublicKeyAuthenticatorImpl.java
          http://jenkins-ci.org/commit/sshd-module/000dceefda3180522c625b011e94ef583058b3e6
          Log:
          JENKINS-27026 Fire authentication events when using SSH (#22)

          • - remove whitespace changes
          • - implement the user.impersonate as proposed by Jesse
          • also manage to create a UserDetails to notify the SecurityListener
          • - constructor of the inner class can even be private
          • - privatize the inner class to avoid API exposure
          • adjust log messages
          • - remove single quote in log
          • use getById instead of get

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Wadeck Follonier Path: src/main/java/org/jenkinsci/main/modules/sshd/PublicKeyAuthenticatorImpl.java http://jenkins-ci.org/commit/sshd-module/000dceefda3180522c625b011e94ef583058b3e6 Log: JENKINS-27026 Fire authentication events when using SSH (#22) JENKINS-27026 Fire authentication events when using SSH - remove whitespace changes - implement the user.impersonate as proposed by Jesse also manage to create a UserDetails to notify the SecurityListener - constructor of the inner class can even be private - privatize the inner class to avoid API exposure adjust log messages - remove single quote in log use getById instead of get
          Wadeck Follonier made changes -
          Remote Link New: This issue links to "#1202 (Web Link)" [ 17947 ]

            wfollonier Wadeck Follonier
            jglick Jesse Glick
            Votes:
            2 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: