Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-27722

upgrade to the release plugin has left the plugin broken

      I cloned the release plugin repo from github to customize the plugin. The plugin when packaged on local machine it does a successful package but when the hpi package is uploaded to jenkins server the release button on the left panel is not showing up. When I checked out the older branch from the repository the plugin works perfectly fine. May be the recent changes is failing the plugin.

          [JENKINS-27722] upgrade to the release plugin has left the plugin broken

          Glen Ritchie added a comment -

          Sorry was away will try to get to it today

          Glen Ritchie added a comment - Sorry was away will try to get to it today

          Code changed in jenkins
          User: Glen Ritchie
          Path:
          src/main/java/hudson/plugins/release/ReleaseWrapper.java
          src/main/java/hudson/plugins/release/ReleaseWrapperHelper.java
          src/main/resources/hudson/plugins/release/ReleaseWrapper/config.jelly
          http://jenkins-ci.org/commit/release-plugin/2ce0bdef5798ba0a44580d1c6e90aba5089154f1
          Log:
          Fix 'instance' being null when creating a new item.

          See also: https://issues.jenkins-ci.org/browse/JENKINS-27722

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Glen Ritchie Path: src/main/java/hudson/plugins/release/ReleaseWrapper.java src/main/java/hudson/plugins/release/ReleaseWrapperHelper.java src/main/resources/hudson/plugins/release/ReleaseWrapper/config.jelly http://jenkins-ci.org/commit/release-plugin/2ce0bdef5798ba0a44580d1c6e90aba5089154f1 Log: Fix 'instance' being null when creating a new item. See also: https://issues.jenkins-ci.org/browse/JENKINS-27722

          Code changed in jenkins
          User: Glen Ritchie
          Path:
          src/main/java/hudson/plugins/release/ReleaseWrapper.java
          src/main/java/hudson/plugins/release/ReleaseWrapperHelper.java
          src/main/resources/hudson/plugins/release/ReleaseWrapper/config.jelly
          src/test/java/hudson/plugins/release/TestReleasePlugin.java
          src/test/java/hudson/plugins/release/TestReleasePluginJob.java
          http://jenkins-ci.org/commit/release-plugin/fad26eec745cb1921844b2b5656346cceab625c5
          Log:
          Merge branch 'JENKINS-27722'

          Fixes JENKINS-27722 ( https://issues.jenkins-ci.org/browse/JENKINS-27722
          ) and adds numerous unit tests to ensure the plugin loads correctly and
          also tests that the plugin shows the "Release" text when enabled on a
          project.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Glen Ritchie Path: src/main/java/hudson/plugins/release/ReleaseWrapper.java src/main/java/hudson/plugins/release/ReleaseWrapperHelper.java src/main/resources/hudson/plugins/release/ReleaseWrapper/config.jelly src/test/java/hudson/plugins/release/TestReleasePlugin.java src/test/java/hudson/plugins/release/TestReleasePluginJob.java http://jenkins-ci.org/commit/release-plugin/fad26eec745cb1921844b2b5656346cceab625c5 Log: Merge branch ' JENKINS-27722 ' Fixes JENKINS-27722 ( https://issues.jenkins-ci.org/browse/JENKINS-27722 ) and adds numerous unit tests to ensure the plugin loads correctly and also tests that the plugin shows the "Release" text when enabled on a project.

          Code changed in jenkins
          User: Bulat Shakirzyanov
          Path:
          src/main/java/hudson/plugins/release/ReleaseWrapper.java
          src/main/java/hudson/plugins/release/ReleaseWrapperHelper.java
          src/main/resources/hudson/plugins/release/ReleaseWrapper/config.jelly
          src/test/java/hudson/plugins/release/TestReleasePlugin.java
          src/test/java/hudson/plugins/release/TestReleasePluginJob.java
          http://jenkins-ci.org/commit/release-plugin/cea8bb484c016670b5f248083c20929f1bbe1a88
          Log:
          Merge pull request #12 from glenritchie/master

          JENKINS-27722 - fix for previous merge that could stop plugin working on some jobs

          Compare: https://github.com/jenkinsci/release-plugin/compare/54a13e3f7af9...cea8bb484c01

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bulat Shakirzyanov Path: src/main/java/hudson/plugins/release/ReleaseWrapper.java src/main/java/hudson/plugins/release/ReleaseWrapperHelper.java src/main/resources/hudson/plugins/release/ReleaseWrapper/config.jelly src/test/java/hudson/plugins/release/TestReleasePlugin.java src/test/java/hudson/plugins/release/TestReleasePluginJob.java http://jenkins-ci.org/commit/release-plugin/cea8bb484c016670b5f248083c20929f1bbe1a88 Log: Merge pull request #12 from glenritchie/master JENKINS-27722 - fix for previous merge that could stop plugin working on some jobs Compare: https://github.com/jenkinsci/release-plugin/compare/54a13e3f7af9...cea8bb484c01

          It was a simple permission issue for me. If auth is enabled check if you have release permissions.

          Pramod Shivale added a comment - It was a simple permission issue for me. If auth is enabled check if you have release permissions.

          If that's the point then calling the url directly should not work.
          And a little mentioning in the release notes would be nice.

          Daniel Geißler added a comment - If that's the point then calling the url directly should not work. And a little mentioning in the release notes would be nice.

          Richard Otter added a comment - - edited

          My security setting has always been "logged in users can do anything". Updating to Release 2.5.3 cause Release link to be missing. After reading the above, I switched security to "Anyone can do Anything" and the link reappeared.

          I switched the sec setting back again and the link was gone again. It looks like I'll need to change the setting for every Release build until it's fixed.
          Jenkins v1.609.1, Java 1.8 u45 x64 on Windows server.

          Just saw the workaround in report-
          JENKINS-28132
          It uses a hidden group named authenticated. I was worried that I was going to lock myself out of the server when I tried it, but it worked.

          Richard Otter added a comment - - edited My security setting has always been "logged in users can do anything". Updating to Release 2.5.3 cause Release link to be missing. After reading the above, I switched security to "Anyone can do Anything" and the link reappeared. I switched the sec setting back again and the link was gone again. It looks like I'll need to change the setting for every Release build until it's fixed. Jenkins v1.609.1, Java 1.8 u45 x64 on Windows server. Just saw the workaround in report- JENKINS-28132 It uses a hidden group named authenticated. I was worried that I was going to lock myself out of the server when I tried it, but it worked.

          dma_k added a comment -

          I have the same issue with Release Plugin v2.6.1. I use "Logged-in users can do anything" authorization mode and "Matrix-based security" is not an option for me.
          ricko: What is the workaround? Enable matrix and tick all checkboxes, save, and then switch back to "Logged-in users can do anything"?

          dma_k added a comment - I have the same issue with Release Plugin v2.6.1. I use "Logged-in users can do anything" authorization mode and "Matrix-based security" is not an option for me. ricko : What is the workaround? Enable matrix and tick all checkboxes, save, and then switch back to "Logged-in users can do anything"?

          Daniel Beck added a comment -

          Weird, 2.6 and up contain the fix for JENKINS-28132 which should result in all administrators getting release permssion. Did you forget to restart Jenkins?

          Daniel Beck added a comment - Weird, 2.6 and up contain the fix for JENKINS-28132 which should result in all administrators getting release permssion. Did you forget to restart Jenkins?

          dma_k added a comment -

          danielbeck: The situation is that I have installed Jenkins from scratch yesterday and installed Release Plugin on that fresh Jenkins instance. Of course I have restarted it to activate the plugin (among others), but this was not the upgrade of the plugin.
          This is what /jenkins/whoAmI shows:

          org.acegisecurity.providers.UsernamePasswordAuthenticationToken@23075750: Username: dma_k; Password: [PROTECTED]; Authenticated: true; Details: null; Granted Authorities: authenticated
          

          dma_k added a comment - danielbeck : The situation is that I have installed Jenkins from scratch yesterday and installed Release Plugin on that fresh Jenkins instance. Of course I have restarted it to activate the plugin (among others), but this was not the upgrade of the plugin. This is what /jenkins/whoAmI shows: org.acegisecurity.providers.UsernamePasswordAuthenticationToken@23075750: Username: dma_k; Password: [PROTECTED]; Authenticated: true ; Details: null ; Granted Authorities: authenticated

            petehayes Peter Hayes
            hshah Harsh Shah
            Votes:
            3 Vote for this issue
            Watchers:
            12 Start watching this issue

              Created:
              Updated: