Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28227

RunTest#getDurationString fails on non-english environments.

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None
    • Jenkins 1.611
      jdk1.7.0_45
      Windows 8 64bits

      Running hudson.model.RunTest
      Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.39 sec <<< FAILURE! - in hudson.model.RunTest
      getDurationString(hudson.model.RunTest)  Time elapsed: 0.312 sec  <<< FAILURE!
      java.lang.AssertionError: 0 ms 以上
              at org.junit.Assert.fail(Assert.java:88)
              at org.junit.Assert.assertTrue(Assert.java:41)
              at hudson.model.RunTest.getDurationString(RunTest.java:126)
      

      This expects "0 ms and continuing", but actually gets "0 ms 以上" (a Japanese text) in my environment.

          [JENKINS-28227] RunTest#getDurationString fails on non-english environments.

          ikedam added a comment -

          ikedam added a comment - https://github.com/jenkinsci/jenkins/pull/1686

          Code changed in jenkins
          User: ikedam
          Path:
          core/src/test/java/hudson/model/RunTest.java
          http://jenkins-ci.org/commit/jenkins/3e38a509c5aa014cefa8fb2270c04c0531d32164
          Log:
          [FIXED JENKINS-28227] Switch to Enblish locale in RunTest#getDurationString to test messages.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: core/src/test/java/hudson/model/RunTest.java http://jenkins-ci.org/commit/jenkins/3e38a509c5aa014cefa8fb2270c04c0531d32164 Log: [FIXED JENKINS-28227] Switch to Enblish locale in RunTest#getDurationString to test messages.

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/test/java/hudson/model/RunTest.java
          http://jenkins-ci.org/commit/jenkins/efe1f3b9151c7a965ed1c9681683698664bd7292
          Log:
          Merge pull request #1686 from ikedam/feature/JENKINS-28227_fixGetDurationStringTest

          [FIXED JENKINS-28227] Switch to Enblish locale in RunTest#getDurationString to test messages.

          Compare: https://github.com/jenkinsci/jenkins/compare/f728da2bb349...efe1f3b9151c

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/test/java/hudson/model/RunTest.java http://jenkins-ci.org/commit/jenkins/efe1f3b9151c7a965ed1c9681683698664bd7292 Log: Merge pull request #1686 from ikedam/feature/ JENKINS-28227 _fixGetDurationStringTest [FIXED JENKINS-28227] Switch to Enblish locale in RunTest#getDurationString to test messages. Compare: https://github.com/jenkinsci/jenkins/compare/f728da2bb349...efe1f3b9151c

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4132
          [FIXED JENKINS-28227] Switch to Enblish locale in RunTest#getDurationString to test messages. (Revision 3e38a509c5aa014cefa8fb2270c04c0531d32164)

          Result = SUCCESS
          devld : 3e38a509c5aa014cefa8fb2270c04c0531d32164
          Files :

          • core/src/test/java/hudson/model/RunTest.java

          dogfood added a comment - Integrated in jenkins_main_trunk #4132 [FIXED JENKINS-28227] Switch to Enblish locale in RunTest#getDurationString to test messages. (Revision 3e38a509c5aa014cefa8fb2270c04c0531d32164) Result = SUCCESS devld : 3e38a509c5aa014cefa8fb2270c04c0531d32164 Files : core/src/test/java/hudson/model/RunTest.java

          Code changed in jenkins
          User: tfennelly
          Path:
          CONTRIBUTING.md
          README.md
          changelog.html
          cli/pom.xml
          core/pom.xml
          core/src/main/java/hudson/model/AbstractBuild.java
          core/src/main/java/hudson/model/Computer.java
          core/src/main/java/hudson/model/Descriptor.java
          core/src/main/java/hudson/model/Fingerprint.java
          core/src/main/java/hudson/model/FingerprintMap.java
          core/src/main/java/hudson/model/LoadStatistics.java
          core/src/main/java/hudson/model/Run.java
          core/src/main/java/hudson/slaves/CommandLauncher.java
          core/src/main/java/hudson/slaves/OfflineCause.java
          core/src/main/java/hudson/slaves/SlaveComputer.java
          core/src/main/java/hudson/tasks/Maven.java
          core/src/main/java/hudson/tools/DownloadFromUrlInstaller.java
          core/src/main/java/hudson/util/ConsistentHash.java
          core/src/main/java/hudson/util/KeyedDataStorage.java
          core/src/main/java/hudson/util/MaskingClassLoader.java
          core/src/main/java/jenkins/model/FingerprintFacet.java
          core/src/main/java/jenkins/mvn/GlobalSettingsProvider.java
          core/src/main/java/jenkins/security/RSAConfidentialKey.java
          core/src/main/java/jenkins/security/RSADigitalSignatureConfidentialKey.java
          core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol.java
          core/src/main/resources/hudson/slaves/OfflineCause/cause.jelly
          core/src/main/resources/hudson/slaves/SlaveComputer/slave-agent.jnlp.jelly
          core/src/main/resources/lib/form/class-entry.jelly
          core/src/main/resources/lib/form/hetero-list/hetero-list.js
          core/src/test/groovy/jenkins/security/RSAConfidentialKeyTest.groovy
          core/src/test/groovy/jenkins/security/RSADigitalSignatureConfidentialKeyTest.groovy
          core/src/test/java/hudson/model/RunTest.java
          core/src/test/java/hudson/util/ConsistentHashTest.java
          plugins/pom.xml
          pom.xml
          test/pom.xml
          test/src/test/java/hudson/ClassicPluginStrategyTest.java
          test/src/test/java/hudson/model/ComputerTest.java
          test/src/test/java/hudson/model/DescriptorTest.java
          test/src/test/java/hudson/model/FreestyleJobPublisherTest.java
          test/src/test/java/hudson/model/NodeTest.java
          test/src/test/java/hudson/model/utils/AbortExceptionPublisher.java
          test/src/test/java/hudson/model/utils/IOExceptionPublisher.java
          test/src/test/java/hudson/model/utils/ResultWriterPublisher.java
          test/src/test/java/hudson/model/utils/TrueFalsePublisher.java
          test/src/test/java/hudson/slaves/CommandLauncherTest.java
          test/src/test/java/hudson/tasks/MavenTest.java
          test/src/test/java/hudson/util/ArgumentListBuilder2Test.java
          test/src/test/java/hudson/util/EchoCommand.java
          test/src/test/resources/hudson/ClassicPluginStrategyTest/testMaskResourceClassLoader.zip
          test/src/test/resources/hudson/model/DescriptorTest/B1/config.jelly
          test/src/test/resources/hudson/model/DescriptorTest/B2/config.jelly
          test/src/test/resources/hudson/model/DescriptorTest/D1/config.jelly
          test/src/test/resources/hudson/model/DescriptorTest/D2/config.jelly
          test/src/test/resources/hudson/model/DescriptorTest/D3/config.jelly
          war/pom.xml
          http://jenkins-ci.org/commit/jenkins/2c6bc734b741ab18631973ecd9722322b22616ca
          Log:
          Merge branch 'master' into extensionlist-listener

          • master: (61 commits)
            JENKINS-28384 Noting merge of #1700.
            update changelog: PR 1682 -> issue 28233, fix markup issue
            Remove duplicated 1.613 section from changelog
            [FIXED JENKINS-28384] NPE when Node.toComputer → null.
            Refactor fingerprint classes: Javadoc and annotations
            fixup ce747f942c3502f3dc93b69079b4786ceb38fe86
            Refactor ArgumentListBuilder#toWindowsCommand
            Improve ArgumentListBuilder#toWindowsCommand test coverage
            Forgotten @Test annotation
            updated changelog for release
            updated changelog for release
            [maven-release-plugin] prepare release jenkins-1.613
            [maven-release-plugin] prepare for next development iteration
            Report launcher exited before establishing the channel
            Remove erroneous '+ ' from log message.
            Increase visibility of Java 7 requirement
            Expose SlaveComputer#getLogDir() explicitly
            [FIXED JENKINS-28227] Switch to Enblish locale in RunTest#getDurationString to test messages.
            Noting #1591
            Noting #1682
            ...

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: CONTRIBUTING.md README.md changelog.html cli/pom.xml core/pom.xml core/src/main/java/hudson/model/AbstractBuild.java core/src/main/java/hudson/model/Computer.java core/src/main/java/hudson/model/Descriptor.java core/src/main/java/hudson/model/Fingerprint.java core/src/main/java/hudson/model/FingerprintMap.java core/src/main/java/hudson/model/LoadStatistics.java core/src/main/java/hudson/model/Run.java core/src/main/java/hudson/slaves/CommandLauncher.java core/src/main/java/hudson/slaves/OfflineCause.java core/src/main/java/hudson/slaves/SlaveComputer.java core/src/main/java/hudson/tasks/Maven.java core/src/main/java/hudson/tools/DownloadFromUrlInstaller.java core/src/main/java/hudson/util/ConsistentHash.java core/src/main/java/hudson/util/KeyedDataStorage.java core/src/main/java/hudson/util/MaskingClassLoader.java core/src/main/java/jenkins/model/FingerprintFacet.java core/src/main/java/jenkins/mvn/GlobalSettingsProvider.java core/src/main/java/jenkins/security/RSAConfidentialKey.java core/src/main/java/jenkins/security/RSADigitalSignatureConfidentialKey.java core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol.java core/src/main/resources/hudson/slaves/OfflineCause/cause.jelly core/src/main/resources/hudson/slaves/SlaveComputer/slave-agent.jnlp.jelly core/src/main/resources/lib/form/class-entry.jelly core/src/main/resources/lib/form/hetero-list/hetero-list.js core/src/test/groovy/jenkins/security/RSAConfidentialKeyTest.groovy core/src/test/groovy/jenkins/security/RSADigitalSignatureConfidentialKeyTest.groovy core/src/test/java/hudson/model/RunTest.java core/src/test/java/hudson/util/ConsistentHashTest.java plugins/pom.xml pom.xml test/pom.xml test/src/test/java/hudson/ClassicPluginStrategyTest.java test/src/test/java/hudson/model/ComputerTest.java test/src/test/java/hudson/model/DescriptorTest.java test/src/test/java/hudson/model/FreestyleJobPublisherTest.java test/src/test/java/hudson/model/NodeTest.java test/src/test/java/hudson/model/utils/AbortExceptionPublisher.java test/src/test/java/hudson/model/utils/IOExceptionPublisher.java test/src/test/java/hudson/model/utils/ResultWriterPublisher.java test/src/test/java/hudson/model/utils/TrueFalsePublisher.java test/src/test/java/hudson/slaves/CommandLauncherTest.java test/src/test/java/hudson/tasks/MavenTest.java test/src/test/java/hudson/util/ArgumentListBuilder2Test.java test/src/test/java/hudson/util/EchoCommand.java test/src/test/resources/hudson/ClassicPluginStrategyTest/testMaskResourceClassLoader.zip test/src/test/resources/hudson/model/DescriptorTest/B1/config.jelly test/src/test/resources/hudson/model/DescriptorTest/B2/config.jelly test/src/test/resources/hudson/model/DescriptorTest/D1/config.jelly test/src/test/resources/hudson/model/DescriptorTest/D2/config.jelly test/src/test/resources/hudson/model/DescriptorTest/D3/config.jelly war/pom.xml http://jenkins-ci.org/commit/jenkins/2c6bc734b741ab18631973ecd9722322b22616ca Log: Merge branch 'master' into extensionlist-listener master: (61 commits) JENKINS-28384 Noting merge of #1700. update changelog: PR 1682 -> issue 28233, fix markup issue Remove duplicated 1.613 section from changelog [FIXED JENKINS-28384] NPE when Node.toComputer → null. Refactor fingerprint classes: Javadoc and annotations fixup ce747f942c3502f3dc93b69079b4786ceb38fe86 Refactor ArgumentListBuilder#toWindowsCommand Improve ArgumentListBuilder#toWindowsCommand test coverage Forgotten @Test annotation updated changelog for release updated changelog for release [maven-release-plugin] prepare release jenkins-1.613 [maven-release-plugin] prepare for next development iteration Report launcher exited before establishing the channel Remove erroneous '+ ' from log message. Increase visibility of Java 7 requirement Expose SlaveComputer#getLogDir() explicitly [FIXED JENKINS-28227] Switch to Enblish locale in RunTest#getDurationString to test messages. Noting #1591 Noting #1682 ...

            ikedam ikedam
            ikedam ikedam
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: