Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28796

Support shading in maven-hpi plugin

XMLWordPrintable

      Just a follow-up to the discussion in https://github.com/jenkinsci/docker-traceability-plugin/pull/18

      Here are more details about the HPI and shade Maven plugins incompatibility : http://echelog.com/logs/browse/jenkins/1427839200

      Arnaud has already discussed with integer who reported the issue and asked for some help to fix it but for now I did found the time to do it. Here is the feedback he gave regarding the issue :

      The issue is that it ignores any package phase bindings and packages jars with hardcoded jar archiver. Jenkins has many issues because of classloader and it will be very convenient to have ability to execute shad-plugin directly from hpi packaging. If packaging is jar, then maven-jar-plugin executes fine maven-shade-plugin. So my idea was to remove hardcoded jar archiver from hpi plugin and give it to maven-jar. https://github.com/jenkinsci/maven-hpi-plugin/blob/ded54b3ac24035ebacda64a0900c3dea5e3de852/src/main/java/org/jenkinsci/maven/plugins/hpi/HpiMojo.java#L122-L131

          [JENKINS-28796] Support shading in maven-hpi plugin

          Oleg Nenashev created issue -
          Oleg Nenashev made changes -
          Link New: This issue is related to JENKINS-28932 [ JENKINS-28932 ]
          Kanstantsin Shautsou made changes -
          Link New: This issue is blocking JENKINS-23794 [ JENKINS-23794 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 163654 ] New: JNJira + In-Review [ 181325 ]
          Arnaud Héritier made changes -
          Assignee Original: Arnaud Héritier [ aheritier ]

            Unassigned Unassigned
            oleg_nenashev Oleg Nenashev
            Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: