Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29765

Build Retry (both Naginator and Rebuild) pick the latest commit, not retrying one

    XMLWordPrintable

    Details

    • Type: New Feature
    • Status: Open (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Labels:
      None
    • Environment:
    • Similar Issues:

      Description

      This is easily reproduced on a standalone Cent 6 or Cent 7 machine.

      Create a job:

      • Uses Git
      • A trivial build step that fails, "false" or "exit 1" in the shell build-step for example
      • Uses one of the above retry mechanisms (Naginator or Rebuilder)
      • In the case of Naginator, stub it with a regex to keep it from automatically retrying
      • In the case of Rebuilder, enable the rebuild without parameters
      • Make a commit and run a build. It should fail. Note Git SHA (This is build #1)
      • Make a second commit, then build it. It should also fail. Note the Git SHA (This is build #2)
      • Now go back to build #1 and retrigger it. (build #3)

      Expectation:

      The retriggered build (build #3) should use the same Git SHA as build #1.

      Observed problem:

      The Git SHA is the HEAD of the branch at the time of the retrigger.

        Attachments

          Activity

          eegah Eric Griswold created issue -
          eegah Eric Griswold made changes -
          Field Original Value New Value
          Description This is easily reproduced on a standalone Cent 6 or Cent 7 machine.

          Create a job:
          * Uses Git
          * A trivial build step that fails, "false" or "exit 1" in the shell build-step for example
          * Uses one of the above retry mechanisms (Naginator or Rebuilder)
          * In the case of Naginator, stub it with a regex to keep it from automatically retrying
          * In the case of Rebuilder, enable the rebuild without parameters
          * Commit and run a build. It should fail. Note Git SHA (This is build #1)
          * Make a second build and run it. It should also fail. Note the Git SHA (This is build #2)
          * Now go back to build #1 and retrigger it.

          My expectation is that the retriggered build should have the same Git SHA as build #1. When I try it, the Git SHA is the HEAD of the branch at the time of the retrigger.
          This is easily reproduced on a standalone Cent 6 or Cent 7 machine.

          Create a job:
          * Uses Git
          * A trivial build step that fails, "false" or "exit 1" in the shell build-step for example
          * Uses one of the above retry mechanisms (Naginator or Rebuilder)
          * In the case of Naginator, stub it with a regex to keep it from automatically retrying
          * In the case of Rebuilder, enable the rebuild without parameters
          * Commit and run a build. It should fail. Note Git SHA (This is build #1)
          * Make a second build and run it. It should also fail. Note the Git SHA (This is build #2)
          * Now go back to build #1 and retrigger it. (build #3)

          Expectation:

          The retriggered build (build #3) should have the same Git SHA as build #1.

          Observed problem:

          The Git SHA is the HEAD of the branch at the time of the retrigger.
          eegah Eric Griswold made changes -
          Description This is easily reproduced on a standalone Cent 6 or Cent 7 machine.

          Create a job:
          * Uses Git
          * A trivial build step that fails, "false" or "exit 1" in the shell build-step for example
          * Uses one of the above retry mechanisms (Naginator or Rebuilder)
          * In the case of Naginator, stub it with a regex to keep it from automatically retrying
          * In the case of Rebuilder, enable the rebuild without parameters
          * Commit and run a build. It should fail. Note Git SHA (This is build #1)
          * Make a second build and run it. It should also fail. Note the Git SHA (This is build #2)
          * Now go back to build #1 and retrigger it. (build #3)

          Expectation:

          The retriggered build (build #3) should have the same Git SHA as build #1.

          Observed problem:

          The Git SHA is the HEAD of the branch at the time of the retrigger.
          This is easily reproduced on a standalone Cent 6 or Cent 7 machine.

          Create a job:
          * Uses Git
          * A trivial build step that fails, "false" or "exit 1" in the shell build-step for example
          * Uses one of the above retry mechanisms (Naginator or Rebuilder)
          * In the case of Naginator, stub it with a regex to keep it from automatically retrying
          * In the case of Rebuilder, enable the rebuild without parameters
          * Make a commit and run a build. It should fail. Note Git SHA (This is build #1)
          * Make a second commit, then build it. It should also fail. Note the Git SHA (This is build #2)
          * Now go back to build #1 and retrigger it. (build #3)

          Expectation:

          The retriggered build (build #3) should have the same Git SHA as build #1.

          Observed problem:

          The Git SHA is the HEAD of the branch at the time of the retrigger.
          eegah Eric Griswold made changes -
          Description This is easily reproduced on a standalone Cent 6 or Cent 7 machine.

          Create a job:
          * Uses Git
          * A trivial build step that fails, "false" or "exit 1" in the shell build-step for example
          * Uses one of the above retry mechanisms (Naginator or Rebuilder)
          * In the case of Naginator, stub it with a regex to keep it from automatically retrying
          * In the case of Rebuilder, enable the rebuild without parameters
          * Make a commit and run a build. It should fail. Note Git SHA (This is build #1)
          * Make a second commit, then build it. It should also fail. Note the Git SHA (This is build #2)
          * Now go back to build #1 and retrigger it. (build #3)

          Expectation:

          The retriggered build (build #3) should have the same Git SHA as build #1.

          Observed problem:

          The Git SHA is the HEAD of the branch at the time of the retrigger.
          This is easily reproduced on a standalone Cent 6 or Cent 7 machine.

          Create a job:
          * Uses Git
          * A trivial build step that fails, "false" or "exit 1" in the shell build-step for example
          * Uses one of the above retry mechanisms (Naginator or Rebuilder)
          * In the case of Naginator, stub it with a regex to keep it from automatically retrying
          * In the case of Rebuilder, enable the rebuild without parameters
          * Make a commit and run a build. It should fail. Note Git SHA (This is build #1)
          * Make a second commit, then build it. It should also fail. Note the Git SHA (This is build #2)
          * Now go back to build #1 and retrigger it. (build #3)

          Expectation:

          The retriggered build (build #3) should use the same Git SHA as build #1.

          Observed problem:

          The Git SHA is the HEAD of the branch at the time of the retrigger.
          xjom Mattias Vannergård made changes -
          Component/s git-plugin [ 15543 ]
          xjom Mattias Vannergård made changes -
          Environment Standalone CentOS 7 machine. Jenkins 1.622; Git plugin 2.4.0; Naginator 1.15; rebuilder 1.25

          Replicated on a CentOS 6 machine. Jenkins 1.580.3; Git plugin 2.3.5; Naginator 1.14; Rebuilder 1.22
          Standalone CentOS 7 machine. Jenkins 1.622; Git plugin 2.4.0; Naginator 1.15; rebuilder 1.25

          Replicated on a CentOS 6 machine. Jenkins 1.580.3; Git plugin 2.3.5; Naginator 1.14; Rebuilder 1.22

          Replicated on a Win 7 machine. Jenkins 1.596.2; Git plugin 2.4.0; Gerrit plugin 2.16.0; Rebuilder 1.25 (I do have Naginator 1.15 installed, but it is not involved in this job)
          markewaite Mark Waite made changes -
          Component/s git-plugin [ 15543 ]
          Component/s core [ 15593 ]
          xjom Mattias Vannergård made changes -
          Component/s gerrit-trigger-plugin [ 15731 ]
          Component/s git-plugin [ 15543 ]
          markewaite Mark Waite made changes -
          Component/s git-plugin [ 15543 ]
          markewaite Mark Waite made changes -
          Assignee Nicolas De Loof [ ndeloof ]
          xjom Mattias Vannergård made changes -
          Component/s gerrit-trigger-plugin [ 15731 ]
          ikedam ikedam made changes -
          Component/s git-plugin [ 15543 ]
          Issue Type Bug [ 1 ] New Feature [ 2 ]
          Summary Build Retry (both Naginator and Rebuild) pick wrong Git SHA under certain circumstances Build Retry (both Naginator and Rebuild) pick the latest commit, not retrying one
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 164841 ] JNJira + In-Review [ 181706 ]
          mingfan ming fan made changes -
          Environment Standalone CentOS 7 machine. Jenkins 1.622; Git plugin 2.4.0; Naginator 1.15; rebuilder 1.25

          Replicated on a CentOS 6 machine. Jenkins 1.580.3; Git plugin 2.3.5; Naginator 1.14; Rebuilder 1.22

          Replicated on a Win 7 machine. Jenkins 1.596.2; Git plugin 2.4.0; Gerrit plugin 2.16.0; Rebuilder 1.25 (I do have Naginator 1.15 installed, but it is not involved in this job)
          Standalone CentOS 7 machine. Jenkins 1.622; Git plugin 2.4.0; Naginator 1.15; rebuilder 1.25

          Replicated on a CentOS 6 machine. Jenkins 1.580.3; Git plugin 2.3.5; Naginator 1.14; Rebuilder 1.22

          Replicated on a Win 7 machine. Jenkins 1.596.2; Git plugin 2.4.0; Gerrit plugin 2.16.0; Rebuilder 1.25 (I do have Naginator 1.15 installed, but it is not involved in this job)

          Replicated on amazon-linux-ami 2017.03.
          mingfan ming fan made changes -
          Environment Standalone CentOS 7 machine. Jenkins 1.622; Git plugin 2.4.0; Naginator 1.15; rebuilder 1.25

          Replicated on a CentOS 6 machine. Jenkins 1.580.3; Git plugin 2.3.5; Naginator 1.14; Rebuilder 1.22

          Replicated on a Win 7 machine. Jenkins 1.596.2; Git plugin 2.4.0; Gerrit plugin 2.16.0; Rebuilder 1.25 (I do have Naginator 1.15 installed, but it is not involved in this job)

          Replicated on amazon-linux-ami 2017.03.
          Standalone CentOS 7 machine. Jenkins 1.622; Git plugin 2.4.0; Naginator 1.15; rebuilder 1.25

          Replicated on a CentOS 6 machine. Jenkins 1.580.3; Git plugin 2.3.5; Naginator 1.14; Rebuilder 1.22

          Replicated on a Win 7 machine. Jenkins 1.596.2; Git plugin 2.4.0; Gerrit plugin 2.16.0; Rebuilder 1.25 (I do have Naginator 1.15 installed, but it is not involved in this job)

          Replicated on amazon-linux-ami 2017.03. Jenkins ver. 2.77

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            eegah Eric Griswold
            Votes:
            13 Vote for this issue
            Watchers:
            14 Start watching this issue

              Dates

              Created:
              Updated: