Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29979

Workflow plugin unable to save perforce paramters

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • p4-plugin
    • windows 7, workflow-plugin 1.9, p4 Plugin 1.2.5., Perforce Plugin 1.3.35

      Perforce parameters aren't persisted across saves of a job using the using the workflow plugin. See attached screen shots for the steps to add perforce settings.

      1. Select the perforce for SCM. attachment 1
      2. Configure perforce. attachement 2
      3. Save the job.
      4. Look at the saved values. attachement 3

      The perforce settings are lost and only Git is visible for selection.

          [JENKINS-29979] Workflow plugin unable to save perforce paramters

          Paul Allen added a comment -

          Thank you Kyle for offering to help; there is a fair amount of development work to do, so it will be a few weeks before I have a SNAPSHOT release for you to test. I will let you know as soon as the dev work is done.

          Paul Allen added a comment - Thank you Kyle for offering to help; there is a fair amount of development work to do, so it will be a few weeks before I have a SNAPSHOT release for you to test. I will let you know as soon as the dev work is done.

          Allan BURDAJEWICZ added a comment - I proposed a PR for this: https://github.com/jenkinsci/p4-plugin/pull/23

          Jesse Glick added a comment -

          Should not have been visible in step 1 to begin with. Perhaps the original report included an old build of Pipeline still suffering from JENKINS-28756.

          Jesse Glick added a comment - Should not have been visible in step 1 to begin with. Perhaps the original report included an old build of Pipeline still suffering from JENKINS-28756 .

          Code changed in jenkins
          User: Allan Burdajewicz
          Path:
          src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java
          http://jenkins-ci.org/commit/p4-plugin/fd99f98f03ab55f99fac13af6241deee37a27f3d
          Log:
          JENKINS-29979: Override isApplicable for Pipeline compatibility

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Allan Burdajewicz Path: src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java http://jenkins-ci.org/commit/p4-plugin/fd99f98f03ab55f99fac13af6241deee37a27f3d Log: JENKINS-29979 : Override isApplicable for Pipeline compatibility

          Code changed in jenkins
          User: Paul Allen
          Path:
          src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java
          http://jenkins-ci.org/commit/p4-plugin/1bb9f35103e61e37b6beeb954c1cffd7b880cf0c
          Log:
          Merge pull request #23 from Dohbedoh/JENKINS-29979

          JENKINS-29979: Override isApplicable for Pipeline compatibility

          Compare: https://github.com/jenkinsci/p4-plugin/compare/8fec9bf1714c...1bb9f35103e6

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Paul Allen Path: src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java http://jenkins-ci.org/commit/p4-plugin/1bb9f35103e61e37b6beeb954c1cffd7b880cf0c Log: Merge pull request #23 from Dohbedoh/ JENKINS-29979 JENKINS-29979 : Override isApplicable for Pipeline compatibility Compare: https://github.com/jenkinsci/p4-plugin/compare/8fec9bf1714c...1bb9f35103e6

          Built from bebc56d8b560728b07edeb3572ccd172c831c5ba and that works for me.

          It also seems that the snippet generator can now generate a checkout step for p4 (which is good). Is that an expected effect of this change?

          Russell Gallop added a comment - Built from bebc56d8b560728b07edeb3572ccd172c831c5ba and that works for me. It also seems that the snippet generator can now generate a checkout step for p4 (which is good). Is that an expected effect of this change?

          rg It is indeed an expected effect of this change. It needed to be made applicable for Job (see GenericSCMStep)

          Allan BURDAJEWICZ added a comment - rg It is indeed an expected effect of this change. It needed to be made applicable for Job (see GenericSCMStep )

          Thanks.

          Would it be possible to cut a release with this fix in? I think that this justifies it, particularly as the pipeline plugin fix (JENKINS-28756) could stop people creating pipelines jobs from p4 SCM altogether.

          Russell Gallop added a comment - Thanks. Would it be possible to cut a release with this fix in? I think that this justifies it, particularly as the pipeline plugin fix ( JENKINS-28756 ) could stop people creating pipelines jobs from p4 SCM altogether.

          Paul Allen added a comment -

          Sure, I'll try and get that out for early next week.

          Paul Allen added a comment - Sure, I'll try and get that out for early next week.

          Paul Allen added a comment -

          Released.

          Paul Allen added a comment - Released.

            p4paul Paul Allen
            csr_jenkins steve Childerley
            Votes:
            1 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: