Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30531

Define SCMRevisionAction from SCMBinder

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • pipeline

      SCMBinder currently uses some hacks to save an SCM object in the build. Perhaps it would be better to use SCMRevisionAction, which was intended for this purpose.

          [JENKINS-30531] Define SCMRevisionAction from SCMBinder

          Jesse Glick created issue -

          Jesse Glick added a comment -

          Possible this would be helpful in resolving JENKINS-30222.

          Jesse Glick added a comment - Possible this would be helpful in resolving JENKINS-30222 .
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-30222 [ JENKINS-30222 ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Jesse Glick made changes -
          Remote Link New: This issue links to "PR 239 (Web Link)" [ 13500 ]
          Jesse Glick made changes -
          Priority Original: Minor [ 4 ] New: Major [ 3 ]
          Jesse Glick made changes -
          Issue Type Original: Task [ 3 ] New: Improvement [ 4 ]
          Jesse Glick made changes -
          Summary Original: Consider using SCMRevisionAction from SCMBinder New: Define SCMRevisionAction from SCMBinder

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsScript.java
          multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinder.java
          multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMVar.java
          multibranch/src/main/resources/org/jenkinsci/plugins/workflow/multibranch/SCMVar/help.jelly
          multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinderTest.java
          http://jenkins-ci.org/commit/workflow-plugin/4e9bd117797620e2f11c03f4053e8210d3086eac
          Log:
          [FIXED JENKINS-30531] Set SCMRevisionAction when we do a build, so client code can get access to this record.
          Has the happy side effect of fixing JENKINS-30222: scm as a global variable can be used unqualified from library code.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsScript.java multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinder.java multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMVar.java multibranch/src/main/resources/org/jenkinsci/plugins/workflow/multibranch/SCMVar/help.jelly multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinderTest.java http://jenkins-ci.org/commit/workflow-plugin/4e9bd117797620e2f11c03f4053e8210d3086eac Log: [FIXED JENKINS-30531] Set SCMRevisionAction when we do a build, so client code can get access to this record. Has the happy side effect of fixing JENKINS-30222 : scm as a global variable can be used unqualified from library code.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsScript.java
          multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinder.java
          multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMVar.java
          multibranch/src/main/resources/org/jenkinsci/plugins/workflow/multibranch/SCMVar/help.jelly
          multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinderTest.java
          http://jenkins-ci.org/commit/workflow-plugin/46d63875dbaa218e9f23e9520cf5f1ed8f6a1c43
          Log:
          Merge pull request #239 from jglick/SCMRevisionAction-JENKINS-30531

          JENKINS-30531 Set SCMRevisionAction when we do a build

          Compare: https://github.com/jenkinsci/workflow-plugin/compare/59e6cf394ba7...46d63875dbaa

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsScript.java multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinder.java multibranch/src/main/java/org/jenkinsci/plugins/workflow/multibranch/SCMVar.java multibranch/src/main/resources/org/jenkinsci/plugins/workflow/multibranch/SCMVar/help.jelly multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/SCMBinderTest.java http://jenkins-ci.org/commit/workflow-plugin/46d63875dbaa218e9f23e9520cf5f1ed8f6a1c43 Log: Merge pull request #239 from jglick/SCMRevisionAction- JENKINS-30531 JENKINS-30531 Set SCMRevisionAction when we do a build Compare: https://github.com/jenkinsci/workflow-plugin/compare/59e6cf394ba7...46d63875dbaa

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: