Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30565

Jenkins should ask for confirmation before aborting a build

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      Jenkins does not ask for confirmation before aborting a build. Since this can cause significant harm in the case of long-running builds or builds with side effects (partial deployments etc.), this should be added to the abort functionality.

      Queued items can be parameterized or triggered in a way that makes them difficult to reproduce (actions added etc.) so those should probably be protected from accidentally canceling them as well.

          [JENKINS-30565] Jenkins should ask for confirmation before aborting a build

          Daniel Beck created issue -

          Probably the main issue that in highly active queue UI can send abort to wrong running job because of refresh rendering.

          Kanstantsin Shautsou added a comment - Probably the main issue that in highly active queue UI can send abort to wrong running job because of refresh rendering.

          Daniel Beck added a comment -

          True. Another reason for having this. That was actually the reason I went the extra inch and added the job name for queue items, and job name and build name for running builds, rather than just asking "Are you sure you want to abort?".

          Daniel Beck added a comment - True. Another reason for having this. That was actually the reason I went the extra inch and added the job name for queue items, and job name and build name for running builds, rather than just asking "Are you sure you want to abort?".

          Side effect is that if i mistakenly run build i want abort it very fast. And now i can do it.

          Kanstantsin Shautsou added a comment - Side effect is that if i mistakenly run build i want abort it very fast. And now i can do it.
          Kanstantsin Shautsou made changes -
          Remote Link New: This issue links to "jenkins/pull/1835 (Web Link)" [ 13157 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 165677 ] New: JNJira + In-Review [ 182084 ]

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/resources/hudson/widgets/BuildHistoryWidget/entries.properties
          core/src/main/resources/hudson/widgets/HistoryWidget/entry.jelly
          core/src/main/resources/hudson/widgets/HistoryWidget/entry.properties
          core/src/main/resources/lib/hudson/buildCaption.jelly
          core/src/main/resources/lib/hudson/buildCaption.properties
          core/src/main/resources/lib/hudson/executors.jelly
          core/src/main/resources/lib/hudson/executors.properties
          core/src/main/resources/lib/hudson/queue.jelly
          core/src/main/resources/lib/hudson/queue.properties
          core/src/main/resources/lib/layout/stopButton.jelly
          http://jenkins-ci.org/commit/jenkins/3af3a27116ccec048ce9eb61f947d74e0fe37611
          Log:
          [FIX JENKINS-30565] Ask for confirmation before canceling/aborting (#1835)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/hudson/widgets/BuildHistoryWidget/entries.properties core/src/main/resources/hudson/widgets/HistoryWidget/entry.jelly core/src/main/resources/hudson/widgets/HistoryWidget/entry.properties core/src/main/resources/lib/hudson/buildCaption.jelly core/src/main/resources/lib/hudson/buildCaption.properties core/src/main/resources/lib/hudson/executors.jelly core/src/main/resources/lib/hudson/executors.properties core/src/main/resources/lib/hudson/queue.jelly core/src/main/resources/lib/hudson/queue.properties core/src/main/resources/lib/layout/stopButton.jelly http://jenkins-ci.org/commit/jenkins/3af3a27116ccec048ce9eb61f947d74e0fe37611 Log: [FIX JENKINS-30565] Ask for confirmation before canceling/aborting (#1835)
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          Oleg Nenashev added a comment -

          The fix has been released in 2.21

          Oleg Nenashev added a comment - The fix has been released in 2.21

          Oleg Nenashev added a comment -

          danielbeck Is it something we want to have in 2.19.x LTS?

          Oleg Nenashev added a comment - danielbeck Is it something we want to have in 2.19.x LTS?

            danielbeck Daniel Beck
            danielbeck Daniel Beck
            Votes:
            3 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: