Details
-
Bug
-
Status: Resolved (View Workflow)
-
Minor
-
Resolution: Fixed
-
None
Description
This plugin is intended to run as post-build step. Exclude it from pre-build steps.
Attachments
Activity
Code changed in jenkins
User: Scott Hebert
Path:
src/main/java/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder.java
src/main/java/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher.java
src/main/resources/messages.properties
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/config.jelly
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/config.properties
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/help-category.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/help-changedLinesOnly.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/help-issueComment.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/help-issuesNotification.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/help-issuesScore.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/help-newIssuesOnly.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/help-noIssuesNotification.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/help-noIssuesScore.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/help-noIssuesToPostText.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/help-path.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/help-postScore.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/help-projectPath.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/help-severity.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/help-someIssuesToPostText.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/help-sonarURL.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher/config.jelly
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher/config.properties
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher/help-category.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher/help-changedLinesOnly.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher/help-issueComment.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher/help-issuesNotification.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher/help-issuesScore.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher/help-newIssuesOnly.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher/help-noIssuesNotification.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher/help-noIssuesScore.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher/help-noIssuesToPostText.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher/help-path.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher/help-postScore.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher/help-projectPath.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher/help-severity.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher/help-someIssuesToPostText.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher/help-sonarURL.html
src/test/java/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilderTest.java
src/test/java/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisherTest.java
http://jenkins-ci.org/commit/sonar-gerrit-plugin/dcdf88be5f84c62d6db24065a51b18970391c4d7
Log:
Convert from Build to Post-Build Step
The build step has now been refactored to be a post-build step.
This will help accomodate job configs where sonar analysis is only
performed as a post build step.
As well, some additional console logging was added.
Tobias Kilian
added a comment - Could you please allow Build Step and Post-Build Step?
I dont like being forced to have seperate Job definitions for patchset-created and change-merged events.
But afaik, i have to do different runs of sonar analysis (preview vs. full) depending on the gerrit event.
What i did before was using the conditional build steps plugin to run sonar one way or the other.
As posting events to gerrit only makes sense for patchset-crreated i would like to add the plugin to that conditional build step and was very sad to see that config vanished after upgrading to 1.0.5 ( pretty late, I know 
As that plugin is very nice and the only real option to force developers to investigate their sonar issues I would really like to keep using it..
Tobias Kilian
added a comment - Could you please allow Build Step and Post-Build Step?
I dont like being forced to have seperate Job definitions for patchset-created and change-merged events.
But afaik, i have to do different runs of sonar analysis (preview vs. full) depending on the gerrit event.
What i did before was using the conditional build steps plugin to run sonar one way or the other.
As posting events to gerrit only makes sense for patchset-crreated i would like to add the plugin to that conditional build step and was very sad to see that config vanished after upgrading to 1.0.5 ( pretty late, I know
As that plugin is very nice and the only real option to force developers to investigate their sonar issues I would really like to keep using it..
So the plan would be to make this a Post Build step and NOT a build step.
This makes sense since there is a SonarQube post build step that some people use.