Details
-
Improvement
-
Status: Resolved (View Workflow)
-
Minor
-
Resolution: Fixed
-
None
Description
sonar-gerrit plugin is unable to work if it is not allowed to use gerrit-trigger RestApi. It is necessary to add checking of this setting befor any actionas taken by plugin. Mark build as failed in case when gerrit-trigger RestAPI is not awailable.
Attachments
Activity
Code changed in jenkins
User: Tatiana Didik
Path:
src/main/java/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder.java
src/main/resources/messages.properties
http://jenkins-ci.org/commit/sonar-gerrit-plugin/55bd4639b5c9255e4fe3e008347f0e74d8ac4c7e
Log:
JENKINS-31004 - Check gerrit-trigger REST API settings before plugin execution
Code changed in jenkins
User: Tatiana Didik
Path:
src/main/java/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder.java
src/test/java/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilderTest.java
http://jenkins-ci.org/commit/sonar-gerrit-plugin/5588d421064ea76805024897496ce0e082ebf907
Log:
Merge branch 'JENKINS-31004'
Conflicts:
src/main/java/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder.java
src/test/java/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilderTest.java
Code changed in jenkins
User: Tatiana
Path:
src/main/java/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder.java
src/main/resources/messages.properties
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/config.jelly
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/config.properties
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/help-issuesNotification.html
src/main/resources/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilder/help-noIssuesNotification.html
src/test/java/org/jenkinsci/plugins/sonargerrit/SonarToGerritBuilderTest.java
http://jenkins-ci.org/commit/sonar-gerrit-plugin/a81eadc6232ae30573dc317dcc1a78f75bd477b4
Log:
Merge pull request #3 from aquarellian/master
JENKINS-31004 - Check gerrit-trigger REST API settings before plugin …
Compare: https://github.com/jenkinsci/sonar-gerrit-plugin/compare/2994332a46e6...a81eadc6232a
GerritHudsonTriggerConfig gerritConfig = GerritManagement.getConfig(gerritServerName);
return gerritConfig.isUseRestApi()