Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31591

MasterKillSwitchConfiguration is not available when you have clouds but no fixed slaves

XMLWordPrintable

      https://github.com/jenkinsci/jenkins/blob/7376aa0e292c5df6ec7dd46bf0e399d93911348e/core/src/main/java/jenkins/security/s2m/MasterKillSwitchConfiguration.java#L50 does not consider the case where you do not have any fixed slaves but you have at least one cloud that can provide slaves.

          [JENKINS-31591] MasterKillSwitchConfiguration is not available when you have clouds but no fixed slaves

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          core/src/main/java/jenkins/security/s2m/MasterKillSwitchConfiguration.java
          http://jenkins-ci.org/commit/jenkins/e8f2002c466c49eff4a7be0cc4633580515cd7a5
          Log:
          [FIXED JENKINS-31591] Correct MasterKillSwitchConfiguration visibility

          • The MasterKillSwitchConfiguration was not available when you have clouds but no fixed slaves.
          • The MasterKillSwitchConfiguration was not available when it was enabled but for a non-relevant configuration.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/jenkins/security/s2m/MasterKillSwitchConfiguration.java http://jenkins-ci.org/commit/jenkins/e8f2002c466c49eff4a7be0cc4633580515cd7a5 Log: [FIXED JENKINS-31591] Correct MasterKillSwitchConfiguration visibility The MasterKillSwitchConfiguration was not available when you have clouds but no fixed slaves. The MasterKillSwitchConfiguration was not available when it was enabled but for a non-relevant configuration.

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4371

          Result = SUCCESS

          dogfood added a comment - Integrated in jenkins_main_trunk #4371 Result = SUCCESS

          Jesse Glick added a comment -

          FWIW my suggestion in the PR for JENKINS-31596 is to just simplify things and show this switch unconditionally. What is the harm?

          Jesse Glick added a comment - FWIW my suggestion in the PR for JENKINS-31596 is to just simplify things and show this switch unconditionally. What is the harm?

          Jesse Glick added a comment -

          Probably only an LTS candidate in case the simplification in JENKINS-31596 is backported as well.

          Jesse Glick added a comment - Probably only an LTS candidate in case the simplification in JENKINS-31596 is backported as well.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          core/src/main/java/jenkins/security/s2m/MasterKillSwitchConfiguration.java
          http://jenkins-ci.org/commit/jenkins/67794d3bd4c50fe00732d05191226eb7038e434b
          Log:
          [FIXED JENKINS-31591] Correct MasterKillSwitchConfiguration visibility

          • The MasterKillSwitchConfiguration was not available when you have clouds but no fixed slaves.
          • The MasterKillSwitchConfiguration was not available when it was enabled but for a non-relevant configuration.

          (cherry picked from commit e8f2002c466c49eff4a7be0cc4633580515cd7a5)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/jenkins/security/s2m/MasterKillSwitchConfiguration.java http://jenkins-ci.org/commit/jenkins/67794d3bd4c50fe00732d05191226eb7038e434b Log: [FIXED JENKINS-31591] Correct MasterKillSwitchConfiguration visibility The MasterKillSwitchConfiguration was not available when you have clouds but no fixed slaves. The MasterKillSwitchConfiguration was not available when it was enabled but for a non-relevant configuration. (cherry picked from commit e8f2002c466c49eff4a7be0cc4633580515cd7a5)

            stephenconnolly Stephen Connolly
            stephenconnolly Stephen Connolly
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: