Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32209

NodeLabel parameter not working inside workflow

    XMLWordPrintable

Details

    Description

      1. Install the nodelabel parameter plugin, and workflow plugin
      2. create a workflow, with one string parameter (STRING_PARAM1), and one node parameter (NODE_PARAM1)
      3. create a workflow like this: 
        node {
   echo STRING_PARAM1
   echo NODE_PARAM1
}

      If you run this workflow, you will get an error:

      groovy.lang.MissingPropertyException: No such property: NODE_PARAM1 for class: WorkflowScript

      The problem is that the NodeLabel parameter plugin overrides buildEnvVars which was deprecated in Jenkins 1.344: see http://javadoc.jenkins-ci.org/hudson/model/ParameterValue.html#buildEnvVars%28hudson.model.AbstractBuild,%20java.util.Map%29

      It needs to override buildEnvironment(). This is similar to the problem in JENKINS-27718

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-32464 Label parameter used when called from a freestyle job, but not from a workflow

          • Major - Major loss of function.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-27718 Build parameter for "List Subversion Tags (and more)" is not exposed to workflow script.

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-26694 Workflow build Parameters are not exposed to CopyArtifact

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            rodrigc Craig Rodrigues created issue -
            rodrigc Craig Rodrigues made changes -
            Field Original Value New Value
            Link This issue is related to JENKINS-26694 [ JENKINS-26694 ]
            rodrigc Craig Rodrigues made changes -
            Description # Install the nodelabel parameter plugin, and workflow plugin
            # create a workflow, with one string parameter (STRING_PARAM1), and one node parameter (NODE_PARAM1)
            # create a workflow like this:
            {code}
            node {
               echo STRING_PARAM1
               echo NODE_PARAM1
            }
            {code}

            If you run this workflow, you will get an error:
            {code}
            groovy.lang.MissingPropertyException: No such property: NODE_PARAM1 for class: WorkflowScript
            {code}

            The problem is that the NodeLabel parameter plugin overrides buildEnvVars which was deprecated in Jenkins 1.344: see http://javadoc.jenkins-ci.org/hudson/model/ParameterValue.html#buildEnvVars%28hudson.model.AbstractBuild,%20java.util.Map%29
            		 # Install the nodelabel parameter plugin, and workflow plugin
            # create a workflow, with one string parameter (STRING_PARAM1), and one node parameter (NODE_PARAM1)
            # create a workflow like this:
            {code}
            node {
               echo STRING_PARAM1
               echo NODE_PARAM1
            }
            {code}

            If you run this workflow, you will get an error:
            {code}
            groovy.lang.MissingPropertyException: No such property: NODE_PARAM1 for class: WorkflowScript
            {code}

            The problem is that the NodeLabel parameter plugin overrides buildEnvVars which was deprecated in Jenkins 1.344: see http://javadoc.jenkins-ci.org/hudson/model/ParameterValue.html#buildEnvVars%28hudson.model.AbstractBuild,%20java.util.Map%29

            It needs to override buildEnvironment(). This is similar to the problem in JENKINS-26694
            rodrigc Craig Rodrigues made changes -
            Link This issue is related to JENKINS-22718 [ JENKINS-22718 ]
            rodrigc Craig Rodrigues made changes -
            Link This issue is related to JENKINS-27718 [ JENKINS-27718 ]
            rodrigc Craig Rodrigues made changes -
            Link This issue is related to JENKINS-22718 [ JENKINS-22718 ]
            rodrigc Craig Rodrigues made changes -
            Description # Install the nodelabel parameter plugin, and workflow plugin
            # create a workflow, with one string parameter (STRING_PARAM1), and one node parameter (NODE_PARAM1)
            # create a workflow like this:
            {code}
            node {
               echo STRING_PARAM1
               echo NODE_PARAM1
            }
            {code}

            If you run this workflow, you will get an error:
            {code}
            groovy.lang.MissingPropertyException: No such property: NODE_PARAM1 for class: WorkflowScript
            {code}

            The problem is that the NodeLabel parameter plugin overrides buildEnvVars which was deprecated in Jenkins 1.344: see http://javadoc.jenkins-ci.org/hudson/model/ParameterValue.html#buildEnvVars%28hudson.model.AbstractBuild,%20java.util.Map%29

            It needs to override buildEnvironment(). This is similar to the problem in JENKINS-26694
            		 # Install the nodelabel parameter plugin, and workflow plugin
            # create a workflow, with one string parameter (STRING_PARAM1), and one node parameter (NODE_PARAM1)
            # create a workflow like this:
            {code}
            node {
               echo STRING_PARAM1
               echo NODE_PARAM1
            }
            {code}

            If you run this workflow, you will get an error:
            {code}
            groovy.lang.MissingPropertyException: No such property: NODE_PARAM1 for class: WorkflowScript
            {code}

            The problem is that the NodeLabel parameter plugin overrides buildEnvVars which was deprecated in Jenkins 1.344: see http://javadoc.jenkins-ci.org/hudson/model/ParameterValue.html#buildEnvVars%28hudson.model.AbstractBuild,%20java.util.Map%29

            It needs to override buildEnvironment(). This is similar to the problem in JENKINS-27718
            recena Manuel Recena Soto made changes -
            Component/s workflow-plugin [ 18820 ]
            recena Manuel Recena Soto made changes -
            Labels workflow
            rodrigc Craig Rodrigues added a comment -

            See fix: https://github.com/jenkinsci/nodelabelparameter-plugin/pull/10/commits

            rodrigc Craig Rodrigues added a comment - See fix: https://github.com/jenkinsci/nodelabelparameter-plugin/pull/10/commits
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Craig Rodrigues
            Path:
            src/main/java/org/jvnet/jenkins/plugins/nodelabelparameter/LabelParameterValue.java
            http://jenkins-ci.org/commit/nodelabelparameter-plugin/c78a062db28ca9fecbae2c70c161e013dc4e34af
            Log:
            JENKINS-32209 Override ParameterValue.buildEnvironment()

            ParameterValue.buildEnvVars() is deprecated. This fix is needed
            for the workflow plugin.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Craig Rodrigues Path: src/main/java/org/jvnet/jenkins/plugins/nodelabelparameter/LabelParameterValue.java http://jenkins-ci.org/commit/nodelabelparameter-plugin/c78a062db28ca9fecbae2c70c161e013dc4e34af Log: JENKINS-32209 Override ParameterValue.buildEnvironment() ParameterValue.buildEnvVars() is deprecated. This fix is needed for the workflow plugin.
            domi Dominik Bartholdi added a comment -

            released with 1.7.1

            domi Dominik Bartholdi added a comment - released with 1.7.1
            domi Dominik Bartholdi made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 167786 ] JNJira + In-Review [ 198274 ]
            abayer Andrew Bayer made changes -
            Labels workflow pipeline workflow
            abayer Andrew Bayer made changes -
            Labels pipeline workflow pipeline
            euphxenos Andrew Lawrence made changes -
            Link This issue is duplicated by JENKINS-32464 [ JENKINS-32464 ]
            markewaite Mark Waite made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

            People

              domi Dominik Bartholdi
              rodrigc Craig Rodrigues
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: