Add "Build Started" comments attempt sometimes fails on Gerrit side

This issue is archived. You can view it, but you can't modify it. Learn more

XMLWordPrintable

      Sometimes adding comments "Build Started" by gerrit-trigger-plugin from specific Jenkins server more than 2 jobs running to Gerrit server, fails.

      In case Jenkins has 2 jobs and these are triggered by uploaded patchset on gerrit,
      either "Build Started ... (1/2)" or "Build Started ... (2/2)" cannot be upload occasionally .

      Here is the stacktrace, issue happens in gerrit-events package :

      java.io.IOException: Error during sending command
        at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand2(AbstractSendCommandJob.java:118)
        at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand(AbstractSendCommandJob.java:79)
        at com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.GerritNotifier.buildStarted(GerritNotifier.java:88)
        at com.sonyericsson.hudson.plugins.gerrit.trigger.gerritnotifier.job.ssh.BuildStartedCommandJob.run(BuildStartedCommandJob.java:80)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
        at java.util.concurrent.FutureTask.run(FutureTask.java:262)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
        at java.lang.Thread.run(Thread.java:745)
Caused by: com.sonymobile.tools.gerrit.gerritevents.ssh.SshException: error: Cannot post review
one or more reviews failed; review output above (1)
        at com.sonymobile.tools.gerrit.gerritevents.ssh.SshConnectionImpl.executeCommand(SshConnectionImpl.java:254)
        at com.sonymobile.tools.gerrit.gerritevents.workers.cmd.AbstractSendCommandJob.sendCommand2(AbstractSendCommandJob.java:116)
        ... 8 more

      In my investigation, It seems that simultaneous attempt of review gerrit's ssh commnd causes error:
      "cannot post review
      one or more reviews failed; review output above", these messages are defined/returned from Gerrit. https://code.google.com/p/gerrit/issues/detail?id=3730

      Issue may be in Gerrit side, but in the meantime, adding review comments of Gerrit ssh command to Gerrit server should take care for error (such as retrying) for Jenkins side.

      environment:

      gerrit-events :2.7.1
      gerrit-trigger:2.14.0

            Assignee:
            rsandell
            Reporter:
            Ryoichi Taniguchi
            Archiver:
            Jenkins Service Account

              Created:
              Updated:
              Resolved:
              Archived: