Details
-
Type:
Bug
-
Status: Resolved (View Workflow)
-
Priority:
Blocker
-
Resolution: Fixed
-
Component/s: cloudbees-folder-plugin
-
Labels:None
-
Similar Issues:
Description
Found it during manual testing of JENKINS-28881
Analysis results:
- AbstractFolder#properties is a persisted list
- Persisted list is being automatically saved on modification
- Persisted list requires the correct specification of owner to be saved. Owner info is not persisted on its own
- When the plugin loads properties from the disk, it does not assign properties owner if the list exists
- Persisted list uses the default owner (Saveable.NOOP)
- When Persisted list is being saved by AbstractFolder#addProperty(), the plugin actually saves NOOP instead of folder
The original code:
if (properties == null) { properties = new DescribableList<AbstractFolderProperty<?>,AbstractFolderPropertyDescriptor>(this); } for (AbstractFolderProperty p : properties) { p.setOwner(this); } ...
Attachments
Issue Links
- is blocking
-
JENKINS-28881 Add support for CloudBees folder plugin
-
- Resolved
-
- links to
Activity
Field | Original Value | New Value |
---|---|---|
Status | Open [ 1 ] | In Progress [ 3 ] |
Link |
This issue is blocking |
Remote Link | This issue links to "cloudbees-folder-plugin/pull/32 (Web Link)" [ 13738 ] |
Resolution | Fixed [ 1 ] | |
Status | In Progress [ 3 ] | Resolved [ 5 ] |
Workflow | JNJira [ 167971 ] | JNJira + In-Review [ 198320 ] |