Calling CLICommandInvoker.invoke() changes Jenkins authorization as a side effect which means that many operations against Jenkins model failed later.
It is a quite common to prepare data in Jenkins instance, call CLI command and verify the state of Jenkins model later.
How-to reproduce:
JenkinsRule j = new JenkinsRule(); j.createFreeStyleProject("aProject"); j.jenkins.getItem("aProject").getDisplayName() // OK -> 'aProject' CLICommandInvoker command = new CLICommandInvoker(j, "version"); CLICommandInvoker.Result result = command.authorizedTo(Jenkins.READ).invoke(); j.jenkins.getItem("aProject").getDisplayName() // Fail -> NPE
How-to fix:
- in CLICommandInvoker.setAuth() save current SecurityRealm, AuthorizationStrategy and thread's SecurityContext
- in CLICommandInvoker.invoke() after result = new Result(returnCode, out, err); call a new method restoreAuth()
- implement a new method CLICommandInvoker.restoreAuth() where SecurityRealm, AuthorizationStrategy and thread's SecurityContext is set to previously saved values
- is blocking
-
JENKINS-32535 Improve test coverage of CLI commands 'add-job-to-view' and 'remove-job-from-view'
-
- Resolved
-
[JENKINS-32571] Preserve original security settings after calling CLICommandInvoker.invoke()
Pavel Janoušek
created issue -
Pavel Janoušek
made changes -
| Summary | Original: CLICommandInvoker.invoke() changes security setting permanently as a side effect | New: CLICommandInvoker.invoke() changes security settings permanently as a side effect |
Pavel Janoušek
made changes -
| Summary | Original: CLICommandInvoker.invoke() changes security settings permanently as a side effect | New: Preserve original security settings after calling CLICommandInvoker.invoke() |
| Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
Pavel Janoušek
made changes -
| Link |
New:
This issue is blocking |
| Labels | New: testing |
Code changed in jenkins
User: Ing. Pavel Janousek
Path:
src/main/java/hudson/cli/CLICommandInvoker.java
http://jenkins-ci.org/commit/jenkins-test-harness/07e5d6ab711786b1cf02d13e03abbc14c4ca6dd9
Log:
JENKINS-32571 Preserve original security settings after calling CommandInvoker.invoke()
Code changed in jenkins
User: Jesse Glick
Path:
src/main/java/hudson/cli/CLICommandInvoker.java
http://jenkins-ci.org/commit/jenkins-test-harness/e1d92561782987d8a6b51285a81790bd52f378ec
Log:
Merge pull request #6 from pjanouse/JENKINS-32571-invoke
[FIXED JENKINS-32571] Preserve original security settings after calling CommandInvoker.invoke()
Compare: https://github.com/jenkinsci/jenkins-test-harness/compare/1d32b054ae59...e1d925617829
| Resolution | New: Fixed [ 1 ] | |
| Status | Original: In Progress [ 3 ] | New: Resolved [ 5 ] |
PR sent.