-
Bug
-
Resolution: Fixed
-
Minor
When using ATH Docker fixture feature, depending on the method you call for starting a new container, might result on a failure if running under Docker-Machine.
The problem is that bindIp is hardcoded to 127.0.0.1 (https://github.com/jenkinsci/acceptance-test-harness/blob/b27c150f35a386dfced4a5960127bf62f9c34363/src/main/java/org/jenkinsci/test/acceptance/docker/DockerImage.java#L32)
The solution might be exploring DOCKER_HOST environment variable and try to get the ip from there.
- links to
[JENKINS-33107] ATH Docker Fixtures might fail using Docker-Machine
Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
Remote Link | New: This issue links to "PR (Web Link)" [ 14002 ] |
Workflow | Original: JNJira [ 168976 ] | New: JNJira + In-Review [ 185692 ] |
Resolution | New: Fixed [ 1 ] | |
Status | Original: In Progress [ 3 ] | New: Resolved [ 5 ] |
Code changed in jenkins
User: Robert Sandell
Path:
pom.xml
src/main/java/org/jenkinsci/test/acceptance/docker/DockerImage.java
src/test/java/org/jenkinsci/test/acceptance/docker/DockerImageTest.java
http://jenkins-ci.org/commit/acceptance-test-harness/ad3855e729ca30a6a31d448b1ab131d0f61396d1
Log:
Merge pull request #79 from lordofthejars/
JENKINS-33107JENKINS-33107Docker Fixtures might fail using Docker-MachineCompare: https://github.com/jenkinsci/acceptance-test-harness/compare/590918c8579b...ad3855e729ca