Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33546

Regression with build parameters in XML API

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Critical
    • Resolution: Fixed
    • core
    • Jenkins 1.652
      Ubuntu 15.10

      java version "1.7.0_95"
      OpenJDK Runtime Environment (IcedTea 2.6.4) (7u95-2.6.4-0ubuntu0.15.10.1)
      OpenJDK 64-Bit Server VM (build 24.95-b01, mixed mode)

    Description

      The structure of runtime build parameters in the XML API for builds has changed in 1.652

      Retrieving XML for a job using /job/JobName/api/xml?depth=2

      In 1.651 the parameters are returned in the following structure:

      <build>
      <action>
      <parameter>
      <name>PARAM_NAME</name>
      <value>paramvalue</value>
      </parameter>
      </action>
      

      In 1.652 (and 1.653) the parameters are returned in the following structure:

      <build>
      <action>
      <name>PARAM_NAME</name>
      <value>paramvalue</value>
      </action>
      

      The <parameter> part of the output has disappeared. I do not see any reference to this in the changelog so I assume this is a regression and not an intentional change.

      Attachments

        Issue Links

          Activity

            vivek Vivek Pandey added a comment -

            There was a bug introduced in stapler that was not handling Iterable bean with @ExportedBean annotation. Basically an Iterable that is also @ExportedBean, is not inspected for @Exported annotation. This is causing <parameter> or changeSet to not get serialized. There is also related bug where nested array type was causing improper singularization resulting in to actions.

            These issues are being fixed in Stapler.

            vivek Vivek Pandey added a comment - There was a bug introduced in stapler that was not handling Iterable bean with @ExportedBean annotation. Basically an Iterable that is also @ExportedBean, is not inspected for @Exported annotation. This is causing <parameter> or changeSet to not get serialized. There is also related bug where nested array type was causing improper singularization resulting in to actions. These issues are being fixed in Stapler.
            vivek Vivek Pandey added a comment -

            Fixed in Stapler 1.242. Waiting to get integrated in to Jenkins 2.x.

            vivek Vivek Pandey added a comment - Fixed in Stapler 1.242. Waiting to get integrated in to Jenkins 2.x.
            astro Astro Ashtar added a comment -

            coervivek - do you know if it's been migrated into jenkins 2.x yet?

            astro Astro Ashtar added a comment - coervivek - do you know if it's been migrated into jenkins 2.x yet?
            vivek Vivek Pandey added a comment -

            astro Not yet. Its intended to go in 2.2 - that will be in coupe weeks. See https://github.com/jenkinsci/jenkins/pull/2265.

            vivek Vivek Pandey added a comment - astro Not yet. Its intended to go in 2.2 - that will be in coupe weeks. See https://github.com/jenkinsci/jenkins/pull/2265 .
            vivek Vivek Pandey added a comment -

            Fixed in Jenkins 2.2 with integration of Stapler 1.243.

            vivek Vivek Pandey added a comment - Fixed in Jenkins 2.2 with integration of Stapler 1.243.

            People

              vivek Vivek Pandey
              djb61 Dominic Bishop
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: