• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • core
    • Jenkins 1.652
      Ubuntu 15.10

      java version "1.7.0_95"
      OpenJDK Runtime Environment (IcedTea 2.6.4) (7u95-2.6.4-0ubuntu0.15.10.1)
      OpenJDK 64-Bit Server VM (build 24.95-b01, mixed mode)

      The structure of runtime build parameters in the XML API for builds has changed in 1.652

      Retrieving XML for a job using /job/JobName/api/xml?depth=2

      In 1.651 the parameters are returned in the following structure:

      <build>
      <action>
      <parameter>
      <name>PARAM_NAME</name>
      <value>paramvalue</value>
      </parameter>
      </action>
      

      In 1.652 (and 1.653) the parameters are returned in the following structure:

      <build>
      <action>
      <name>PARAM_NAME</name>
      <value>paramvalue</value>
      </action>
      

      The <parameter> part of the output has disappeared. I do not see any reference to this in the changelog so I assume this is a regression and not an intentional change.

          [JENKINS-33546] Regression with build parameters in XML API

          Same problem for me.
          Sometime it's write <actions> (with a "s")

          Break my job to query sub-job informations.

          Boudoux Etienne added a comment - Same problem for me. Sometime it's write <actions> (with a "s") Break my job to query sub-job informations.

          Daniel Beck added a comment -

          This is how the API looks like for me (attached screenshots, forgot to just grab the text).

          It's not just the missing "parameter" elements, there's also a separate "actions" wrapper for the cause, which used to be "action". ?tree=actions has the very weird output of:

          …
          <action/>
          <action/>
          <actions/>
          …

          Daniel Beck added a comment - This is how the API looks like for me (attached screenshots, forgot to just grab the text). It's not just the missing "parameter" elements, there's also a separate "actions" wrapper for the cause, which used to be "action". ?tree=actions has the very weird output of: … <action/> <action/> <actions/> …

          Daniel Beck added a comment - - edited

          Assigning to KK so this can be resolved at the same time as JENKINS-33605. Tempted to back out the Stapler update in the mean time, as its new features are not currently used.

          Daniel Beck added a comment - - edited Assigning to KK so this can be resolved at the same time as JENKINS-33605 . Tempted to back out the Stapler update in the mean time, as its new features are not currently used.

          Daniel Beck added a comment -

          Assigning to vivek who's going to work on fixing this.

          Daniel Beck added a comment - Assigning to vivek who's going to work on fixing this.

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/pom.xml
          http://jenkins-ci.org/commit/jenkins/994375f9bb5589e9e02990286712fa67a722c355
          Log:
          Merge pull request #2155 from daniel-beck/JENKINS-33546-33605

          JENKINS-33546 JENKINS-33605 Back to Stapler 1.239

          Compare: https://github.com/jenkinsci/jenkins/compare/83f51e078296...994375f9bb55

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/pom.xml http://jenkins-ci.org/commit/jenkins/994375f9bb5589e9e02990286712fa67a722c355 Log: Merge pull request #2155 from daniel-beck/ JENKINS-33546 -33605 JENKINS-33546 JENKINS-33605 Back to Stapler 1.239 Compare: https://github.com/jenkinsci/jenkins/compare/83f51e078296...994375f9bb55

          Vivek Pandey added a comment -

          There was a bug introduced in stapler that was not handling Iterable bean with @ExportedBean annotation. Basically an Iterable that is also @ExportedBean, is not inspected for @Exported annotation. This is causing <parameter> or changeSet to not get serialized. There is also related bug where nested array type was causing improper singularization resulting in to actions.

          These issues are being fixed in Stapler.

          Vivek Pandey added a comment - There was a bug introduced in stapler that was not handling Iterable bean with @ExportedBean annotation. Basically an Iterable that is also @ExportedBean, is not inspected for @Exported annotation. This is causing <parameter> or changeSet to not get serialized. There is also related bug where nested array type was causing improper singularization resulting in to actions. These issues are being fixed in Stapler.

          Vivek Pandey added a comment -

          Fixed in Stapler 1.242. Waiting to get integrated in to Jenkins 2.x.

          Vivek Pandey added a comment - Fixed in Stapler 1.242. Waiting to get integrated in to Jenkins 2.x.

          Astro Ashtar added a comment -

          coervivek - do you know if it's been migrated into jenkins 2.x yet?

          Astro Ashtar added a comment - coervivek - do you know if it's been migrated into jenkins 2.x yet?

          Vivek Pandey added a comment -

          astro Not yet. Its intended to go in 2.2 - that will be in coupe weeks. See https://github.com/jenkinsci/jenkins/pull/2265.

          Vivek Pandey added a comment - astro Not yet. Its intended to go in 2.2 - that will be in coupe weeks. See https://github.com/jenkinsci/jenkins/pull/2265 .

          Vivek Pandey added a comment -

          Fixed in Jenkins 2.2 with integration of Stapler 1.243.

          Vivek Pandey added a comment - Fixed in Jenkins 2.2 with integration of Stapler 1.243.

            vivek Vivek Pandey
            djb61 Dominic Bishop
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: