[JENKINS-33708] Invocation of 'sh' on Windows should provide a more helpful error

Type: Improvement
Resolution: Fixed
Priority: Minor
Component/s: durable-task-plugin
Labels:
- diagnostics
- pipeline
- testfest
- windows

Similar Issues:
Powered by SuggestiMate

Show

Right now if your pipeline script inadvertently tries to invoke the sh step, something approximating this error will fail your build:

java.io.IOException: Cannot run program "nohup" (in directory "C:\Program Files (x86)\Jenkins\workspace\fathertime"): CreateProcess error=2, The system cannot find the file specified
	at java.lang.ProcessBuilder.start(Unknown Source)
	at hudson.Proc$LocalProc.<init>(Proc.java:244)
	at hudson.Proc$LocalProc.<init>(Proc.java:216)
	at hudson.Launcher$LocalLauncher.launch(Launcher.java:815)
	at hudson.Launcher$ProcStarter.start(Launcher.java:381)
	at org.jenkinsci.plugins.durabletask.BourneShellScript.launchWithCookie(BourneShellScript.java:130)
	at org.jenkinsci.plugins.durabletask.FileMonitoringTask.launch(FileMonitoringTask.java:59)
	at org.jenkinsci.plugins.workflow.steps.durable_task.DurableTaskStep$Execution.start(DurableTaskStep.java:98)
	at org.jenkinsci.plugins.workflow.cps.DSL.invokeMethod(DSL.java:136)
	at org.jenkinsci.plugins.workflow.cps.CpsScript.invokeMethod(CpsScript.java:113)
	at groovy.lang.MetaClassImpl.invokeMethodOnGroovyObject(MetaClassImpl.java:1277)
	at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1171)
	at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1021)
	at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:812)
	at groovy.lang.GroovyObjectSupport.invokeMethod(GroovyObjectSupport.java:46)
	at groovy.lang.MetaClassImpl.invokeMethodOnGroovyObject(MetaClassImpl.java:1277)
	at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1171)
	at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1021)
	at org.codehaus.groovy.runtime.callsite.PogoMetaClassSite.call(PogoMetaClassSite.java:42)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
	at com.cloudbees.groovy.cps.sandbox.DefaultInvoker.methodCall(DefaultInvoker.java:15)
	at WorkflowScript.run(WorkflowScript:11)
	at ___cps.transform___(Native Method)
	at com.cloudbees.groovy.cps.impl.ContinuationGroup.methodCall(ContinuationGroup.java:55)
	at com.cloudbees.groovy.cps.impl.FunctionCallBlock$ContinuationImpl.dispatchOrArg(FunctionCallBlock.java:106)
	at com.cloudbees.groovy.cps.impl.FunctionCallBlock$ContinuationImpl.fixArg(FunctionCallBlock.java:79)
	at sun.reflect.GeneratedMethodAccessor174.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at com.cloudbees.groovy.cps.impl.ContinuationPtr$ContinuationImpl.receive(ContinuationPtr.java:72)
	at com.cloudbees.groovy.cps.impl.ConstantBlock.eval(ConstantBlock.java:21)
	at com.cloudbees.groovy.cps.Next.step(Next.java:58)
	at com.cloudbees.groovy.cps.Continuable.run0(Continuable.java:154)
	at org.jenkinsci.plugins.workflow.cps.CpsThread.runNextChunk(CpsThread.java:164)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.run(CpsThreadGroup.java:277)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.access$000(CpsThreadGroup.java:77)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:186)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:184)
	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$2.call(CpsVmExecutorService.java:47)
	at java.util.concurrent.FutureTask.run(Unknown Source)
	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112)
	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.util.concurrent.FutureTask.run(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)
Caused by: java.io.IOException: CreateProcess error=2, The system cannot find the file specified
	at java.lang.ProcessImpl.create(Native Method)
	at java.lang.ProcessImpl.<init>(Unknown Source)
	at java.lang.ProcessImpl.start(Unknown Source)
	at java.lang.ProcessBuilder.start(Unknown Source)
	at hudson.Proc$LocalProc.<init>(Proc.java:244)
	at hudson.Proc$LocalProc.<init>(Proc.java:216)
	at hudson.Launcher$LocalLauncher.launch(Launcher.java:815)
	at hudson.Launcher$ProcStarter.start(Launcher.java:381)
	at org.jenkinsci.plugins.durabletask.BourneShellScript.launchWithCookie(BourneShellScript.java:130)
	at org.jenkinsci.plugins.durabletask.FileMonitoringTask.launch(FileMonitoringTask.java:59)
	at org.jenkinsci.plugins.workflow.steps.durable_task.DurableTaskStep$Execution.start(DurableTaskStep.java:98)
	at org.jenkinsci.plugins.workflow.cps.DSL.invokeMethod(DSL.java:136)
	at org.jenkinsci.plugins.workflow.cps.CpsScript.invokeMethod(CpsScript.java:113)
	at groovy.lang.MetaClassImpl.invokeMethodOnGroovyObject(MetaClassImpl.java:1277)
	at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1171)
	at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1021)
	at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:812)
	at groovy.lang.GroovyObjectSupport.invokeMethod(GroovyObjectSupport.java:46)
	at groovy.lang.MetaClassImpl.invokeMethodOnGroovyObject(MetaClassImpl.java:1277)
	at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1171)
	at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1021)
	at org.codehaus.groovy.runtime.callsite.PogoMetaClassSite.call(PogoMetaClassSite.java:42)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
	at com.cloudbees.groovy.cps.sandbox.DefaultInvoker.methodCall(DefaultInvoker.java:15)
	... 24 more
Finished: FAILURE

I expect the build to error out, but something more helpful would be nice, like "The `sh` step is not supported on the Windows platform, please use `bat` or install Cygwin"

is related to

JENKINS-32017 workflow plugin sh hangs on windows node

Resolved

relates to

JENKINS-25848 Shell step fails on Mac: nohup: can't detach from console: No such file or directory

Resolved

JENKINS-40225 BourneShellScript fails on Cygwin due to use of slashes vs. backslashes

Resolved

R. Tyler Croy created issue - 2016-03-21 22:44

Christian Höltje added a comment - 2016-06-22 20:30

Based on a normal FreeStyle job, I would expect `sh` to work the same. An example I would expect to work on Windows:

sh('''#!c:\path\to\bash.exe

echo "I am in bash"
''')

Christian Höltje added a comment - 2016-06-22 20:30 Based on a normal FreeStyle job, I would expect `sh` to work the same. An example I would expect to work on Windows: sh('''#!c:\path\to\bash.exe echo "I am in bash" ''')

peschmae peschmae added a comment - 2016-07-06 12:11 - edited

I got it working on my system with the shell from git-bash.

C:\Program Files\Git\bin is in the global search path, such that Jenkins finds sh.exe

Jenkins also needs nohup.exe (as the error message suggests, see also BourneshellScript.java). Git-bash has a nohup.exe in /usr/bin. I just symlinked that (along with the shared libraries it needs) into /bin by running from a Windows cmd shell:

mklink "C:\Program Files\Git\bin\nohup.exe" "C:\Program Files\git\usr\bin\nohup.exe"
mklink "C:\Program Files\Git\bin\msys-2.0.dll" "C:\Program Files\git\usr\bin\msys-2.0.dll"
mklink "C:\Program Files\Git\bin\msys-iconv-2.dll" "C:\Program Files\git\usr\bin\msys-iconv-2.dll"
mklink "C:\Program Files\Git\bin\msys-intl-8.dll" "C:\Program Files\git\usr\bin\msys-intl-8.dll"

With that setup it's working just fine on my machines.

peschmae peschmae added a comment - 2016-07-06 12:11 - edited I got it working on my system with the shell from git-bash. C:\Program Files\Git\bin is in the global search path, such that Jenkins finds sh.exe Jenkins also needs nohup.exe (as the error message suggests, see also BourneshellScript.java ). Git-bash has a nohup.exe in /usr/bin. I just symlinked that (along with the shared libraries it needs) into /bin by running from a Windows cmd shell: mklink "C:\Program Files\Git\bin\nohup.exe" "C:\Program Files\git\usr\bin\nohup.exe" mklink "C:\Program Files\Git\bin\msys-2.0.dll" "C:\Program Files\git\usr\bin\msys-2.0.dll" mklink "C:\Program Files\Git\bin\msys-iconv-2.dll" "C:\Program Files\git\usr\bin\msys-iconv-2.dll" mklink "C:\Program Files\Git\bin\msys-intl-8.dll" "C:\Program Files\git\usr\bin\msys-intl-8.dll" With that setup it's working just fine on my machines.

R. Tyler Croy made changes - 2016-07-25 23:52

Workflow

Original: JNJira [ 169677 ]

New: JNJira + In-Review [ 183601 ]

Jesse Glick made changes - 2016-08-02 16:15

Labels

Original: testfest

New: diagnostics testfest

Jesse Glick made changes - 2016-08-02 16:16

Component/s		New: durable-task-plugin [ 18622 ]
Component/s	Original: workflow-plugin [ 18820 ]
Labels	Original: diagnostics testfest	New: diagnostics testfest windows workflow

Andrew Bayer made changes - 2016-08-29 17:24

Labels

Original: diagnostics testfest windows workflow

New: diagnostics pipeline testfest windows workflow

Andrew Bayer made changes - 2016-08-29 17:27

Labels

Original: diagnostics pipeline testfest windows workflow

New: diagnostics pipeline testfest windows

Jochen Ulrich made changes - 2016-11-15 14:35

Link

New: This issue is related to ~~JENKINS-32017~~ [ ~~JENKINS-32017~~ ]

Yury Zaytsev added a comment - 2016-11-29 19:17

Please just add a new WindowsCheck() next to the DarwinCheck(), I'm also using sh step on Windows with sh from msys, and I don't have nohup. This only makes life difficult for poor Windows users :-/ Thank you!

Yury Zaytsev added a comment - 2016-11-29 19:17 Please just add a new WindowsCheck() next to the DarwinCheck(), I'm also using sh step on Windows with sh from msys, and I don't have nohup. This only makes life difficult for poor Windows users :-/ Thank you!

Assignee:: Unassigned

Reporter:: R. Tyler Croy

Votes:: 19 Vote for this issue

Watchers:: 30 Start watching this issue

Created:: 2016-03-21 22:44

Updated:: 2024-11-22 16:52

Resolved:: 2024-11-22 16:52

Jenkins

Details

Description

Attachments

Issue Links

Activity

Collapse comment: Christian Höltje added a comment - 2016-06-22 20:30

Expand comment: Christian Höltje added a comment - 2016-06-22 20:30

Collapse comment: peschmae peschmae added a comment - 2016-07-06 12:11, Edited by peschmae peschmae - 2016-07-06 12:16

Expand comment: peschmae peschmae added a comment - 2016-07-06 12:11, Edited by peschmae peschmae - 2016-07-06 12:16

Collapse comment: Yury Zaytsev added a comment - 2016-11-29 19:17

Expand comment: Yury Zaytsev added a comment - 2016-11-29 19:17

People

Dates