Acceptance test harness needs to be checked whether it works with the 2.0 targeting changes, and if not, needs to be adapted to work with the 2.0 changes.

          [JENKINS-33730] ATH needs to be made to work with 2.0

          Tom FENNELLY added a comment -

          olivergondza I see you sorted out the tooling. I also had a goo at that as mentioned in my last post - the problem I mentioned seemed only to be a timing issue when running in a debugger Anyway, thanks for that.

          PR 88 is running again and is about 1/2 way through it seems.

          Tom FENNELLY added a comment - olivergondza I see you sorted out the tooling. I also had a goo at that as mentioned in my last post - the problem I mentioned seemed only to be a timing issue when running in a debugger Anyway, thanks for that. PR 88 is running again and is about 1/2 way through it seems.

          Tom FENNELLY added a comment -

          olivergondza also note that I had to add a temporary tweak to make the tooling config go to the right page since 2.0-beta is actually older than VersionNumber("2"). We can reverty to what you added after the 2.0 release.

          Tom FENNELLY added a comment - olivergondza also note that I had to add a temporary tweak to make the tooling config go to the right page since 2.0-beta is actually older than VersionNumber("2") . We can reverty to what you added after the 2.0 release.

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          src/main/java/org/jenkinsci/test/acceptance/controller/LocalController.java
          src/main/java/org/jenkinsci/test/acceptance/po/ToolInstallation.java
          src/main/java/org/jenkinsci/test/acceptance/selenium/Scroller.java
          src/main/resources/org/jenkinsci/test/acceptance/selenium/scroller.js
          http://jenkins-ci.org/commit/acceptance-test-harness/c1512e4da9dc3b4dd701988dae103eaec405ec25
          Log:
          Merge pull request #88 from tfennelly/2.0-JENKINS-33730

          JENKINS-33730 More ATH tweaks for Jenkins 2.0

          Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/4de2dfc72cf2...c1512e4da9dc

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/main/java/org/jenkinsci/test/acceptance/controller/LocalController.java src/main/java/org/jenkinsci/test/acceptance/po/ToolInstallation.java src/main/java/org/jenkinsci/test/acceptance/selenium/Scroller.java src/main/resources/org/jenkinsci/test/acceptance/selenium/scroller.js http://jenkins-ci.org/commit/acceptance-test-harness/c1512e4da9dc3b4dd701988dae103eaec405ec25 Log: Merge pull request #88 from tfennelly/2.0- JENKINS-33730 JENKINS-33730 More ATH tweaks for Jenkins 2.0 Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/4de2dfc72cf2...c1512e4da9dc

          Tom FENNELLY added a comment -

          I should be done with this today.

          Tom FENNELLY added a comment - I should be done with this today.

          tfennelly, there seems to be some problem with Control#selectDropdownMenu(Unable to add build step, post build step, tool installation) but I am not able to reproduce that locally. I speculate it might take a little longer to appear in 2.0 so we are clicking the item before the menu appear but it is just a wild guess.

          Oliver Gondža added a comment - tfennelly , there seems to be some problem with Control#selectDropdownMenu (Unable to add build step, post build step, tool installation) but I am not able to reproduce that locally. I speculate it might take a little longer to appear in 2.0 so we are clicking the item before the menu appear but it is just a wild guess.

          Tom FENNELLY added a comment -

          olivergondza where are you seeing the issue with Control#selectDropdownMenu ? Which test?

          Tom FENNELLY added a comment - olivergondza where are you seeing the issue with Control#selectDropdownMenu ? Which test?

          Oliver Gondža added a comment - tfennelly for instance https://jenkins.ci.cloudbees.com/job/core/job/acceptance-test-harness-2.0/lastCompletedBuild/testReport/plugins/AnalysisCollectorPluginTest/should_compute_all_new_open_tasks/

          Tom FENNELLY added a comment -

          Hmmm I've run that a few times now and it passed each time.

          Tom FENNELLY added a comment - Hmmm I've run that a few times now and it passed each time.

          I am not able to reproduce that locally, either.

          Oliver Gondža added a comment - I am not able to reproduce that locally, either.

          Tom FENNELLY added a comment -

          Closing this now. The only failures/errors I get now are tests that were already in fail/error when running against 1.x.

          Tom FENNELLY added a comment - Closing this now. The only failures/errors I get now are tests that were already in fail/error when running against 1.x.

            tfennelly Tom FENNELLY
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: