Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34596

Set visible flag when Jenkinsfile is taken from a trusted revision rather than PR head

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • pipeline

      When pull requests are done from private repos in a github organization, for example: A develop will fork a repo, commit some changes then submit a pull request from the forked repo. In that case the files will be taken from organization instead of developer, so the tests actually run on the wrong code, they pass and the pull request in github gets marked as passing even though it was never actually tested.

      A way to know if the revision of the Jenkinsfile is not the same than the branch tip (a.k.a the Jenkinsfile comes from an untrusted brach) should be great.

      https://github.com/jenkinsci/github-branch-source-plugin/blob/a10e869ec3b653b05eb188bd1e4054211d32294f/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L421-L433

          [JENKINS-34596] Set visible flag when Jenkinsfile is taken from a trusted revision rather than PR head

          Emilio Escobar created issue -
          Antonio Muñiz made changes -
          Component/s Original: github-branch-source-plugin [ 20858 ]
          Jesse Glick made changes -
          Link New: This issue is blocking JENKINS-33256 [ JENKINS-33256 ]
          Jesse Glick made changes -
          Summary Original: Add a way to know if the revision of the Jenkinsfile is not the same than the branch tip New: Set visible flag when Jenkinsfile is taken from a trusted revision rather than PR head
          Jesse Glick made changes -
          Labels New: multibranch
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-33273 [ JENKINS-33273 ]
          Jesse Glick made changes -
          Remote Link New: This issue links to "PR 10 (Web Link)" [ 14344 ]
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-32400 [ JENKINS-32400 ]
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 170756 ] New: JNJira + In-Review [ 198936 ]

            jglick Jesse Glick
            escoem Emilio Escobar
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: