Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34759

FilePath.validateAntFileMask - space separation of multiple filenames

    XMLWordPrintable

Details

    • Bug
    • Status: Open (View Workflow)
    • Minor
    • Resolution: Unresolved
    • core
    • None
    • Dry-Plugin 2.44

    Description

      An ANT Fileset includes should be "comma- or space-separated list of patterns of files that must be included; all files are included when omitted."
      However, a space separated list is not accepted. A warning is shown.
      However, both files are scanned.
      Expected behaviour: dont show warning, as it works anyway.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-34760 order of fileset matters?

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            robert_l Robert Lieske created issue -
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ulli Hafner
            Path:
            src/main/java/hudson/plugins/analysis/core/PluginDescriptor.java
            http://jenkins-ci.org/commit/analysis-core-plugin/fa460e345c63d8980cad9271e14eeec3b14c68b9
            Log:
            JENKINS-34759 JENKINS-34760 Use validateAnt* method rather than validateFile*.

            Compare: https://github.com/jenkinsci/analysis-core-plugin/compare/ea79d2b6d28c...fa460e345c63

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/analysis/core/PluginDescriptor.java http://jenkins-ci.org/commit/analysis-core-plugin/fa460e345c63d8980cad9271e14eeec3b14c68b9 Log: JENKINS-34759 JENKINS-34760 Use validateAnt* method rather than validateFile*. Compare: https://github.com/jenkinsci/analysis-core-plugin/compare/ea79d2b6d28c...fa460e345c63
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ulli Hafner
            Path:
            src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_core/AnalysisFreestyleSettings.java
            src/test/java/plugins/PmdPluginTest.java
            http://jenkins-ci.org/commit/acceptance-test-harness/3bf4797ae3deb7f24dc0ef4e2f9c9d8a5fce2945
            Log:
            JENKINS-34759 JENKINS-34760 Added test that exposes the bug in core.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/org/jenkinsci/test/acceptance/plugins/analysis_core/AnalysisFreestyleSettings.java src/test/java/plugins/PmdPluginTest.java http://jenkins-ci.org/commit/acceptance-test-harness/3bf4797ae3deb7f24dc0ef4e2f9c9d8a5fce2945 Log: JENKINS-34759 JENKINS-34760 Added test that exposes the bug in core.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ulli Hafner
            Path:
            analysis-core
            dry
            warnings
            http://jenkins-ci.org/commit/analysis-suite-plugin/2df3a83938a37d6a942b4ee9b0e8d7af664ce654
            Log:
            JENKINS-34759 JENKINS-34760 Use validateAnt* method rather than validateFile*.

            Compare: https://github.com/jenkinsci/analysis-suite-plugin/compare/9ac42a5935a4...2df3a83938a3

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: analysis-core dry warnings http://jenkins-ci.org/commit/analysis-suite-plugin/2df3a83938a37d6a942b4ee9b0e8d7af664ce654 Log: JENKINS-34759 JENKINS-34760 Use validateAnt* method rather than validateFile*. Compare: https://github.com/jenkinsci/analysis-suite-plugin/compare/9ac42a5935a4...2df3a83938a3
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ulli Hafner
            Path:
            src/main/java/hudson/plugins/warnings/WarningsDescriptor.java
            http://jenkins-ci.org/commit/warnings-plugin/762294aaa171f556d50e219b49af1e75aea7213e
            Log:
            JENKINS-34759 JENKINS-34760 Use validateAnt* method rather than validateFile*.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/warnings/WarningsDescriptor.java http://jenkins-ci.org/commit/warnings-plugin/762294aaa171f556d50e219b49af1e75aea7213e Log: JENKINS-34759 JENKINS-34760 Use validateAnt* method rather than validateFile*.
            drulli Ulli Hafner made changes -
            Field Original Value New Value
            Link This issue is related to JENKINS-34760 [ JENKINS-34760 ]
            drulli Ulli Hafner made changes -
            Component/s core [ 15593 ]
            Component/s dry-plugin [ 15591 ]
            Assignee Ulli Hafner [ drulli ]
            drulli Ulli Hafner added a comment -

            I fixed it on the plug-in side. Now FilePath.validateAntFileMask needs to be fixed.

            drulli Ulli Hafner added a comment - I fixed it on the plug-in side. Now FilePath.validateAntFileMask needs to be fixed.
            drulli Ulli Hafner added a comment -

            Testcase: https://github.com/jenkinsci/acceptance-test-harness/commit/3bf4797ae3deb7f24dc0ef4e2f9c9d8a5fce2945

            drulli Ulli Hafner added a comment - Testcase: https://github.com/jenkinsci/acceptance-test-harness/commit/3bf4797ae3deb7f24dc0ef4e2f9c9d8a5fce2945
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 170942 ] JNJira + In-Review [ 184101 ]
            oleg_nenashev Oleg Nenashev made changes -
            Summary space separation of multiple filenames FilePath.validateAntFileMask - space separation of multiple filenames

            People

              Unassigned Unassigned
              robert_l Robert Lieske
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: