Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34858

Listed Parameters should reflect what was used when the build ran

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Not what is considered safe/not safe with current system properties.

        Attachments

          Issue Links

            Activity

            Hide
            danielbeck Daniel Beck added a comment -

            Isn't this case covered by the implementation, as it stores parameterDefinitionNames?

            Show
            danielbeck Daniel Beck added a comment - Isn't this case covered by the implementation, as it stores parameterDefinitionNames ?
            Hide
            rsandell rsandell added a comment -

            The original implementation did a lookup of the safe params system property whenever the cache was null. So a restart and change of safe parameters would change the listing of old builds since the cache was transient.

            Show
            rsandell rsandell added a comment - The original implementation did a lookup of the safe params system property whenever the cache was null. So a restart and change of safe parameters would change the listing of old builds since the cache was transient.
            Hide
            rsandell rsandell added a comment -

            There is a test case covering that scenario in my PR.

            Show
            rsandell rsandell added a comment - There is a test case covering that scenario in my PR.
            Hide
            rsandell rsandell added a comment -

            There is also an issue when loading an old build with an old ParametersAction (before SECURITY 170) that it would filter out any unsafe parameters from the display, even though they were actually used in the build.
            But I don't know how to fix that.

            Show
            rsandell rsandell added a comment - There is also an issue when loading an old build with an old ParametersAction (before SECURITY 170) that it would filter out any unsafe parameters from the display, even though they were actually used in the build. But I don't know how to fix that.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Robert Sandell
            Path:
            core/src/main/java/hudson/model/ParametersAction.java
            test/src/test/java/hudson/model/ParametersActionTest2.java
            http://jenkins-ci.org/commit/jenkins/43f570f3e2c0424d0e842490c1820946b2c5fefb
            Log:
            JENKINS-34858 - Listed Parameters should reflect what was used when the build ran

            And provided a way for plugins to define safe parameters
            by extending ParametersAction

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Robert Sandell Path: core/src/main/java/hudson/model/ParametersAction.java test/src/test/java/hudson/model/ParametersActionTest2.java http://jenkins-ci.org/commit/jenkins/43f570f3e2c0424d0e842490c1820946b2c5fefb Log: JENKINS-34858 - Listed Parameters should reflect what was used when the build ran And provided a way for plugins to define safe parameters by extending ParametersAction
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Robert Sandell
            Path:
            core/src/main/java/hudson/model/ParametersAction.java
            test/src/test/java/hudson/model/ParametersActionTest2.java
            http://jenkins-ci.org/commit/jenkins/74d0412d74a6429765a98e8d8c52324139de8034
            Log:
            Merge pull request #2353 from rsandell/safe-parameters

            JENKINS-34858 - Listed Parameters should reflect what was used when the build ran

            Compare: https://github.com/jenkinsci/jenkins/compare/d08eec18dcb2...74d0412d74a6

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Robert Sandell Path: core/src/main/java/hudson/model/ParametersAction.java test/src/test/java/hudson/model/ParametersActionTest2.java http://jenkins-ci.org/commit/jenkins/74d0412d74a6429765a98e8d8c52324139de8034 Log: Merge pull request #2353 from rsandell/safe-parameters JENKINS-34858 - Listed Parameters should reflect what was used when the build ran Compare: https://github.com/jenkinsci/jenkins/compare/d08eec18dcb2...74d0412d74a6
            Hide
            rsandell rsandell added a comment -

            Merged to master

            Show
            rsandell rsandell added a comment - Merged to master
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            target release - 2.6

            Show
            oleg_nenashev Oleg Nenashev added a comment - target release - 2.6
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Robert Sandell
            Path:
            core/src/main/java/hudson/model/ParametersAction.java
            test/src/test/java/hudson/model/ParametersActionTest2.java
            http://jenkins-ci.org/commit/jenkins/68a88a1e4229749df85799a91bb739f6a7d6e5a1
            Log:
            Merge pull request #2353 from rsandell/safe-parameters

            JENKINS-34858 - Listed Parameters should reflect what was used when the build ran
            (cherry picked from commit 74d0412d74a6429765a98e8d8c52324139de8034)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Robert Sandell Path: core/src/main/java/hudson/model/ParametersAction.java test/src/test/java/hudson/model/ParametersActionTest2.java http://jenkins-ci.org/commit/jenkins/68a88a1e4229749df85799a91bb739f6a7d6e5a1 Log: Merge pull request #2353 from rsandell/safe-parameters JENKINS-34858 - Listed Parameters should reflect what was used when the build ran (cherry picked from commit 74d0412d74a6429765a98e8d8c52324139de8034)
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Released as Jenkins-2.6

            Show
            oleg_nenashev Oleg Nenashev added a comment - Released as Jenkins-2.6

              People

              Assignee:
              rsandell rsandell
              Reporter:
              rsandell rsandell
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: