Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-3506

AbstractProject.doWipeOutWorkspace() should support SCM.processWorkspaceBeforeDeletion()

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • core
    • None
    • Platform: All, OS: All

    Description

      Before a workspace is deleted by hudson.model.WorkspaceCleanupThread, it checks
      with the SCM for the job to see if it should be allowed to delete the workspace,
      by calling hudson.scm.SCM.processWorkspaceBeforeDeletion. I'm going to be adding
      an override of that method in the ClearCase plugin to remove the ClearCase view
      and then return true, so that we don't end up with a view still registered in
      ClearCase after its view storage, etc have been deleted.

      However, when "Wipe Out Workspace" is used, there is no check with the SCM
      first. The workspace is just deleted. I believe that doWipeOutWorkspace in
      AbstractProject should call processWorkspaceBeforeDeletion before deleting the
      workspace contents, and should only proceed if processWorkspaceBeforeDeletion
      returns true. This will give us the ability to remove the ClearCase view when
      "Wipe Out Workspace" is used, as well as the ability for SCMs to veto the
      deletion of the workspace.

      Attachments

        Issue Links

          Activity

            abayer Andrew Bayer created issue -
            abayer Andrew Bayer made changes -
            Field Original Value New Value
            Link This issue is blocking JENKINS-2209 [ JENKINS-2209 ]
            scm_issue_link SCM/JIRA link daemon made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            abayer Andrew Bayer made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 133579 ] JNJira + In-Review [ 202264 ]

            People

              abayer Andrew Bayer
              abayer Andrew Bayer
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: