[JENKINS-35206] NullPointerException on startup after update from 2.5 to 2.6 - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Resolved (View Workflow)
Priority: Blocker
Resolution: Fixed
Component/s: core
Labels:
- 2.7.1-fixed

Similar Issues:

Show

Description

After updating to 2.6 from 2.5 I'm getting the following NPE directly at startup:

hudson.util.HudsonFailedToLoad: java.lang.NullPointerException
	at hudson.WebAppMain$3.run(WebAppMain.java:244)
Caused by: java.lang.NullPointerException
	at jenkins.install.InstallState.equals(InstallState.java:179)
	at jenkins.install.InstallUtil.proceedToNextStateFrom(InstallUtil.java:97)
	at jenkins.model.Jenkins.<init>(Jenkins.java:888)
	at hudson.model.Hudson.<init>(Hudson.java:85)
	at hudson.model.Hudson.<init>(Hudson.java:81)
	at hudson.WebAppMain$3.run(WebAppMain.java:227)

The stacktrace didn't suggest a particular plugin so I chose 'core' as component. Please correct if necessary.

jenkins.err.log

Mai 30, 2016 7:23:10 AM org.eclipse.jetty.util.log.JavaUtilLog info
INFO: Logging initialized @470ms
Mai 30, 2016 7:23:10 AM winstone.Logger logInternal
INFO: Beginning extraction from war file
Mai 30, 2016 7:23:14 AM org.eclipse.jetty.util.log.JavaUtilLog warn
WARNING: Empty contextPath
Mai 30, 2016 7:23:14 AM org.eclipse.jetty.util.log.JavaUtilLog info
INFO: jetty-9.2.z-SNAPSHOT
Mai 30, 2016 7:23:15 AM org.eclipse.jetty.util.log.JavaUtilLog info
INFO: NO JSP Support for /, did not find org.eclipse.jetty.jsp.JettyJspServlet
Mai 30, 2016 7:23:15 AM org.eclipse.jetty.util.log.JavaUtilLog info
INFO: Started w.@1e3c1c7{/,file:/C:/Program%20Files%20(x86)/Jenkins/war/,AVAILABLE}{C:\Program Files (x86)\Jenkins\war}
Mai 30, 2016 7:23:15 AM org.eclipse.jetty.util.log.JavaUtilLog info
INFO: Started ServerConnector@19b0f9d{HTTP/1.1}{0.0.0.0:8080}
Mai 30, 2016 7:23:15 AM org.eclipse.jetty.util.log.JavaUtilLog info
INFO: Started @5203ms
Mai 30, 2016 7:23:15 AM winstone.Logger logInternal
INFO: Winstone Servlet Engine v2.0 running: controlPort=disabled
Mai 30, 2016 7:23:16 AM jenkins.InitReactorRunner$1 onAttained
INFO: Started initialization
Mai 30, 2016 7:23:16 AM jenkins.InitReactorRunner$1 onAttained
INFO: Listed all plugins
Mai 30, 2016 7:23:18 AM jenkins.InitReactorRunner$1 onAttained
INFO: Prepared all plugins
Mai 30, 2016 7:23:18 AM hudson.ExtensionFinder$GuiceFinder$FaultTolerantScope$1 error
INFO: Failed to instantiate optional component org.jenkinsci.plugins.workflow.steps.scm.SubversionStep$DescriptorImpl; skipping
Mai 30, 2016 7:23:19 AM jenkins.InitReactorRunner$1 onAttained
INFO: Started all plugins
Mai 30, 2016 7:23:19 AM jenkins.InitReactorRunner$1 onAttained
INFO: Augmented all extensions
Mai 30, 2016 7:23:19 AM jenkins.InitReactorRunner$1 onAttained
INFO: Loaded all jobs
Mai 30, 2016 7:23:19 AM hudson.model.AsyncPeriodicWork$1 run
INFO: Started Download metadata
Mai 30, 2016 7:23:19 AM hudson.model.AsyncPeriodicWork$1 run
INFO: Finished Download metadata. 8 ms
Mai 30, 2016 7:23:19 AM org.jenkinsci.main.modules.sshd.SSHD start
INFO: Started SSHD at port 65097
Mai 30, 2016 7:23:19 AM jenkins.InitReactorRunner$1 onAttained
INFO: Completed initialization
Mai 30, 2016 7:23:19 AM hudson.util.BootFailure publish
SEVERE: Failed to initialize Jenkins
hudson.util.HudsonFailedToLoad: java.lang.NullPointerException
	at hudson.WebAppMain$3.run(WebAppMain.java:244)
Caused by: java.lang.NullPointerException
	at jenkins.install.InstallState.equals(InstallState.java:179)
	at jenkins.install.InstallUtil.proceedToNextStateFrom(InstallUtil.java:97)
	at jenkins.model.Jenkins.<init>(Jenkins.java:888)
	at hudson.model.Hudson.<init>(Hudson.java:85)
	at hudson.model.Hudson.<init>(Hudson.java:81)
	at hudson.WebAppMain$3.run(WebAppMain.java:227)

Attachments

Issue Links

links to

PR 2385

PR 2387

Activity

Ascending order - Click to sort in descending order

Axel Behrens created issue - 2016-05-30 05:52

Axel Behrens made changes - 2016-05-30 11:23

Field	Original Value	New Value
Summary	NullPointerException on startup after update to 2.6	NullPointerException on startup after update from 2.5 to 2.6

Oleg Nenashev made changes - 2016-05-30 14:19

Assignee

Keith Zantow [ kzantow ]

Oleg Nenashev added a comment - 2016-05-30 14:20 - edited

It was caused by changes in the Update Wizard made by kzantow.
Does this issue block the startup?

Oleg Nenashev added a comment - 2016-05-30 14:20 - edited It was caused by changes in the Update Wizard made by kzantow . Does this issue block the startup?

Axel Behrens added a comment - 2016-05-31 06:07

Yes, the NPE stacktrace is the only thing shown in the web UI.

Axel Behrens added a comment - 2016-05-31 06:07 Yes, the NPE stacktrace is the only thing shown in the web UI.

Daniel Beck made changes - 2016-05-31 14:00

Priority

Minor [ 4 ]

Blocker [ 1 ]

Daniel Beck added a comment - 2016-05-31 14:03

axelbehrens Do you remember what you did in 2.5? Did you run the upgrade wizard (installation of Pipeline plugins)? Did you dismiss it, or ignore the banner?

Daniel Beck added a comment - 2016-05-31 14:03 axelbehrens Do you remember what you did in 2.5? Did you run the upgrade wizard (installation of Pipeline plugins)? Did you dismiss it, or ignore the banner?

Oleg Nenashev made changes - 2016-05-31 15:27

Assignee

Keith Zantow [ kzantow ]

Oleg Nenashev [ oleg_nenashev ]

Oleg Nenashev made changes - 2016-05-31 15:27

Status

Open [ 1 ]

In Progress [ 3 ]

Keith Zantow made changes - 2016-05-31 16:13

Assignee

Oleg Nenashev [ oleg_nenashev ]

Keith Zantow [ kzantow ]

Keith Zantow made changes - 2016-05-31 16:13

Remote Link

This issue links to "PR 2385 (Web Link)" [ 14352 ]

Manuel Recena Soto made changes - 2016-05-31 16:16

Remote Link

This issue links to "PR (Web Link)" [ 14353 ]

Manuel Recena Soto made changes - 2016-05-31 16:16

Remote Link

This issue links to "PR (Web Link)" [ 14353 ]

Keith Zantow added a comment - 2016-05-31 16:17

axelbehrens could you provide any additional information how you were able to get your Jenkins instance into this state? I was not able to reproduce it installing 2.5 and upgrading to 2.6. In any case, I've prepared a patch, which should fix this against the 2.6 codebase here.

Keith Zantow added a comment - 2016-05-31 16:17 axelbehrens could you provide any additional information how you were able to get your Jenkins instance into this state? I was not able to reproduce it installing 2.5 and upgrading to 2.6. In any case, I've prepared a patch, which should fix this against the 2.6 codebase here .

Axel Behrens added a comment - 2016-06-01 05:48

kzantow, this is only a test instance running on my laptop (Windows 7 x64). I've installed v2.0 from scratch, added a handful of plugins and created some jobs. I automatically updated pretty much to every new release until 2.6.

This is my config.xml if that helps:

<?xml version='1.0' encoding='UTF-8'?>
<hudson>
  <disabledAdministrativeMonitors>
    <string>jenkins.diagnostics.SecurityIsOffMonitor</string>
  </disabledAdministrativeMonitors>
  <version>1.0</version>
  <installState>RESTART</installState>
  <numExecutors>2</numExecutors>
  <mode>NORMAL</mode>
  <useSecurity>true</useSecurity>
  <authorizationStrategy class="hudson.security.AuthorizationStrategy$Unsecured"/>
  <securityRealm class="hudson.security.SecurityRealm$None"/>
  <disableRememberMe>false</disableRememberMe>
  <projectNamingStrategy class="jenkins.model.ProjectNamingStrategy$DefaultProjectNamingStrategy"/>
  <workspaceDir>${ITEM_ROOTDIR}/workspace</workspaceDir>
  <buildsDir>${ITEM_ROOTDIR}/builds</buildsDir>
  <jdks/>
  <viewsTabBar class="hudson.views.DefaultViewsTabBar"/>
  <myViewsTabBar class="hudson.views.DefaultMyViewsTabBar"/>
  <clouds/>
  <scmCheckoutRetryCount>0</scmCheckoutRetryCount>
  <views>
    <hudson.model.AllView>
      <owner class="hudson" reference="../../.."/>
      <name>All</name>
      <filterExecutors>false</filterExecutors>
      <filterQueue>false</filterQueue>
      <properties class="hudson.model.View$PropertyList"/>
    </hudson.model.AllView>
  </views>
  <primaryView>All</primaryView>
  <slaveAgentPort>0</slaveAgentPort>
  <label></label>
  <nodeProperties/>
  <globalNodeProperties/>
</hudson>

Cheers

Axel Behrens added a comment - 2016-06-01 05:48 kzantow , this is only a test instance running on my laptop (Windows 7 x64). I've installed v2.0 from scratch, added a handful of plugins and created some jobs. I automatically updated pretty much to every new release until 2.6. This is my config.xml if that helps: <?xml version='1.0' encoding='UTF-8'?> <hudson> <disabledAdministrativeMonitors> <string>jenkins.diagnostics.SecurityIsOffMonitor</string> </disabledAdministrativeMonitors> <version>1.0</version> <installState>RESTART</installState> <numExecutors>2</numExecutors> <mode>NORMAL</mode> <useSecurity>true</useSecurity> <authorizationStrategy class="hudson.security.AuthorizationStrategy$Unsecured"/> <securityRealm class="hudson.security.SecurityRealm$None"/> <disableRememberMe>false</disableRememberMe> <projectNamingStrategy class="jenkins.model.ProjectNamingStrategy$DefaultProjectNamingStrategy"/> <workspaceDir>${ITEM_ROOTDIR}/workspace</workspaceDir> <buildsDir>${ITEM_ROOTDIR}/builds</buildsDir> <jdks/> <viewsTabBar class="hudson.views.DefaultViewsTabBar"/> <myViewsTabBar class="hudson.views.DefaultMyViewsTabBar"/> <clouds/> <scmCheckoutRetryCount>0</scmCheckoutRetryCount> <views> <hudson.model.AllView> <owner class="hudson" reference="../../.."/> <name>All</name> <filterExecutors>false</filterExecutors> <filterQueue>false</filterQueue> <properties class="hudson.model.View$PropertyList"/> </hudson.model.AllView> </views> <primaryView>All</primaryView> <slaveAgentPort>0</slaveAgentPort> <label></label> <nodeProperties/> <globalNodeProperties/> </hudson> Cheers

Oleg Nenashev added a comment - 2016-06-01 08:32

Copy-paste from Keith's PR: "IMHO the only realistic case of getting such state is a corrupted config file with the legacy non-transient installState due to the whatever reason (e.g. upgrade from the previous version). I would vote for handling it in InstallState#readResolve() or in Jenkins#readResolve()"

Working on this alternate solution

Oleg Nenashev added a comment - 2016-06-01 08:32 Copy-paste from Keith's PR: "IMHO the only realistic case of getting such state is a corrupted config file with the legacy non-transient installState due to the whatever reason (e.g. upgrade from the previous version). I would vote for handling it in InstallState#readResolve() or in Jenkins#readResolve()" Working on this alternate solution

Keith Zantow added a comment - 2016-06-01 14:21

oleg_nenashev yeah, this <installState>RESTART</installState> is the culprit, it looks like. A shame XStream doesn't realize the field is now transient and skip it. I still think that this could potentially be set from other sources (e.g. Groovy startup scripts), which makes my solution more general purpose.

Keith Zantow added a comment - 2016-06-01 14:21 oleg_nenashev yeah, this <installState>RESTART</installState> is the culprit, it looks like. A shame XStream doesn't realize the field is now transient and skip it. I still think that this could potentially be set from other sources (e.g. Groovy startup scripts), which makes my solution more general purpose.

Oleg Nenashev added a comment - 2016-06-01 14:25

Agreed, XStream fix does not close all potential misuse cases. Created https://github.com/jenkinsci/jenkins/pull/2387 anyway

Oleg Nenashev added a comment - 2016-06-01 14:25 Agreed, XStream fix does not close all potential misuse cases. Created https://github.com/jenkinsci/jenkins/pull/2387 anyway

Oleg Nenashev made changes - 2016-06-01 14:26

Remote Link

This issue links to "PR 2387 (Web Link)" [ 14355 ]

SCM/JIRA link daemon added a comment - 2016-06-02 17:56

Code changed in jenkins
User: Oleg Nenashev
Path:
core/src/main/java/jenkins/install/InstallState.java
test/src/test/java/jenkins/install/InstallStateTest.java
http://jenkins-ci.org/commit/jenkins/1b2711c9578f5b34bc452fcc3f2dd055b1c0865c
Log:
~~JENKINS-35206~~ - Make the InstallState object deserialization robust against corrupted files (#2387)

~~JENKINS-35206~~ - Add unit tests for the deserialization logic

~~JENKINS-35206~~ - Install state should be robust against messed statuses when deserializing objects

~~JENKINS-35206~~ - Fix the license header in thre test file

SCM/JIRA link daemon added a comment - 2016-06-02 17:56 Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/jenkins/install/InstallState.java test/src/test/java/jenkins/install/InstallStateTest.java http://jenkins-ci.org/commit/jenkins/1b2711c9578f5b34bc452fcc3f2dd055b1c0865c Log: JENKINS-35206 - Make the InstallState object deserialization robust against corrupted files (#2387) JENKINS-35206 - Add unit tests for the deserialization logic JENKINS-35206 - Install state should be robust against messed statuses when deserializing objects JENKINS-35206 - Fix the license header in thre test file

SCM/JIRA link daemon added a comment - 2016-06-03 14:32

Code changed in jenkins
User: Keith Zantow
Path:
core/src/main/java/jenkins/install/InstallUtil.java
core/src/main/java/jenkins/model/Jenkins.java
http://jenkins-ci.org/commit/jenkins/541641100b4a9570d72d263a12edbc1e06c987a2
Log:
~~JENKINS-35206~~ - fix potential NPE due to corrupt Jenkins.InstallState (#2385)

SCM/JIRA link daemon added a comment - 2016-06-03 14:32 Code changed in jenkins User: Keith Zantow Path: core/src/main/java/jenkins/install/InstallUtil.java core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/541641100b4a9570d72d263a12edbc1e06c987a2 Log: JENKINS-35206 - fix potential NPE due to corrupt Jenkins.InstallState (#2385)

Axel Behrens added a comment - 2016-06-06 07:57

BTW: It's fixed now in 2.8

Axel Behrens added a comment - 2016-06-06 07:57 BTW: It's fixed now in 2.8

Oleg Nenashev made changes - 2016-06-06 08:05

Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Resolved [ 5 ]

Daniel Beck made changes - 2016-06-08 18:15

Labels

lts-candidate

Oliver Gondža made changes - 2016-06-19 20:12

Labels

lts-candidate

2.7.1-fixed

R. Tyler Croy made changes - 2016-07-25 23:57

Workflow

JNJira [ 171434 ]

JNJira + In-Review [ 199101 ]

SCM/JIRA link daemon added a comment - 2017-02-17 20:10

Code changed in jenkins
User: Keith Zantow
Path:
core/src/main/java/jenkins/install/InstallUtil.java
core/src/main/java/jenkins/model/Jenkins.java
http://jenkins-ci.org/commit/jenkins/3837f44a6f2621dde0bea59c522cc1e0464b67c2
Log:
~~JENKINS-35206~~ - fix potential NPE due to corrupt Jenkins.InstallState (#2385)
(cherry picked from commit 541641100b4a9570d72d263a12edbc1e06c987a2)

SCM/JIRA link daemon added a comment - 2017-02-17 20:10 Code changed in jenkins User: Keith Zantow Path: core/src/main/java/jenkins/install/InstallUtil.java core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/3837f44a6f2621dde0bea59c522cc1e0464b67c2 Log: JENKINS-35206 - fix potential NPE due to corrupt Jenkins.InstallState (#2385) (cherry picked from commit 541641100b4a9570d72d263a12edbc1e06c987a2)

SCM/JIRA link daemon added a comment - 2017-02-17 20:10

Code changed in jenkins
User: Oleg Nenashev
Path:
core/src/main/java/jenkins/install/InstallState.java
test/src/test/java/jenkins/install/InstallStateTest.java
http://jenkins-ci.org/commit/jenkins/e8467e304ba33329c1afd0fa15a8456f52711f4b
Log:
~~JENKINS-35206~~ - Make the InstallState object deserialization robust against corrupted files (#2387)

~~JENKINS-35206~~ - Add unit tests for the deserialization logic

~~JENKINS-35206~~ - Install state should be robust against messed statuses when deserializing objects

~~JENKINS-35206~~ - Fix the license header in thre test file

(cherry picked from commit 1b2711c9578f5b34bc452fcc3f2dd055b1c0865c)

SCM/JIRA link daemon added a comment - 2017-02-17 20:10 Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/jenkins/install/InstallState.java test/src/test/java/jenkins/install/InstallStateTest.java http://jenkins-ci.org/commit/jenkins/e8467e304ba33329c1afd0fa15a8456f52711f4b Log: JENKINS-35206 - Make the InstallState object deserialization robust against corrupted files (#2387) JENKINS-35206 - Add unit tests for the deserialization logic JENKINS-35206 - Install state should be robust against messed statuses when deserializing objects JENKINS-35206 - Fix the license header in thre test file (cherry picked from commit 1b2711c9578f5b34bc452fcc3f2dd055b1c0865c)

People

Assignee:: Keith Zantow

Reporter:: Axel Behrens

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2016-05-30 05:52

Updated:: 2017-02-17 20:10

Resolved:: 2016-06-06 08:05