Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35247

Move git/svn steps out of workflow-scm-steps

    XMLWordPrintable

Details

    Description

      aheritier pointed out that when installing recommended plugins in Jenkins 2, sometimes the git step does not work in Pipeline builds until after a restart. This is because when workflow-scm-step is loaded, git might not yet be installed, so GitStep.DescriptorImpl would be skipped. If later in the same session git is installed, this extension is not revisited.

      Simpler to keep the SCM-specific steps in the corresponding plugins.

      Attachments

        Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-36666 Jenkins startup fails due to cyclic dependency miscalculation

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-35609 GitStep is missing its descriptor with example build

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-19508 Replace @Extension(optional=true) and optional dependencies with bridge plugins

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-36239 StackOverflowError in plugin manager on 1.596.1

          • Major - Major loss of function.
          • Open
          links to

          Web Link workflow-scm-step PR 2

          Activity

            Ascending order - Click to sort in descending order
            View 6 older comments
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/steps/scm/GitStep.java
            src/main/java/org/jenkinsci/plugins/workflow/steps/scm/SubversionStep.java
            http://jenkins-ci.org/commit/workflow-scm-step-plugin/58237d3ca4f72fa102234910018286d9898cfcc4
            Log:
            Merge pull request #3 from jglick/SCMStep-JENKINS-35247-reflection

            JENKINS-35247 Delegate to Git and Subversion plugins via reflection

            Compare: https://github.com/jenkinsci/workflow-scm-step-plugin/compare/edc5c6262d9f...58237d3ca4f7

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/steps/scm/GitStep.java src/main/java/org/jenkinsci/plugins/workflow/steps/scm/SubversionStep.java http://jenkins-ci.org/commit/workflow-scm-step-plugin/58237d3ca4f72fa102234910018286d9898cfcc4 Log: Merge pull request #3 from jglick/SCMStep- JENKINS-35247 -reflection JENKINS-35247 Delegate to Git and Subversion plugins via reflection Compare: https://github.com/jenkinsci/workflow-scm-step-plugin/compare/edc5c6262d9f...58237d3ca4f7
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/hudson/plugins/git/GitSCM.java
            src/main/java/jenkins/plugins/git/GitStep.java
            src/main/resources/jenkins/plugins/git/GitStep/config.jelly
            src/main/resources/jenkins/plugins/git/GitStep/help.html
            src/main/resources/jenkins/plugins/git/Messages.properties
            src/test/java/jenkins/plugins/git/GitSampleRepoRule.java
            src/test/java/jenkins/plugins/git/GitStepTest.java
            http://jenkins-ci.org/commit/git-plugin/470a4ca0837e1af444423a156e20115f58ae9124
            Log:
            JENKINS-35247 Moved GitStep to git-plugin.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/hudson/plugins/git/GitSCM.java src/main/java/jenkins/plugins/git/GitStep.java src/main/resources/jenkins/plugins/git/GitStep/config.jelly src/main/resources/jenkins/plugins/git/GitStep/help.html src/main/resources/jenkins/plugins/git/Messages.properties src/test/java/jenkins/plugins/git/GitSampleRepoRule.java src/test/java/jenkins/plugins/git/GitStepTest.java http://jenkins-ci.org/commit/git-plugin/470a4ca0837e1af444423a156e20115f58ae9124 Log: JENKINS-35247 Moved GitStep to git-plugin.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Mark Waite
            Path:
            pom.xml
            src/main/java/hudson/plugins/git/GitSCM.java
            src/main/java/jenkins/plugins/git/GitStep.java
            src/main/resources/jenkins/plugins/git/GitStep/config.jelly
            src/main/resources/jenkins/plugins/git/GitStep/help.html
            src/main/resources/jenkins/plugins/git/Messages.properties
            src/test/java/jenkins/plugins/git/GitSampleRepoRule.java
            src/test/java/jenkins/plugins/git/GitStepTest.java
            http://jenkins-ci.org/commit/git-plugin/7e9edc7e448ed29e287171046ba2c859b41a1cd8
            Log:
            Merge pull request #406 from jglick/SCMStep-JENKINS-35247

            JENKINS-35247 Moved GitStep to git-plugin

            Compare: https://github.com/jenkinsci/git-plugin/compare/7a31858e61d2...7e9edc7e448e

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mark Waite Path: pom.xml src/main/java/hudson/plugins/git/GitSCM.java src/main/java/jenkins/plugins/git/GitStep.java src/main/resources/jenkins/plugins/git/GitStep/config.jelly src/main/resources/jenkins/plugins/git/GitStep/help.html src/main/resources/jenkins/plugins/git/Messages.properties src/test/java/jenkins/plugins/git/GitSampleRepoRule.java src/test/java/jenkins/plugins/git/GitStepTest.java http://jenkins-ci.org/commit/git-plugin/7e9edc7e448ed29e287171046ba2c859b41a1cd8 Log: Merge pull request #406 from jglick/SCMStep- JENKINS-35247 JENKINS-35247 Moved GitStep to git-plugin Compare: https://github.com/jenkinsci/git-plugin/compare/7a31858e61d2...7e9edc7e448e
            markewaite Mark Waite added a comment -

            Included in git plugin 2.5.0 released 19 Jun 2016

            markewaite Mark Waite added a comment - Included in git plugin 2.5.0 released 19 Jun 2016
            aheritier Arnaud Héritier added a comment -

            cool. Thanks guys

            aheritier Arnaud Héritier added a comment - cool. Thanks guys

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: