Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35363

Git parameter filter doesn't work

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: git-parameter-plugin
    • Labels:
      None
    • Environment:
      Jenkins 2.8
      git-parameter-plugin 0.5.1
    • Similar Issues:

      Description

      The filter parameter doesn't change the contents of the list. See screenshot.

        Attachments

          Issue Links

            Activity

            kadam Adam Kapos created issue -
            kadam Adam Kapos made changes -
            Field Original Value New Value
            Link This issue is related to JENKINS-27435 [ JENKINS-27435 ]
            Hide
            klimas7 Boguslaw Klimas added a comment -

            Hi @Adam Kapos,

            The quick filter was realized in javascript. Maybe, You have turned off js in browser?
            Which browser you use? If you can, turn on developer mode (in chrom shortcut is F12)in browser and show console output.

            Regards
            Boguslaw

            Show
            klimas7 Boguslaw Klimas added a comment - Hi @ Adam Kapos , The quick filter was realized in javascript. Maybe, You have turned off js in browser? Which browser you use? If you can, turn on developer mode (in chrom shortcut is F12)in browser and show console output. Regards Boguslaw
            Hide
            kadam Adam Kapos added a comment -

            Hi Boguslaw Klimas! I tried with Firefox, Chrome and Safari. Error:

            Show
            kadam Adam Kapos added a comment - Hi Boguslaw Klimas ! I tried with Firefox, Chrome and Safari. Error:
            kadam Adam Kapos made changes -
            Hide
            kadam Adam Kapos added a comment - - edited

            This inline script is on line 81 of the build page:
            <script type="text/javascript">var parentDiv = jQuery('#BRANCH-e0d4b197-8e0a-42a7-aae8-f3b307d4558f');
            new GitParameter.QuickFilter(parentDiv.find('.select').get(0),parentDiv.find('.git_parameter_quick_filter').get(0));</script>

            It gets called before JQuery is ready. In fact, that line throws this error as well:
            TypeError: jQuery is not a function

            Show
            kadam Adam Kapos added a comment - - edited This inline script is on line 81 of the build page: <script type="text/javascript">var parentDiv = jQuery('#BRANCH-e0d4b197-8e0a-42a7-aae8-f3b307d4558f'); new GitParameter.QuickFilter(parentDiv.find('.select').get(0),parentDiv.find('.git_parameter_quick_filter').get(0));</script> It gets called before JQuery is ready. In fact, that line throws this error as well: TypeError: jQuery is not a function
            Hide
            gsakhnovsky George Sakhnovsky added a comment -

            Can replicate on Jenkins 1.653 using Chrome.

            Show
            gsakhnovsky George Sakhnovsky added a comment - Can replicate on Jenkins 1.653 using Chrome.
            Hide
            klimas7 Boguslaw Klimas added a comment -

            Hi,
            You don't have jquery in jenkins please install jquery plugin

            Regards
            Boguslaw

            Show
            klimas7 Boguslaw Klimas added a comment - Hi, You don't have jquery in jenkins please install jquery plugin Regards Boguslaw
            Hide
            gsakhnovsky George Sakhnovsky added a comment - - edited

            Thanks Boguslaw, installing the JQuery plugin (https://wiki.jenkins-ci.org/display/JENKINS/jQuery+Plugin) resolved this issue for us.

            As this is a dependency, does it make sense to declare it? As per https://wiki.jenkins-ci.org/display/JENKINS/Dependencies+among+plugins

            Show
            gsakhnovsky George Sakhnovsky added a comment - - edited Thanks Boguslaw, installing the JQuery plugin ( https://wiki.jenkins-ci.org/display/JENKINS/jQuery+Plugin ) resolved this issue for us. As this is a dependency, does it make sense to declare it? As per https://wiki.jenkins-ci.org/display/JENKINS/Dependencies+among+plugins
            Hide
            kadam Adam Kapos added a comment -

            Confirmed as a fix Would be nice to make it a dependency.

            Show
            kadam Adam Kapos added a comment - Confirmed as a fix Would be nice to make it a dependency.
            Hide
            klimas7 Boguslaw Klimas added a comment -

            Adam Kapos, George Sakhnovsky thanks for using this plugin and testing it. I would add dependency in next release

            Show
            klimas7 Boguslaw Klimas added a comment - Adam Kapos , George Sakhnovsky thanks for using this plugin and testing it. I would add dependency in next release
            klimas7 Boguslaw Klimas made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            Show
            klimas7 Boguslaw Klimas added a comment - https://github.com/jenkinsci/git-parameter-plugin/pull/26
            klimas7 Boguslaw Klimas made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 171653 ] JNJira + In-Review [ 199141 ]

              People

              Assignee:
              klimas7 Boguslaw Klimas
              Reporter:
              kadam Adam Kapos
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: