Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35450

Rename environment variable: JENKINS_SLAVE_AGENT_PORT to JENKINS_AGENT_PORT

    XMLWordPrintable

Details

    Description

      Found while using Jenkins 2.6 docker container, so it needs to be fixed both there and in core.

      Attachments

        Issue Links

          Activity

            oleg_nenashev Oleg Nenashev added a comment -

            This change will be incompatible. -1, needs a better design

            oleg_nenashev Oleg Nenashev added a comment - This change will be incompatible. -1, needs a better design
            bitwiseman Liam Newman added a comment -

            oleg_nenashev How about providing both vars for a while with at task for removing the "slave" one in six months? Is eternal backward compat required?

            bitwiseman Liam Newman added a comment - oleg_nenashev How about providing both vars for a while with at task for removing the "slave" one in six months? Is eternal backward compat required?
            bitwiseman Liam Newman added a comment -

            The originally agreement was that the term slave would be removed from the UI, but left in the APIs to avoid breaking compatibility both for plugins and customer tools/scripts.   The problem is that line of where the UI stops and the API begins is a somewhat fluid when your users are engineers.

            I understand that env vars are effectively part of the API and so changing them is problematic and could be considered out of scope.   But they are also part of the end-user experience (the UI) for every Jenkins user.

            bitwiseman Liam Newman added a comment - The originally agreement was that the term slave would be removed from the UI, but left in the APIs to avoid breaking compatibility both for plugins and customer tools/scripts.   The problem is that line of where the UI stops and the API begins is a somewhat fluid when your users are engineers. I understand that env vars are effectively part of the API and so changing them is problematic and could be considered out of scope.   But they are also part of the end-user experience (the UI) for every Jenkins user.

            People

              Unassigned Unassigned
              bitwiseman Liam Newman
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: