Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35493

severe performance regression after SECURITY-243




      If you have a git changelog with lots of commits by different users and a non-local authentication scheme (basically anything other than the local database) then viewing that page now takes a lot longer as all the users in the commits need to be looked up in the security realm to see if they are valid authentication "users" or if it is just a "full name" that can be resolved from disk.

      There needs to be a way for plugins to say get me a user not for authentication purposes that can if the user has been saved on disk will return that in preference to not hitting the security realm to see if the user does indeed exist.

      setting hudson.model.User.SECURITY_243_FULL_DEFENSE=false helps but there should really be a separate API.

      WIthout this extra API all security realms need to implement multiple caches (a not found cache as well as a regular cache)


        Issue Links


            teilo James Nord created issue -
            teilo James Nord made changes -
            Field Original Value New Value
            Component/s core [ 15593 ]
            Component/s core [ 15738 ]
            Key SECURITY-311 JENKINS-35493
            Workflow Security v1.2 [ 171796 ] JNJira [ 171796 ]
            Project Security Issues [ 10180 ] Jenkins [ 10172 ]
            Status Untriaged [ 10001 ] Open [ 1 ]
            jglick Jesse Glick made changes -
            Labels regression performance regression
            jglick Jesse Glick made changes -
            Link This issue is blocking SECURITY-243 [ SECURITY-243 ]
            teilo James Nord made changes -
            Link This issue is related to JENKINS-35484 [ JENKINS-35484 ]
            rsandell rsandell made changes -
            Assignee rsandell [ rsandell ]
            rsandell rsandell made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            rsandell rsandell made changes -
            Remote Link This issue links to "PR 2446 (Web Link)" [ 14635 ]
            rsandell rsandell made changes -
            Labels performance regression lts-candidate performance regression
            swashbuck1r Spike Washburn made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 171797 ] JNJira + In-Review [ 199165 ]
            olivergondza Oliver Gond┼ża made changes -
            Labels lts-candidate performance regression 2.7.3-fixed performance regression
            markewaite Mark Waite made changes -
            Link This issue is related to JENKINS-38065 [ JENKINS-38065 ]
            svanoort Sam Van Oort made changes -
            Link This issue is duplicated by JENKINS-39084 [ JENKINS-39084 ]
            cloudbees CloudBees Inc. made changes -
            Remote Link This issue links to "CloudBees Internal OSS-1068 (Web Link)" [ 18780 ]


              rsandell rsandell
              teilo James Nord
              1 Vote for this issue
              6 Start watching this issue