• pacific, atlantic, 1.0-b05/b-06, indian

      In Scope

      • All strings and formatting should be localisable
      • Short explanation on how we localise components and the app put in a README.md
      • Go through and extract all our current strings

      Notes

          [JENKINS-35845] Internationalisation for Blue Ocean and JDL

          Michael Neale added a comment -

          Not sure why this one was marked as closed when PR is still open...

          Michael Neale added a comment - Not sure why this one was marked as closed when PR is still open...

          Oleg Nenashev added a comment -

          michaelneale Because the core fix commit text contains the "FIX" text, hence Jenkins bot automatically closed it.
          You guys should not patch multiple components in a single task At least it complicates backporting of the fix to 2.19.3

          Oleg Nenashev added a comment - michaelneale Because the core fix commit text contains the "FIX" text, hence Jenkins bot automatically closed it. You guys should not patch multiple components in a single task At least it complicates backporting of the fix to 2.19.3

          James Dumay added a comment -

          tscherler before closing this ticket out please write some documentation and a cool blog post

          (I can help write the post if you need it)

          James Dumay added a comment - tscherler before closing this ticket out please write some documentation and a cool blog post (I can help write the post if you need it)

          Michael Neale added a comment -

          oleg_nenashev is it ok to have this open or does it have to be closed to simplify the backporting? we can close this and open a ticket for the front end work side of things if that helps?

          Michael Neale added a comment - oleg_nenashev is it ok to have this open or does it have to be closed to simplify the backporting? we can close this and open a ticket for the front end work side of things if that helps?

          Oleg Nenashev added a comment -

          michaelneale it would be helpful

          Oleg Nenashev added a comment - michaelneale it would be helpful

          Michael Neale added a comment -

          Closing this as this tracks the core improvement

          Michael Neale added a comment - Closing this as this tracks the core improvement

          Michael Neale added a comment -

          oleg_nenashev ok I made https://issues.jenkins-ci.org/browse/JENKINS-39225 to track the blue ocean side - you can take over this ticket if you like.

          Michael Neale added a comment - oleg_nenashev ok I made https://issues.jenkins-ci.org/browse/JENKINS-39225 to track the blue ocean side - you can take over this ticket if you like.

          Oleg Nenashev added a comment -

          Converted it to the bug, since Internalization support is an expected behavior for resource logic in Jenkins

          Oleg Nenashev added a comment - Converted it to the bug, since Internalization support is an expected behavior for resource logic in Jenkins

          Jesse Glick added a comment -

          This seems like a feature (a kind of API), not a bug. There is nothing broken in 2.19.3 without this IIUC—just some stuff Blue Ocean is not able to do.

          Jesse Glick added a comment - This seems like a feature (a kind of API), not a bug. There is nothing broken in 2.19.3 without this IIUC—just some stuff Blue Ocean is not able to do.

          Code changed in jenkins
          User: Thorsten Scherler
          Path:
          core/src/main/java/hudson/util/HttpResponses.java
          core/src/main/java/jenkins/util/ResourceBundleUtil.java
          test/src/test/java/jenkins/I18nTest.java
          http://jenkins-ci.org/commit/jenkins/288a66dfabac0a31ce799cc3eaf285dc801cd668
          Log:
          [FIX JENKINS-35845] Internationalisation for Blue Ocean and JDL (#2586)

          • Load i18n resource bundles from plugins if not found in jenkins core

          Signed-off-by: Thorsten Scherler <scherler@gmail.com>

          • Issue 404 response for missing i18n resource bundles

          Currently issues a 200 with an "error" response payload. This change still issues the error response payload, but also sets the HTTP response.

          Signed-off-by: Thorsten Scherler <scherler@gmail.com>

          • JENKINS-35845 add test for getting locale from plugin. fix comments from oleg.
          • eslint - formating changes and fix offences
          • eslint - formating changes and fix offences
          • JENKINS-35845 remove code concerning 404 response. Fix resourceBundle test by prevent NPE to happen

          (cherry picked from commit ab16e52519260c0e9398f15256ed8061a4c00bf0)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thorsten Scherler Path: core/src/main/java/hudson/util/HttpResponses.java core/src/main/java/jenkins/util/ResourceBundleUtil.java test/src/test/java/jenkins/I18nTest.java http://jenkins-ci.org/commit/jenkins/288a66dfabac0a31ce799cc3eaf285dc801cd668 Log: [FIX JENKINS-35845] Internationalisation for Blue Ocean and JDL (#2586) Load i18n resource bundles from plugins if not found in jenkins core Signed-off-by: Thorsten Scherler <scherler@gmail.com> Issue 404 response for missing i18n resource bundles Currently issues a 200 with an "error" response payload. This change still issues the error response payload, but also sets the HTTP response. Signed-off-by: Thorsten Scherler <scherler@gmail.com> JENKINS-35845 Fix test since we return now a 404 JENKINS-35845 add test for getting locale from plugin. fix comments from oleg. JENKINS-35845 Fix description JENKINS-35845 Update PR with comments from Oleg JENKINS-35845 Add feedback from tom eslint - formating changes and fix offences eslint - formating changes and fix offences JENKINS-35845 remove code concerning 404 response. Fix resourceBundle test by prevent NPE to happen JENKINS-35845 Link to issue on which we introduced the test (cherry picked from commit ab16e52519260c0e9398f15256ed8061a4c00bf0)

            tscherler Thorsten Scherler
            jamesdumay James Dumay
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: